elytra/concrete

A solid foundation for Elytra mods. Maintained by everyone.

concrete's Issues

WFluidBar ignores fluid colors

No equivalent method to send messages for "sendToAllNearExcept"

There's no method for sending messages that behaves like "sendToAllNearExcept" in net.minecraft.server.management.PlayerList

Tooltips for WItemSlot instances

I just realized these are missing from the default WItemSlot - should they be added?

@Optional is broken

com.elytradev.concrete.network.exception.BadMessageException: Wire fields cannot be null (in class com.elytradev.correlated.storage.Prototype com.elytradev.correlated.network.inventory.TerminalActionMessage.subject)
	at com.elytradev.concrete.network.WireField.marshal(WireField.java:90)
	at com.elytradev.concrete.network.NetworkContext.lambda$getPacketFrom$1(NetworkContext.java:147)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
	at com.elytradev.concrete.network.NetworkContext.getPacketFrom(NetworkContext.java:147)
	at com.elytradev.concrete.network.Message.toServerboundVanillaPacket(Message.java:399)
	at com.elytradev.concrete.network.Message.sendToServer(Message.java:391)
	at com.elytradev.correlated.client.gui.GuiTerminal.tryAction(GuiTerminal.java:926)
	at com.elytradev.correlated.client.gui.GuiTerminal.mouseClicked(GuiTerminal.java:906)
	at net.minecraft.client.gui.GuiScreen.handleMouseInput(GuiScreen.java:611)
	at net.minecraft.client.gui.GuiScreen.handleInput(GuiScreen.java:576)
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1884)
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1186)
	at net.minecraft.client.Minecraft.run(Minecraft.java:441)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:26)

The field is marked Optional, and Concrete still considers a null illegal.

Use Generics in Marshallable

The title.

This would allow manipulation of the return value for readFromNetwork, so you can set a flag for certain cases to return static instances of variables.

WItemImage

Asking if anyone would want something like this in Concrete - essentially, a widget to display an ItemStack, along with a tooltip, almost exactly like how it's displayed within the vanilla Villager trading GUI.

Add unit tests

The more generic modules, such as Network, could benefit greatly from unit tests. We already have all the CI stuff in place; may as well use it.