Use major-mode other than markdown-view-mode in lsp-ui-doc--render-buffer

[emacs-lsp]

Use major-mode other than markdown-view-mode in lsp-ui-doc--render-buffer

[iromise]

Unexpectedly to encounter Professor Song @MaskRay, 2333.

[sebastiencs]

Thank for taking the time to write this.
Do you think the signature/type/(text with "language":"cpp"/"c"/"objc") has to be display by lsp-ui-doc too ?
As this text is supposed to be shown by lsp-ui-sideline, it would make it appears twice on screen.

[MaskRay]

The old code just displays comments, not code, and IMHO is useful for users who do not use lsp-ui-sidebar.el or rely on eldoc-documentation-function for function types.

-         (--remove-first
-          (when (hash-table-p it)
-            (let ((lang (gethash "language" it)))
-              (or (string= language-id lang)
-                  ;; A language server supporting language-id "cpp" may respond MarkedString{"language":"c"}
-                  (and (string= language-id "cpp") (string= lang "c")))))
-          contents))

Maybe we can provide an option to control whether language related MarkedString ("c" "cpp" "objective-c"), cquery thinks its language-id is "cpp" but for .c file it emits "language":"c") should be rendered (via (lsp-ui-sideline--get-renderer (gethash "language" item))).

When hovering on a function, cquery displays its type with fully qualified function name. The whole type signature can be very long and having them in a child frame may be less appealing. Users are accustomed to eldoc and omitting them from lsp-ui-doc seems fine.