Don’t show doc when window width is less than a threshold

[emacs-lsp]

Don’t show doc when window width is less than a threshold

[sebastiencs]

Yes there isn't any solution to that yet, I will work on it

[casouri]

For now I add a function to my config that detects the width of windows and toggles doc and side line.

One problem is that setting lsp-ui-doc-enable to nil doesn't stop it from showing doc. How should I apply the changes?

[sebastiencs]

You can call (lsp-ui-doc-enable t) and (lsp-ui-doc-enable nil).
Sorry I'm on holiday now I will fix that in 2 weeks

[casouri]

No no, There isn't any problem. I'm saying simply setting the variable doesn't apply changes. I should express that clearer. 😄

[MaskRay]

Do we also want to cancel the auto-enabling when the height is too small? Are there other packages having similar window configuration needs that lsp-ui-doc can take an example from?

[casouri]

I tried to make sure childframe's width is always small enough so the current cursor position is not covered.

P.S. This is just a test version. We can make sure the word at point is not covered by calculating word's length and count it in.

But there isn't any effect that I expected. Nothing really changed.

(defun get-cursor-column ()
  (let ((inhibit-message t))
    (string-to-number
     (substring-no-properties
      (what-cursor-position)
      (+ 7 (string-match "column=.+" (what-cursor-position)))
      ))))

(defun lsp-ui-doc-max-width ()
  (- (window-width) (get-cursor-column)))

(defun lsp-ui-doc--resize-buffer ()
  "If the buffer's width is larger than the current window, resize it."
  (let* ((window-width (window-width))
         (fill-column (min (lsp-ui-doc-max-width) (- window-width 5))))
    (message (format "max width: %d" (lsp-ui-doc-max-width)))
    (message (format "win width: %d" (window-width)))
    (when (> (lsp-ui-doc--buffer-width) (min (lsp-ui-doc-max-width) window-width))
      (lsp-ui-doc--with-buffer
       (fill-region (point-min) (point-max))))))

Any idea?

[MaskRay]

Some commit between emacs-mirror/emacs@1bc998f and
emacs-mirror/emacs@a8be860 breaks the width of the child frame.

With a8be860e17e2a737bda7a4c5075b71f0fb627a92,
The width is good with 1bc998f98f937ee82e29d80e19fda7c32632501a

[sebastiencs]

@MaskRay Thanks, I have reported the bug:
http://lists.gnu.org/archive/html/bug-gnu-emacs/2018-03/msg00376.html

[sebastiencs]

@casouri e7257c9 should improve the situation

[casouri]

Cool, I think that should work for most of the cases. Thanks 😄