emallson/arenalander-league-bot

arenalander-league-bot's Issues

Card lists can overflow into the footer in Deck View

This only happens on decks with too many of a single card type (mostly creatures tbh). I found this CSS hack that pushes the footer down, but it might be better to automatically split it into Creatures and Creatures - Continued

/* applied to the *parent* of div.deck-sections */
min-height: 1px;
overflow: hidden;

As part of this change, we should also move the margin-bottom for footer spacing from div.deck-sections to the footer or the parent.

TappedOut card images don't load

Apparently the script looks specifically for span.mtgcard, while I (somewhere) changed the HTML on our end to div.mtgcard. Minor issue, easy fix. Might need to set the spans to display: block.

Place a discord link on the decklist and standings webpages

This is an enhancement.

Consider placing a link to the discord server on one or both of the webpages.

I expect some players and myself to use the page to share decklists, or just to show off the format, so we should make sure we have an easy link to capture some of that interest.

Use the player name seen via !register, not in DMs

Currently it uses your name as it is in DMs (aka your discord tag, sans #numbers). A lot of people have different names set in the discord server, so it'd be good to make them match.

Deck submission error when submitting a deck with 1 or more bugged cards

The Penny Dreadful gold standard is to refuse deck submission for game-breaking or advantageous bugs. Gladiator Discord pointed out that Lich's Mastery is bugged and they're banning it from tournament play. We should consider having a solution in place.

This enhancement would display a descriptive deck submission error and an easy way to deploy changes to the bugged cards list. We shouldn't have to track these bugs on our own since WotC has a bug portal.

Menu for all webpages

A menubar (on large screens) and menubutton dropdown (on small screens) will give us a place to put requested discord link in issue #1 as well as assist navigation between pages. It should likely contain:

• Home (contains format rules)
• Standings
• Discord
• Github

Home in this case might be performing multiple roles later on, as website landing pages tend to do. We might just call it the Rules page for now until we brainstorm more ideas for future enhancements, as format rules are the least of our messaging concerns for the website itself

Better way to restrict channel access

Removing the bot from each channel is a PITA.

Add MTGA export to decks page

MTGA can (I believe?) import with only card name. The biggest problem for this right now is correctly resolving split card names.

Write CONTRIBUTING doc

and also "how to build"

Make the bot more forgiving about extra spaces

Currently, if you run the command:

!match confirm @emallson 2 0

it will (silently) fail since there is a 2nd space between the mention and the 2.

Two parts:

• ignore empty arguments (thus the command would count 3 args instead of 4 there)
• report command dispatch errors in discord

Matchmaking

An enhancement to lower the barrier to getting into a league match or quick play match.

I started writing up user stories and realized that lots of design choices need to be made.

1. Do both players have to confirm they're ok with playing a specific opponent (via DMing the bot) before making the pairing?
2. Is blocking pairings with a specific community member a core feature?
3. Once one reports a league match, does it automatically requeue them?
4. If both players requeue, do we implement a cooldown before re-pairing them (for a quick play match)? How long?

Split cards show twice on Deck View

This also applies to Adventures, and will presumably apply to aftermath cards once we get them.