emanuelet/trove

Search app for the Trove Books database

trove's Issues

The app crashes when clicking on the "Cart" feature in landscape mode

Expected behavior

Supposedly, I can access the "Cart" feature in landscape mode.

Actual behavior

When I open one of the books, then turn the screen rotation into landscape mode, and then I click on the "Cart" feature the app suddenly crashes.

How to reproduce

1. Install and open the app
2. Do a book search
3. Then Click on one of the books
4. Change screen rotation to landscape mode, then click on feature or icon "Cart".

---

Environment

Tested on 3 devices:

Device	Android Version
Xiaomi Redmi Note 4	Marshmallow, 6.0 mRA58K (DECA-CORE MAX 2,11GHz, RAM: 3 gb)
Xiaomi Redmi 4X	Marshmallow, 6.0.1 mmb29m (CPU: Octa-core Max 1.9 GHz, RAM: 2 GB)
Xiaomi Redmi Note 5A	Nougat, 7.1.0

Application Version: 2.3.0

Recording Of The Bug

https://www.youtube.com/watch?v=lDxoWmkeVCE&feature=youtu.be

Logcat

05-30 23:42:45.567 25665 25665 E AndroidRuntime: Process: com.etapps.trovenla, PID: 25665
05-30 23:42:45.567 25665 25665 E AndroidRuntime: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=null?q=+buy=true (has extras) }
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1809)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.app.Instrumentation.execStartActivity(Instrumentation.java:1523)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.app.Activity.startActivityForResult(Activity.java:4018)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.support.v4.app.BaseFragmentActivityApi16.startActivityForResult(BaseFragmentActivityApi16.java:54)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.support.v4.app.FragmentActivity.startActivityForResult(FragmentActivity.java:67)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.app.Activity.startActivityForResult(Activity.java:3979)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.support.v4.app.FragmentActivity.startActivityForResult(FragmentActivity.java:732)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.app.Activity.startActivity(Activity.java:4302)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.support.v4.content.ContextCompat.startActivity(ContextCompat.java:143)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.support.customtabs.CustomTabsIntent.launchUrl(CustomTabsIntent.java:262)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at com.etapps.trovenla.activities.BookDetailActivity.buyBook(BookDetailActivity.java:89)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at com.etapps.trovenla.activities.BookDetailActivity_ViewBinding$1.doClick(BookDetailActivity_ViewBinding.java:34)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at butterknife.internal.DebouncingOnClickListener.onClick(DebouncingOnClickListener.java:22)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.view.View.performClick(View.java:5275)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.view.View$PerformClick.run(View.java:21556)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:815)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:104)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:207)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:5811)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:907)
05-30 23:42:45.567 25665 25665 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:768)

scraper for book covers

try openlibrary covers or similar

Problematic strings

search strings that actually creates problems:

• clara

(Suggestion) Add feature Categories (New And Popular) and Views in Trove NLA

Components

The components (Features) I want to suggest is:
- Categories (New And Popular)
- Views

Proposal Description

Initially, the Trove NLA app was good enough. However, the available features are still a bit boring. Developers still need to do the development again to make this application to be better and interesting again. Therefore, I would like to suggest some features to make the application even more interesting.

Categories (New And Popular)
This feature is a very important feature, because each user will be able to see the list of books, the latest newspaper and also the most popular. And of course with the addition of this feature, will make the application more interesting.

Views
I suggest this feature, so that app users can see the number of searches on books, newspapers, and pictures. The feature also indirectly can provide information to the user how much search done on the book or newspaper.

Below I am attaching Mockup, to show an illustration if the feature is added.

Mockups / Examples

Original View

Below, a great location for feature placement Categories (New And Popular)

Design examples for features Categories (New And Popular)

Below, a great location for feature placement Views

Design examples for features Views

Benefits

The benefits of the 2 above features as follows:

• With the Categories (New And Popular) feature, users can find the latest and most popular collection of Books, Newspapers, and Images. And This is so users can see the best collection of Books, Newspapers and Pictures.

• And with the "Views" feature in the NLA Trove app, the user can see how many Books, Newspapers and pictures that other users have visited. And Indirectly, the user can see by itself how good and popular it is for certain products (Books, Newspapers, Images).

• Overall, with the feature Categories (New And Popular) and Views, will certainly provide a more attractive appearance for the application. And with the features that can be useful for users, of course users will be more interesting to use it.

Conclusion

The above feature is very suitable added, because it will give a very good effect for the application.