Comments (11)
Also it would be nice to use a redis library which accept the database in the URL.
then-redis ignores the DB in URL and also ignores the database in options
when the URL is used.
from ember-cli-deploy-redis.
@akshayrawat Thanks mate....Will keep this in mind. Fancy flicking us a PR for the change?
from ember-cli-deploy-redis.
Looks like then-redis
was updated recently and supports specifying the DB in the URL, but there may be some bugs there. From what I'm reading here (https://github.com/mjackson/then-redis/blob/57609ba1c6cedbef5686ddc0ba9ec9e58c7989ba/modules/Client.js#L83-L91) looks like database is being pulled from the username slot in a redis://username:password@host/<db>
url
from ember-cli-deploy-redis.
then-redis ignores the DB in URL and also ignores the database in options when the URL is used.
Can confirm this statement, just saw that in action as well ;-)
from ember-cli-deploy-redis.
An update here. Currently then-redis
supports the following Redis config:
redis://db:password@host:port
Per https://www.iana.org/assignments/uri-schemes/prov/redis the config standard should be:
redis://user:secret@localhost:6379/0?foo=bar&qux=baz
from ember-cli-deploy-redis.
FWIW I switched from then-redis
over to ioredis
in node-ember-cli-deploy-redis and have been very happy with it. The PR where I made the change is available here.
from ember-cli-deploy-redis.
thanks for the suggestion @blimmer!
I'll try to write a CTA to see if anyone is interested in tackling the issue
from ember-cli-deploy-redis.
I made good progress on this this afternoon, but there's still some tests to be fixed up.
The previous test implemented stubbed out the Redis client so much that it didn't expose any problems when switching over in #76 . So, the remaining work in this branch is to use the mock, in-memory redis to create higher-fidelity tests.
All tests marked with .skip
are remaining in the link above. I'll try to tackle more of them this week, but help is more than welcome 😄
from ember-cli-deploy-redis.
first, thanks for this @blimmer ! this issue has been neglected for too long, great to see some momentum!
second I think you're definitely right and the previous mocking was way too aggressive, we need to ensure that what we let happen in #76 is not gonna happen again.
I'll definitely see if I can make some time in the near future to look more at the tests but. at the minimum feel free to ping me on slack (@ghedamat) if you get stuck on something.
I'm also sure @achambers and @lukemelia will be around there to help if needed!
thanks again!
from ember-cli-deploy-redis.
I got down to 8 pending tests today and tested this with my app with yarn link
. I should be able to get this over the line tomorrow.
from ember-cli-deploy-redis.
See #86
from ember-cli-deploy-redis.
Related Issues (20)
- Simple redis url does not work HOT 2
- Prember / Multiple File Support HOT 2
- Value already exists for key: app-name:index:default HOT 16
- How to use with sentinel? HOT 2
- improve logging for fetchRevisions HOT 3
- Should an exception be thrown for duplicate redis keys? HOT 5
- Upload multiple files HOT 5
- Inconsistency with keyPrefix HOT 4
- Connecting manually via redis-cli works but ember-cli-deploy-redis gets a "connect ETIMEDOUT" error HOT 12
- TypeError: this.readConfig is not a function HOT 5
- this.readConfig is not a function HOT 3
- How do we set the expire for each key? HOT 2
- then-redis yarn warning HOT 4
- didDeploy hook to publish changes HOT 1
- Error in 1.0.1: this._listRevisions(...).then is not a function HOT 1
- Sample nginx conf HOT 1
- Difficult Error When URL Missing "redis://" HOT 1
- possible to upload multiple files? HOT 2
- then-redis is no longer maintained HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-deploy-redis.