Comments (5)
Closing based on the last comment in this thread
from ember-cli-deploy-redis.
hi @mariogintili
thanks for this.
Could you remove the Gemfile.lock
commit from this PR?
I see it's doing a major update for jekill and I'd rather have that separate (and checked) as there might be some breaking stuff in there
thanks!
from ember-cli-deploy-redis.
hello @ghedamat there isn't a Gemfile.lock
in any commit because this isn't a PR, is an issue 😄
from ember-cli-deploy-redis.
oh gosh, sorry @mariogintili I meant to answer another PR :p, too many tabs open :D
we had a discussion with @achambers about your issue, I believe he'll post the results here soon :)
from ember-cli-deploy-redis.
@mariogintili After some discussion with the team about this it was decided that, for CI, the default value of allowOverwrite
should really be true
which would mean you would never find yourself in the situation.
The allowOverwrite
config option is really a hangover from 0.4.x where the default revision key strategy was using the git sha, and developers testing deploys from their development environment didn't want to have to commit each time they made a change to test their deploy.
The flag can still be used for this but it is the team's view that a CI environment can be viewed as a controlled environment where you can be reasonably confident that you know the state of your code at a point in time and therefore can set allowOverwrite == true
.
It seems that maybe the real change to be made is to the documentation around allowOverwrite
, how it came to be, what it is intended for and how it should be used.
Maybe we can use this issue to track that change instead?
from ember-cli-deploy-redis.
Related Issues (20)
- Simple redis url does not work HOT 2
- Prember / Multiple File Support HOT 2
- Value already exists for key: app-name:index:default HOT 16
- How to use with sentinel? HOT 2
- Swap out then-redis for another redis lib HOT 11
- improve logging for fetchRevisions HOT 3
- Upload multiple files HOT 5
- Inconsistency with keyPrefix HOT 4
- Connecting manually via redis-cli works but ember-cli-deploy-redis gets a "connect ETIMEDOUT" error HOT 12
- TypeError: this.readConfig is not a function HOT 5
- this.readConfig is not a function HOT 3
- How do we set the expire for each key? HOT 2
- then-redis yarn warning HOT 4
- didDeploy hook to publish changes HOT 1
- Error in 1.0.1: this._listRevisions(...).then is not a function HOT 1
- Sample nginx conf HOT 1
- Difficult Error When URL Missing "redis://" HOT 1
- possible to upload multiple files? HOT 2
- then-redis is no longer maintained HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-deploy-redis.