Giter Site home page Giter Site logo

Won't dim from flows about homey-plejd HOT 4 CLOSED

emilohman avatar emilohman commented on June 4, 2024
Won't dim from flows

from homey-plejd.

Comments (4)

Coderaxx avatar Coderaxx commented on June 4, 2024 2

Hi @emilohman & @Gustafssondavid,

I've identified and fixed the issue with dimming from flows in the Homey Plejd app. The problem was in the runWriteLoop function, where the command queue was not handling the commands efficiently, leading to issues with dimming. The fix involves using .pop() to retrieve commands from the queue, and then filtering out any older commands for the same device with the same action. This ensures that only the most recent command for each device is executed, improving the consistency and reliability of dimming through flows.

You can find the details of the fix in pull request #62. Feel free to check it out for more information.

Best regards,
Coderax

from homey-plejd.

richardsimko avatar richardsimko commented on June 4, 2024 1

For anyone looking for a temporary workaround, the last good commit was c44680d. You can check that out, then use the homey CLI to install the app.

  1. homey login
  2. npm install --omit=dev (Installing dev dependencies don't work as it references some packages in a private registry)
  3. homey app install

This should revert your app version to v3.3.4 and mark it as a Development app so it won't be updated. I'm not sure how to get off the development version and restore to the production version but that's a problem for future me, at least the dimming works again now.

Edit: You can simply install the app again from the app store to overwrite the development version

from homey-plejd.

emilohman avatar emilohman commented on June 4, 2024 1

Thank you @Coderaxx! The PR is merged into master and published on app store!

from homey-plejd.

Coderaxx avatar Coderaxx commented on June 4, 2024

Also experiencing this issue after app update recently

from homey-plejd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.