emzeat/linter-cache

Wrapper to accelerate linters like clang-tidy via ccache

linter-cache's Issues

Build fails

$ cmake --version
cmake version 3.25.1
$ ninja --version
1.11.1
$ cd /tmp
$ git clone https://github.com/emzeat/linter-cache
$ cd linter-cache
$ mkdir -p build/release
$ cd build/release
$ cmake -G Ninja -D CMAKE_BUILD_TYPE=Release -S ../.. -B .

Expected

Pre-build step succeeds.

Actual

-- The CXX compiler identification is GNU 12.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:26 (include):
  include could not find requested file:

    build/global.cmake


CMake Error at CMakeLists.txt:27 (include):
  include could not find requested file:

    build/macros.cmake


CMake Error at CMakeLists.txt:28 (include):
  include could not find requested file:

    build/conan.cmake


CMake Error at CMakeLists.txt:29 (include):
  include could not find requested file:

    build/linting.cmake


-- Looking for popen
-- Looking for popen - found
-- Looking for _popen
-- Looking for _popen - not found
-- Looking for close
-- Looking for close - found
-- Looking for mkstemp
-- Looking for mkstemp - found
-- Looking for getpid
-- Looking for getpid - found
-- Looking for unlink
-- Looking for unlink - found
-- Looking for execvp
-- Looking for execvp - found
-- Looking for SYS_pidfd_open
-- Looking for SYS_pidfd_open - found
-- Looking for kevent
-- Looking for kevent - not found
-- Looking for stat
-- Looking for stat - found
-- Looking for getenv
-- Looking for getenv - found
-- Looking for setenv
-- Looking for setenv - found
-- Looking for unsetenv
-- Looking for unsetenv - found
-- Looking for SetEnvironmentVariableA
-- Looking for SetEnvironmentVariableA - not found
-- Looking for GetEnvironmentVariableA
-- Looking for GetEnvironmentVariableA - not found
-- Looking for GetCurrentProcessId
-- Looking for GetCurrentProcessId - not found
-- Looking for GetTempFileNameA
-- Looking for GetTempFileNameA - not found
-- Looking for DeleteFileA
-- Looking for DeleteFileA - not found
-- Looking for GetFileAttributesA
-- Looking for GetFileAttributesA - not found
-- Looking for GetFullPathNameA
-- Looking for GetFullPathNameA - not found
-- Looking for CreateProcessA
-- Looking for CreateProcessA - not found
CMake Error at CMakeLists.txt:110 (mz_target_props):
  Unknown CMake command "mz_target_props".


-- Configuring incomplete, errors occurred!
See also "/tmp/linter-cache/build/release/CMakeFiles/CMakeOutput.log".
See also "/tmp/linter-cache/build/release/CMakeFiles/CMakeError.log".

Caching not reliable on MSVC with additional flags

The commandline passed to ccache seems to be interpreted the wrong way as ccache is not handling MSVC specific options the correct way. Might need to stop hardcoding the CCACHE_COMPILERTYPE=clang and possibly also use clang-cl on some platforms.

In addition it would be great to provide flexibility for overriding this from the outside.

Does this work for C projects?

The tests only seem to cover C++, will this also work for plain C?

Filter note on warnings

Even in quiet mode clang-tidy will produce a note on warnings:

8988 warnings generated.

Would be great if this could be supressed when running through the cache.

Build failing with g++-9

Trying to build the Conan package with g++-9 I get:

.../build/58d5bc4ae2d10f3f07aaff0d425586521cc46062/src/CommandlineArguments.cpp:117:23: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
  117 |     for (int i = 1; i < argc; ++i) {
      |                     ~~^~~~~~
.../build/58d5bc4ae2d10f3f07aaff0d425586521cc46062/src/CommandlineArguments.cpp:133:41: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
  133 |         } else if (arg == "-p" && i + 1 < argc) {
      |                                   ~~~~~~^~~~~~
.../build/58d5bc4ae2d10f3f07aaff0d425586521cc46062/src/CommandlineArguments.cpp:144:41: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
  144 |         } else if (arg == "-o" && i + 1 < argc) {
      |                                   ~~~~~~^~~~~~
cc1plus: all warnings being treated as errors

Bad filepaths when used with CXX_CLANG_TIDY on Win32

CMake will generate paths with backslashes when using the builtin compiler+clang-tidy launcher via the CXX_CLANG_TIDY. These get somehow truncated when passed through linter-cache causing builds to fail on Windows.