enderiumsmith/charcoalpit2

minecraft mod

charcoalpit2's Issues

Charcoal Pit prevents JAOPCA from generating materials

This has stumped me for a while now why JAOPCA doesn't want to generate stuff like for example rose gold and the other metals that the ore kiln has support for. Now that Tinkers has it's own version of Rose Gold I wanted JAOPCA to generate the dust version but it doesn't when Charcoal Pit is in the pack. Tried a clean install with
Forge 36.1.0, JAOPCA 1.16.5-3.4.0.9, Jei 1.16.5-7.7.0.101, mantle 1.16.6-1.6.103, Tconstruct 1.16.5 3.0.4.171, with the config option to force generate materials dusts as "*" to generate dusts for all materials and it works. However with charcoal pit added doesn't generate "copper, gold or rose gold". I'm THINKING this might have to do with that Charcoal Pit adds the dust tags for bismuth, bismuth_bronze, black_bronze, brass, bronze, copper, electrum, gold, lead, rose_gold, silver, tin, zinc, even though they're empty. A solution to this might be to change the recipes for the recipes like the ore kiln to have a condition in the recipe and not bake in the empty tags. Tinkers Construct and Immersive Engineering have like the following in recipes for materials they don't themselves generate.

"conditions": [
{
"value": {
"tag": "forge:ingots/brass",
"type": "forge:tag_empty"
},
"type": "forge:not"
}

[1.12] Kiln cannot be made.

Straw cannot be put into any Kiln. The item will simply pop back into your offhand.
Wood also can't be added to the Kiln if you somehow get the item and straw in.

Bloomery fails

I don't understand the bloomery... I've built the construction. Alas with just one bellow. I click this bellow until the fire shows up in The One Probe as Fully grown. The fire then keeps burning until it goes out. But I end up with a failed bloom every time. Am I supposed to use the bellow(s) until the fire self dies? It seems to take a lot longer than 3.5 minutes...

Btw, I should probably mention that this is for 1.16.5 It's also made out of vanilla bricks.

Coal is not accepted as fuel.

Java 8
MC 1.16.5
Forge 36.1.13
CharcoalPit[1.16.5]-2.11.2.jar

The clay vessel somehow does not accept coal as fuel.

Immersive Engineering Concrete becomes uncraftable with this mod installed

MC 1.16.5
Java 8
Forge 36.1.3
CharcoalPit[1.16.5]-2.9.jar

Mods that use clay and other clay related items in their recipes are incompatible with this mod. The mods in question are Immersive Engineering (latest version) and Immersive Petroleum (also latest version)

To be specific, Concrete and some other recipes that use clay becomes uncraftable when Charcoal Pit is installed along with those mods. Only some recipes are affected like concrete and asphalt concrete. Take note that I did not modify any recipe via a datapack & CraftTweaker is also not installed. The recipe for concrete/asphalt that uses clay balls get removed for some reason, even in the mixer machine, which makes IE concrete literally unobtainable.

Mods installed to reproduce the problem
The problem being that Immersive Engineering/Petroleum Concrete becomes uncraftable when Charcoal Pit is also installed.

CharcoalPit[1.16.5]-2.9.jar
ImmersivePetroleum-1.16.5-3.2.0-3.jar
ImmersiveEngineering-1.16.5-4.2.3-133.jar
JEI

The problem also exists when only Immersive Engineering and Charcoal Pit is installed.

Additional information:
When loading a world, console spits this out:
pastebin.com/wQm9gz4J

[FEATURE REQUEST] Add Compatibility for Bricks/Blocks from Other Mods to be Used as Refractory Blocks

This is a request to at least add a config option or another way to add blocks/bricks from other mods to be compatible and act as refractory blocks with this mod's kiln/oven/bloomery/etc...

I had this idea when I tried playing charcoal pit and several other mods (ie quark that adds cobblestone and mud bricks) in my own personal modpack that add different bricks and dyed brick blocks. Those blocks do not work as refractory blocks for the purposes of this mod as this mod only recognizes bricks from vanilla MC (clay brick, nether brick, ender brick) and the sandy brick from this mod. Because of this, I am stuck to the vanilla bricks to use as refractory blocks, which is tad bummer.

lmao i noticed that I am the one submitting most issues here in your github so sorry for that I guess.

Issues regarding tags and recipes

• Fruit tree Saplings are not on "minecraft:saplings" tag;
• None of the mod's crops are on "forge:crops" tag, except for corn;
• Cherry, Pitaya, Banana, Coconut and Chestnut are not on "forge:fruits/[insert fruit name here] tag;
• Roasted Chestnut is not on "forge:nuts" tag;
• Vinegar recipe doesn't accept items on "forge:fruits" tag, only fruits from the mod;
• Copper block recipe accept any items on "forge:ingots/copper" tag, instead of just Copper Ingots from the mod;
• Log Piles can be uncrafted into Oak Logs, even though their recipe can use any type of logs.

How to Light Bloomery?

I set up a bloomery in 1.16 but I can't figure out how to light it

Tinker's Construct Compatibility(1.16.5)

The Kama of Tinker's Construct is an approximately equal tool with Vanilla Hoe.
However, When I use Kama, I can't get the straw and break the straw block.
I would like the correction of the problem to you.

Crash on Dedicates Server

I am using forge 36.1.4 and 2.11.1 of Charcoal pit and I get the below crash on my dedicated server:

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: main
Stacktrace:
at net.minecraftforge.fml.loading.RuntimeDistCleaner.processClassWithFlags(RuntimeDistCleaner.java:71) ~[custom.jar:36.1] {}
-- MOD charcoal_pit --
Details:
Mod File: CharcoalPit[1.16.5]-2.11.1.jar
Failure message: Charcoal Pit (charcoal_pit) has failed to load correctly
java.lang.RuntimeException: Attempted to load class net/minecraft/client/world/ClientWorld for invalid dist DEDICATED_SERVER
Mod Version: 2.0
Mod Issue URL: NOT PROVIDED
Exception message: java.lang.RuntimeException: Attempted to load class net/minecraft/client/world/ClientWorld for invalid dist DEDICATED_SERVER
Stacktrace:
at net.minecraftforge.fml.loading.RuntimeDistCleaner.processClassWithFlags(RuntimeDistCleaner.java:71) ~[custom.jar:36.1] {}
at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:85) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.TransformingClassLoader$DelegatedClassLoader.findClass(TransformingClassLoader.java:265) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:136) ~[modlauncher-8.0.9.jar:?] {re:classloading}
at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:98) ~[modlauncher-8.0.9.jar:?] {re:classloading}
at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_271] {}
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_271] {}
at java.lang.Class.forName(Class.java:348) ~[?:1.8.0_271] {}
at net.minecraftforge.fml.AutomaticEventSubscriber.lambda$inject$6(AutomaticEventSubscriber.java:75) ~[forge:?] {re:classloading}
at java.util.ArrayList.forEach(ArrayList.java:1259) ~[?:1.8.0_271] {}
at net.minecraftforge.fml.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:62) ~[forge:?] {re:classloading}
at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:91) ~[forge:36.1] {re:classloading}
at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:120) ~[forge:?] {re:classloading}
at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640) ~[?:1.8.0_271] {}
at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1632) ~[?:1.8.0_271] {}
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_271] {}
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1067) ~[?:1.8.0_271] {}
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1703) ~[?:1.8.0_271] {}
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:172) ~[?:1.8.0_271] {}

[1.16] Bloomery recipe input is bugged

Charcoal Pit Version: 2.13
Forge Version: 36.1.16

All recipes for the bloomery, including custom ones made via datapack, default to nickel ore as the input. This is also reflected in JEI.

To Reproduce: Load up the game with charcoal pit and JEI installed and check JEI, and/or try to put iron ore in a bloomery with shift right click like nickel ore.

is there crattweaker support?

[1.16.5] Cannot make kiln

I am unable to place items as instructed, and trying to put straw on a clay vessel isn't working either.

Custom ore kiln recipes render oddly in JEI

For some reason, recipes with more then four ingredients overlap in the JEI screen with the fuel. This could make it confusing for players in custom packs.