enes5519plugins/colorfularmor

ColorfulArmor plugin for Altay and pmmp

ColorfulArmor

colorfularmor's Issues

NOT WORK ON POCKETMINE 3.0.0-ALPHA12

dying bug

TICAL > [ColorfulArmor] Could not execute task Enes5519\colorfularmor\task\ArmorTask: Return value of pocketmine\entity\Living::getArmorInventory() must be an instance of pocketmine\inventory\ArmorInventory, null returned
16:57:45 CRITICAL > TypeError: "Return value of pocketmine\entity\Living::getArmorInventory() must be an instance of pocketmine\inventory\ArmorInventory, null returned" (EXCEPTION) in "src/pocketmine/entity/Living" at line 431
wen i died in nether and then relogin

Now everytime i do /cfa it say Armor Removed , then clear any armor i equip

Update 3.0.0

:b

Tested from poggit.

When dying or changing gamemode then typing /cfa to disable the armor it doesn't disable.
Not sure if this from issue #2 but i'll check if you do fix #2

Better rainbow code

Good morning my friend. I fiddled around a bit, and figured this code works better and is cleaner for rainbow color fading:

	private function updateColor(int $step): Color
	{
		$center = 128;
		$width = 127;
		$frequency = 100;//controls change speed
		$red = sin($frequency * $step + 2) * $width + $center;
		$green = sin($frequency * $step + 0) * $width + $center;
		$blue = sin($frequency * $step + 4) * $width + $center;
		return new Color($red, $green, $blue);
	}

$step can be the current tick. $frequency controls how fast/much the colors change

Original code and read-up can be found here: https://krazydad.com/tutorials/makecolors.php

Commands do not implement PluginIdentifiableCommand

This prevents Poggit from detecting the command, and hence the plugin cannot be searched at https://poggit.pmmp.io/cmds

This is not a critical issue, so your plugin is not immediately rejected. However, please make sure this issue is resolved in your next update.

This issue was created via GitHub API automatically, but you are welcome to reply to this issue to contact me. Sorry about not reading the CONTRIBUTING.md in this repo 🙃