Giter Site home page Giter Site logo

app-admin-home's People

Contributors

alansemenov avatar anatol-sialitski avatar ashklianko avatar dependabot-preview[bot] avatar dependabot[bot] avatar edloidas avatar glennricaud avatar jsi avatar michalklimekplativo avatar pmi avatar poi33 avatar pull-merger[bot] avatar reisfmb avatar rymsha avatar sgauruseu avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

app-admin-home's Issues

Texts in launcher screen are not correctly localized

Some texts in the home screen are not localized according to the browser language.

Looks like the language detection is not correct for the app resources, but it is correct for the admin tool list in the menu

Welcome Tour dialog won't appear on clean XP installation

@alansemenov commented on Tue Mar 20 2018

  1. Make sure you have line tourDisabled = false in com.enonic.xp.admin.ui.cfg and it's not commented out
  2. Run clean installation of XP 6.14.1
  3. Click "or logged in without a user" link on the ID provider page

image

On the Home dashboard the Welcome Tour dialog is supposed to automatically pop-up and the background is blurred as when the dialog is active, but the dialog itself is not visible. Happens only the first time, if you manually delete the browser cookie then the dialog will pop-up fine.

image

7.0.0 changes to the Welcome Tour

It has been decided that the 3 apps that will be installed in the last stage of the Welcome Tour, is:

  • Content Studio
  • Data Toolbox
  • Live Trace

Research: Should test-builds be more closely integrated with code-builds

Currently, the UI tests are "attached" to the project in a separate folder called testing, and in many ways, the UI tests live their own life there. We need to bring things more close together, so if possible, the testAdminHomeApp and the testAdminHomeAppLocally tasks, should be moved to the root build.gradle file, and the code in testing might be better off as a module in the code, instead of a sub-project.

Do research to find the best solution.

At the end, alert @jsi and ask him to change the build configuration in Concourse, so the tests run on commits, and not on schedule.

Validate URLs and escape strings

  • Add validation of the unsafe URLs, that are stored in the global objects;
  • Add escaping of the strings of HTML, that is passed to the Element.setHtml and Element.fromString methods.

Translate missing language phrases to French

The following keys are missing in 'phrases_fr.properties':

  • home.dashboard.about.dialog.license.error
  • home.dashboard.about.dialog.license.name
  • home.dashboard.about.dialog.license.title

Exception occurs when navigated to fourth step in Welcome Tour

Click on next and navigate to 4th step

image

>Error 500: For input string: &quot;0-RC3&quot;</h1></main></body></html>] [code = 500] at com.enonic.xp.admin.impl.market.MarketDataHttpProvider.throwExceptionAttachBody(MarketDataHttpProvider.java:90) at com.enonic.xp.admin.impl.market.MarketDataHttpProvider.parseResponse(MarketDataHttpProvider.java:76) at com.enonic.xp.admin.impl.market.MarketDataHttpProvider.doRequest(MarketDataHttpProvider.java:58) at com.enonic.xp.admin.impl.market.MarketDataHttpProvider.search(MarketDataHttpProvider.java:45) at com.enonic.xp.admin.impl.market.MarketServiceImpl.get(MarketServiceImpl.java:19) at com.enonic.xp.admin.impl.rest.resource.application.ApplicationResource.getMarketApplications(ApplicationResource.java:434)

Add license info to About XP dialog

In order to put our product in the Google Cloud, our licenses must be easily accessible for all users. Here is a design approved by @sigdestad

New License box

So the idea is to replace the three links at the bottom of the current About Box with on line that says "Licensing v" Where the v is some kind of arrow down. When you click on it, the About box expands to show the License information as shown in the screenshot. This should be a long text with scrollbar on the right. The first two lines should be as shown in the screenshot:

  • Enonic XP is licensed udner Gnu Public License v3 (GPL3) (larger font)
  • Enonic XP also uses the following open source software: (grey color text)

After these two texts, all the licenses should be listed, followed by the actual license text. The list of licenses and the license text may be found in the xp and lib-admin-ui projects:

In order to avoid doubly updating the information in these files, the best solution would parse the files, either live or at build time, and include the info in a way shown in the screenshot, where the blue text that states the actual license, just links to the license text below, while the link opens up a new tab to the source code where the actual license is stated.

Note that the "NOTICE.txt" files may be changed around to make them easier to parse. They can be changed to XML, JSON or some other format that allows them to be parsed more easily by the new code.

New test of license dialog

We have added a dropdown with our licenses on the About box and need to test this:

  • Verify that About box has dropdown for licenses, and that it opens a scolling window when clicked.

Don't preprocess xp version when fetching Market apps

In xptour.js we remove "-SNAPSHOT" from version number when fetching apps from the Market in XP tour dialog. So it doesn't work for "-RC1", "-A1" etc.

Send version as it is, we'll preprocess version number in the common lib.

Implement a service for fetching localisation resources

  1. Implement a service inside the app that will call adminLib.getPhrases() and return the object with localisation resources
  2. In main.js remove the call to adminLib.getPhrases() and remove messages property from the controller.
  3. In main.js generate service URL and pass it to the template
  4. In main.html remove messages from the CONFIG object and add service URL instead
  5. In main.ts change the call to api.util.i18nInit and pass service URL from the CONFIG object

Migrate code to TypeScript

Refactor code to use TypeScript and support lib-admin-ui definitions for easier refactoring in the future.

Admin home - Logout redirection should be absolute

Not the first time this regression happens.
The logout redirect URL must be absolute (launcher.js:35)

  • This new toolUrl function is incomplete. Use portalLib.url until then
    portalLib.url({
    path: '/admin/tool'
    type:'absolute'
    })

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.