enricorotundo/jlpms

jlpms's Issues

Fetch repos from Npm instead of GitHub

review LICENCE

Homepage should show the last updated

check the default results in homepage, should show the last updated but it doesn’t (http://0.0.0.0:8080/package/144499900 was updated 7hrs ago but it’s not listed)

Set up deploy

Cannot run webapp

When I run the start command for the webapp (from webapp/) I get this error:

 ↵ 1  npm start                                                                                                                                                                                                                     (jlpms)
npm ERR! missing script: start

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/erotundo/.npm/_logs/2019-03-19T21_50_28_048Z-debug.log

I tried to run npm run build.stag && NODE_ENV=staging node index.js as in package.json but I get another error:

 ~/git/jlpms.io/webapp   master ● ? ⍟1 
 ↵ 127  npm run build.stag && NODE_ENV=staging node index.js                                                                                                                                                                        (jlpms)

> [email protected] build.stag /Users/erotundo/git/jlpms.io/webapp
> webpack --config webpack.stag.js

/Users/erotundo/git/jlpms.io/webapp/node_modules/webpack-cli/bin/cli.js:235
				throw err;
				^

Error: Cannot find module './env.stag.json'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:603:15)
    at Function.Module._load (internal/modules/cjs/loader.js:529:25)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (/Users/erotundo/git/jlpms.io/webapp/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/Users/erotundo/git/jlpms.io/webapp/webpack.stag.js:4:13)
    at Module._compile (/Users/erotundo/git/jlpms.io/webapp/node_modules/v8-compile-cache/v8-compile-cache.js:178:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (/Users/erotundo/git/jlpms.io/webapp/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at WEBPACK_OPTIONS (/Users/erotundo/git/jlpms.io/webapp/node_modules/webpack-cli/bin/convert-argv.js:113:13)
    at requireConfig (/Users/erotundo/git/jlpms.io/webapp/node_modules/webpack-cli/bin/convert-argv.js:115:6)
    at /Users/erotundo/git/jlpms.io/webapp/node_modules/webpack-cli/bin/convert-argv.js:122:17
    at Array.forEach (<anonymous>)
    at module.exports (/Users/erotundo/git/jlpms.io/webapp/node_modules/webpack-cli/bin/convert-argv.js:120:15)
    at yargs.parse (/Users/erotundo/git/jlpms.io/webapp/node_modules/webpack-cli/bin/cli.js:232:39)
    at Object.parse (/Users/erotundo/git/jlpms.io/webapp/node_modules/yargs/yargs.js:567:18)
    at /Users/erotundo/git/jlpms.io/webapp/node_modules/webpack-cli/bin/cli.js:210:8
    at Object.<anonymous> (/Users/erotundo/git/jlpms.io/webapp/node_modules/webpack-cli/bin/cli.js:500:3)
    at Module._compile (internal/modules/cjs/loader.js:722:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (/Users/erotundo/git/jlpms.io/webapp/node_modules/webpack/bin/webpack.js:155:2)
    at Module._compile (internal/modules/cjs/loader.js:722:30)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] build.stag: `webpack --config webpack.stag.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build.stag script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/erotundo/.npm/_logs/2019-03-19T21_54_13_971Z-debug.log

UPDATE
Fixed the second issue by coying env.dev.json to env.stag.json.
Which one do we use? In case update the README.md plz

Should we push "_id" into Algolia's index?

If we need to add "_id" to the list below so that is indexed by algolia we'd need to implement the changes below.

jlpms/fetcher/fetcher.py

Line 55 in d98d186

filter_keys = ["id", "full_name", "description"]

On the other hand, "id" is already being indexed by both mongo and algolia, should we just use that?

Changes needed:

1. change update_one with https://docs.mongodb.com/manual/reference/command/findAndModify/
2. pass mongo's "_id" to algolia "objectID" (https://www.algolia.com/doc/api-reference/api-methods/add-objects/)
3. redeploy lambda

Add "How it works"

I’d add 1 section “How it works” where we explain the idea and how to contact us (can it render a local readme file?)

add "built with Algolia logo" to webapp

Change the name Jlpms

need to re-consider the name….Jlpms is not easy to remember. No worries, let’s deploy it without a domain name, I’ll [@enricorotundo] ask in the Juptyter Forum what’s the most appropriate name for it.

Remove Algolia API key

remove apiKey in clear text at

jlpms/webapp/src/routes/Home.js

Line 48 in 85a221c

apiKey="cc8135b4e1abb63101b50c0b5d606676"

, I’ll (@enricorotundo) invalidate that key, and generate a new one in Algolia

Search bar should update 1 result per match

search bar updates all 12 items in the homepage grid, shouldn’t just show 1 result per match?

Add “Fork Me on GitHub” ribbon