Giter Site home page Giter Site logo

ens-manager's Introduction

ens-manager's People

Contributors

alexvansande avatar hiddentao avatar jefflau avatar veox avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

ens-manager's Issues

When several addresses are added to app, it only uses the first

I have added to accounts to the manager.ens.accounts app in Mist.

When I select a domain that belongs to the first account, I see the usual account owner interface. When I select an account belonging to the second one, I do not.

  • It should be possible to add many accounts to the app.
  • It should be possible to manually toggle to see the domain owner functions even if the app thinks the domain does not belong to you.

Delete node function

function sets owner to 0, which deletes the node. Check if subnodes exist before deleting and if there are confirm with owner if he really wants to delete it

UI for creating subdomain

Think this would be best to have an add button (maybe with a +) in the tree next to siblings or if there are no siblings just below in the tree

Can't register reverse claim on testnet

I'm trying to register a testnet ens domain with a reverse lookup. I'm running on Rinkeby. The app seems to be getting into a loop trying to validate the record.

reverse ENS record update function

Input to search an address.
If (address.owner === me && ethDomainOwner === me)
update the reverse ENS record to resolve to this .eth name

This will be useful to automatically replace addresses with .eth names automatically. Many names can point to one address, but only one address can point to a name for the reverse record

UI for updating relevant info on a node

Must include:

  • Update the owner of the node if they own the node or its parent node.
  • Update the resolver of the node if they own it, offering an option to use a default public resolver.
  • Set the resolver to a predetermined public resolver address
  • Delete the node (by setting its owner to 0). Ideally to check if there is any subnode before committing.

Possibly include reversal UI:

  • If the selected address is an account the user can send from, claim the address via the reverse registrar.
  • If the user owns the selected address, set the resolver record, offering an option to set a default public resolver.
  • If the user owns the selected address and the resolver is not 0, set the name associated with the address if the resolver supports it.

Remove Sync calls

New sync calls are not permitted on the newest versions of web3.js. As a result, the app will not detect the correct user and therefore not allow you to manage it and log an error:

Uncaught (in promise) Error: No callback given, sync calls are not possible anymore in Mist. Please use only async calls.

You should replace all web3.eth.accounts[0] by a web3.eth.getAccounts(function(e,accounts){ // do something });.

The sync accounts is used in the registry file and the on the reverse node details

Content hashes must be prefixed by 0x

When registering a swarm content hash as the content in the default resolver I have to manually insert 0x in front of the swarm hash in order for it to work.

This is a nuisance that many people (in swarm support channel) have tripped over this past year.
It would be great if manager.ens.domains could correctly handle swarm hashes without the 0x prefix or at least display an appropriate warning.

default resolver - set address

Using default public resolver contract 0x5ffc014343cd971b7eb70732021e26c35b744cc4
After loading my domain and switching to the 'Resolver Details' tab, nothing happens when I put in an address and click 'Set Addr'...no transaction prompt in MetaMask, no feedback in GUI.

'Get Details' including subdomain

When you search for a path that includes a subdomain, the node shows up in the right half of the GUI, but no info appears on the left half of the GUI (all Node Details and Resolver Details are blank)

App no longer responds to click on "Get Details"

I compile the app at commit 3d5901f on June 14th 2018.

Compilation succeeds with the following output:

npm WARN The package whatwg-fetch is included as both a dev and production dependency.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

audited 8285 packages in 6.321s
found 328 vulnerabilities (296 low, 25 moderate, 5 high, 2 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

When the app runs on localhost:3000, I can see the manager.ens.domains interface, but the site is unresponsive to any clicks for "Get Details".

It seems that the same is true for the hosted site at manager.ens.domains.

[Minor] Add correct subdomain prefix for etherescan links

Just a minor UX tweak: when browsing the records for a given name (ex: https://manager.ens.domains/name/michalzalecki.test), it would be nice to have the links pointing to the right Etherscan subdomain according to the current account in the injected web3.

For instance, when browsing this name, registered in rinkeby, the owner, resolver and address links all point to the mainnet's version of Etherscan.

Main net Owner => "no matching entries"
Rinkeby Owner => success

setSubnodeOwner - transaction failure

Transaction to change subdomain owner failed (Bad jump destination)
TxHash: 0x27c067dc8abda60f6dde7b01b366b358b7b64f502eb9fb62a4d632c4d81ffcca
gas used: 4,467,015

Was it out of gas? It used a lot of gas compared to successful setOwner transaction:
TxHash: 0x2761db9293cdb7caefb8eff20846bb39c2fe3ca90e9aa46c9ec9d60028fa6571
gas used: 31,981

Need support for EIP 1577

Any name in ENS that is set up using the 'default public resolver' (using manager.ens.domains, or manager-beta.ens.domains for example) will now be using a new resolver that conforms to EIP 1577.

https://eips.ethereum.org/EIPS/eip-1577

As such, the content field has changed to contenthash and the app no longer works with this resolver for setting content hashes.

The app should be updated to check what the resolver supports and act accordingly.

Create subdomain function

example:

If ethereum.eth is owned, they can create a subdomain for awesome.ethereum.eth. This function is recursive and can make subdomains indefinitely

UI for ENS reverse record

Input to search an address.

UI checks to see if you are owner. If not shows error message.

Allows you to search .eth address

UI check to see if you are owner. If not shows error message

If (address.owner === me && ethDomainOwner === me)
update the reverse ENS record to resolve to this .eth name

This will be useful to automatically replace addresses with .eth names automatically. Many names can point to one address, but only one address can point to a name for the reverse record

not recognizing me as domain owner

I'm using Mist 0.9.0 with Ledger Nano S and authorized the account that owns the domain. I'm trying to play with the Swarm integration and set the content of my resolver, but none of the buttons are showing up that allow me to manage the domain. I see in the dev console that it thinks it is using MetaMask when the page loads? Maybe it is broken with latest release of Mist?

Add UI to allow deletion of nodes

Caching to local storage is currently already implemented. Once there is UI to delete nodes, it will allow users to refresh and take nodes they don't want out of their cached list

Request: support for domains owned by multisig

When a domain is owned by a multisig account that I am a party of, I cannot see the owner functions in manager.ens.domains.

It would be nice if I could manually enable the owner functions so that the app could generate for me the transactions (such as add resolver, change content hash etc...) that would then have to be signed by the partners to the multisig. (c.f. also #38 )

error: run-p dev styles:watch

c:\projects\ens-manager-master>npm start

[email protected] start c:\projects\ens-manager-master
run-p dev styles:watch

'run-p' is not recognized as an internal or external command,
operable program or batch file.

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\Rocky\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "start"
npm ERR! node v7.4.0
npm ERR! npm v4.2.0
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] start: run-p dev styles:watch
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script 'run-p dev styles:watch'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ens-management package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! run-p dev styles:watch
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs ens-management
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls ens-management
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! Please include the following file with any support request:
npm ERR! C:\Users\Rocky\AppData\Roaming\npm-cache_logs\2017-06-03T13_08_17_453Z-debug.log

c:\projects\ens-manager-master>

cache support for multiple networks

Cache currently dumps all domains together so if you switch to testnet it doesn't save which network you are on, so you could have .xyz or .test from ropsten on the main net.

UI for Subdomain add

subdomains can be added manually before all the subdomains have been 'fetched'.

Console error "Cannot read property 'registry' of undefined"

Reddit comment:

When I start typing and I enter a '.', the first error appears:

ens.js:698 Uncaught (in promise) TypeError: Cannot read property 'registry' of undefined
at _callee2$ (https://manager.ens.domains/static/js/main.48b587ac.js:19517:74)
at tryCatch (https://manager.ens.domains/static/js/main.48b587ac.js:65153:41)
at Generator.invoke [as _invoke] (https://manager.ens.domains/static/js/main.48b587ac.js:65391:23)
at Generator.prototype.(anonymous function) [as next] (https://manager.ens.domains/static/js/main.48b587ac.js:65205:22)
at step (https://manager.ens.domains/static/js/main.48b587ac.js:18938:192)
at https://manager.ens.domains/static/js/main.48b587ac.js:18938:362
at
Then, when I hit 'Get details', after a second or two, the exact same error appears in the console.

https://www.reddit.com/r/ethereum/comments/6j1k78/first_beta_release_of_the_ens_manager_app_manage/djb9d08/?st=j4bk0h6s&sh=2429f468

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.