entur/gbfs-java-model

gbfs-java-model's Issues

Return nicer types for geofencing multi-polygons

Right now the geofencing multipolygons are returned in quite an awkward type: List<List<List<List<Double>>>>

Since I'm planning to implement geofencing zones in OTP I was wondering if we could return a type like org.geojson.MultiPolygon from https://github.com/opendatalab-de/geojson-jackson.

The problem is that there appears to be not an easy way to override the generated java type unless you add it to the JSON schema. It's would only be a very small change to the schema but feels a bit dirty.

What do you think, @testower?

cc @hannesj

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• Update dependency org.assertj:assertj-core from v3.25.0 to v3.25.1

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency org.apache.maven.plugins:maven-gpg-plugin from v1.6 to v3
• Update dependency org.owasp:dependency-check-maven from v5.3.2 to v9

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• Update cimg/openjdk Docker tag to v21
• Update dependency org.apache.maven.plugins:maven-deploy-plugin from v2.8.2 to v3
• Update dependency org.apache.maven.plugins:maven-install-plugin from v2.5.2 to v3
• Update dependency org.apache.maven.plugins:maven-surefire-plugin from v2.22.2 to v3
• Update dependency org.apache.maven.wagon:wagon-ssh-external from v2.12 to v3
• Update dependency org.codehaus.mojo:exec-maven-plugin from v1.6.0 to v3

Detected dependencies

circleci

.circleci/config.yml

• cimg/openjdk 17.0
• cimg/openjdk 17.0

maven

gbfs-java-model/pom.xml

• com.fasterxml.jackson.core:jackson-databind 2.16.1
• de.grundid.opendatalab:geojson-jackson 1.14
• org.junit.jupiter:junit-jupiter-api 5.10.1
• org.junit.jupiter:junit-jupiter-engine 5.10.1
• org.assertj:assertj-core 3.25.0
• org.apache.maven.wagon:wagon-ssh-external 2.12
• org.apache.maven.plugins:maven-compiler-plugin 3.12.1
• org.apache.maven.plugins:maven-jar-plugin 3.3.0
• org.apache.maven.plugins:maven-clean-plugin 3.3.2
• org.apache.maven.plugins:maven-install-plugin 2.5.2
• org.apache.maven.plugins:maven-site-plugin 3.12.1
• org.apache.maven.plugins:maven-resources-plugin 3.3.1
• org.apache.maven.plugins:maven-deploy-plugin 2.8.2
• org.codehaus.mojo:exec-maven-plugin 1.6.0
• org.jsonschema2pojo:jsonschema2pojo-maven-plugin 1.2.1
• org.apache.maven.plugins:maven-compiler-plugin 3.12.1
• org.codehaus.plexus:plexus-compiler-javac 2.14.2
• org.apache.maven.plugins:maven-surefire-plugin 2.22.2
• org.apache.maven.plugins:maven-enforcer-plugin 3.4.1
• org.jacoco:jacoco-maven-plugin 0.8.11
• org.codehaus.mojo:versions-maven-plugin 2.16.2
• org.owasp:dependency-check-maven 5.3.2
• com.amashchenko.maven.plugin:gitflow-maven-plugin 1.21.0
• org.apache.maven.plugins:maven-source-plugin 3.3.0
• org.apache.maven.plugins:maven-javadoc-plugin 3.6.3
• org.apache.maven.plugins:maven-gpg-plugin 1.6

pom.xml

rule-factory/pom.xml

• org.jsonschema2pojo:jsonschema2pojo-maven-plugin 1.2.1
• org.apache.maven.plugins:maven-compiler-plugin 3.12.1
• org.codehaus.plexus:plexus-compiler-javac 2.14.2
• org.apache.maven.plugins:maven-deploy-plugin 2.8.2

---

• Check this box to trigger a request for Renovate to run again on this repository

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>entur/abt-renovate-config:renovate). Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Incorrectly generated models

GBFSVehicleCapacity
https://github.com/MobilityData/gbfs-json-schema/blob/master/station_information.json#L135

GBFSVehicleTypeCapacity
https://github.com/MobilityData/gbfs-json-schema/blob/master/station_information.json#L167

Lists are initialized by generator

Lists should not be initialized as empty lists by default. E.g.:

@JsonProperty("per_km_pricing")
    @JsonPropertyDescription("Array of segments when the price is a function of distance travelled, displayed in kilometers (added in v2.1-RC2).")
    private List<GBFSPerKmPricing> perKmPricing = new ArrayList<GBFSPerKmPricing>();