envyware/envyhunt

envyhunt's Issues

[EnvyHunt] Unable to use Custom NBT Tags

I've been trying to make a pixelmon:pixelmon_sprite to look like a Ditto in the reward's GUI by writing the NBT Tags like below, but when changed this only prevents the hunt's GUI to load. Also tried it for keys in Nebula, none work and the same issue happens.

nbt:
        form:
            type: string
            data: ''
            sub-data: {}
        gender:
            type: byte
            data: '2'
            sub-data: {}
        ndex:
            type: short
            data: '132'
            sub-data: {}
        palette:
            type: string
            data: 'none'
            sub-data: {}

Setting "enable-particles: false" causes the server to crash

Crash report:

[01:43:27 ERROR]: Exception caught during firing event net.minecraftforge.fml.common.gameevent.TickEvent$ServerTickEvent@297a2782:
 java.lang.NullPointerException: null
        at com.envyful.pixel.hunt.remastered.forge.shade.envy.api.forge.items.ItemBuilder.<init>(ItemBuilder.java:49) ~[ItemBuilder.class:?]
        at com.envyful.pixel.hunt.remastered.forge.hunt.ForgePixelHunt.display(ForgePixelHunt.java:69) ~[ForgePixelHunt.class:?]
        at com.envyful.pixel.hunt.remastered.forge.ui.HuntUI.open(HuntUI.java:50) ~[HuntUI.class:?]
        at com.envyful.pixel.hunt.remastered.forge.commands.PixelHuntCommand.lambda$executeCommand$0(PixelHuntCommand.java:28) ~[PixelHuntCommand.class:?]
        at com.envyful.pixel.hunt.remastered.forge.shade.envy.api.forge.concurrency.listener.ServerTickListener.onServerTick(ServerTickListener.java:29) ~[ServerTickListener.class:?]
        at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_149_ServerTickListener_onServerTick_ServerTickEvent.invoke(.dynamic) ~[?:?]
        at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:96) ~[ASMEventHandler.class:?]
        at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:186) [EventBus.class:?]
        at net.minecraftforge.fml.common.FMLCommonHandler.onPreServerTick(FMLCommonHandler.java:275) [FMLCommonHandler.class:?]
        at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:767) [MinecraftServer.class:?]
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:624) [MinecraftServer.class:?]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_312]
[01:43:27 ERROR]: Index: 9 Listeners:
[01:43:27 ERROR]: 0: NORMAL
[01:43:27 ERROR]: 1: ASM: net.minecraftforge.common.ForgeInternalHandler@5df045e3 onServerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 2: ASM: de.waterdu.aquaapi.ui.internal.AquaUIListener@3914141c onServerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 3: ASM: de.waterdu.aquagts.atlantis.ui.internal.AquaUIListener@4a52f6cc onServerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 4: ASM: de.waterdu.aquagyms.event.Events@538d31cb onTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 5: ASM: de.waterdu.aquagyms.gym.queue.Queue@54754e43 onTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 6: ASM: com.envyful.pixel.hunt.remastered.forge.task.ParticleDisplayTask@50eec6b3 onServerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 7: ASM: com.pixelmonmod.pixelmon.TickHandler@1a0c5360 onServerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 8: ASM: com.pixelmonmod.pixelmon.spawning.TrackingSpawnerCoordinator@2137b14a onTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 9: ASM: com.envyful.pixel.hunt.remastered.forge.shade.envy.api.forge.concurrency.listener.ServerTickListener@321b751f onServerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: 10: ASM: com.envyful.pixel.hunt.remastered.forge.shade.envy.api.forge.gui.ForgeGuiTracker$ForgeGuiTickListener@29864ca6 onServerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$ServerTickEvent;)V
[01:43:27 ERROR]: Encountered an unexpected exception

Error in console on latest build

https://pastebin.com/C6g89Mgt

[EnvyHunt] ''Gender'' error and ''Growths'' error

1st Issue:
When using the "- randomgender" config, it can randomly choose "genderless" for pokemon that always have gender.

Either make always choose a gender and ban genderless pokemons in config, or make it search for a pokemon with gender when that option is used please.

2nd Issue:
When using "randomgrowths" and reloading the hunts several times, the Hunt's GUI stops showing up. This is an example of what I've been using:

"- randomgrowths:pigmy,runt,small,ordinary,huge,giant,enormous:5"

[EnvyHunts] Errors with IVs and Particles

Noticed that when using "randomivpercentage" it will select an iv percentage number as usual, but will make that number the only one accepted by the hunt, so if the hunt chooses the number 15, only 15% IVs pokemon will be accepted, nothing above or below, not as in previous versions where anything from 15% or above was fine. Is there any way to make this work as in previous versions?

Also, in the code you need to have a "- random" line with nothing else for it to work, for example:

requirement-specs:
- random
- randomivpercent:10-20

And lastly the particle effects only apply to pokemon valid for the hunt, if it doesnt meet the IV requirements for example even though being the same species, it doesn't have the particles. This tells the players what pokemon to ignore or not withing the same species

Suggestion - A blocked-types setting

There doesn't seem to be a blocked-types setting like in the older versions.
It would be useful to have to prevent certain Pokémon from appearing in hunts such as Pokémon that evolve with an item or condition, fossils, babies, legends, UBs, etc. so basically any Pokémon that doesn't spawn naturally such as those in the undiscoverable egg group (legends and UBs are doable with specs but not the others I don't think).
If this can already be achieved, do let me know.

Thanks!

Start Commands Only Activated After Time Out

The start commands aren't actually activated upon someone successfully catching a hunt and starting a new one. They seem to only work if the hunt expires from no one catching the hunt Pokemon.

Suggestion - Support for randomivpercent as a reward spec

Looks like the randomivpercent doesn't currently work in reward-specs and can't apply the spec on the caught Pokémon.
Would be a great addition :)

Growth is not showing up on Pokemon in Hunt Menu.

I set require-growth to true, but this information is not displayed in Pokemon.

PixelHuntRemastered-Forge Ver.0.7.0

Expert-2:
        gui:
            X: 7
            Y: 3
        random-reward-commands: true
        reward-commands:
        - minecraft:give %player% pixelmon:dynamax_candy 1
        - minecraft:give %player% pixelmon:xl_exp_candy 4
        - minecraft:give %player% pixelmon:xl_exp_candy 6
        - minecraft:give %player% pixelmon:xl_exp_cand 8
        require-species: true
        allow-legends: false
        allow-ultra-beasts: true
        allow-evolutions: false
        require-gender: true
        require-growth: true
        numer-of-possible-growths: 2
        require-nature: true
        number-of-possible-natures: 2
        require-iv-percentage: true
        random-iv-generation: true
        minimum-iv-percentage: 30
        maximum-iv-percentage: 100
        max-ivs: false
        iv-multiplier-enabled: true
        iv-multiplier: 1.5
        max-duration-minutes: 120

Bug - Randomgender gives wrong genders

Some regular Pokémon are getting a genderless gender requirement and vice versa.
For example, Solgaleo being male or Shellos being genderless.
Should also consider Pokemon with 100% male or female ratios such as Hitmontop (100% male) to prevent them from getting an impossible gender.

Server crashing when using /hunt after setting "gender-requirement" to "false"

Config file with "gender-requirement" set to "false": https://pastebin.com/GRCMK7a9
Error: https://pastebin.com/N09HDqPp

Suggestion - %form% and %palette% for sprites

Similar to the %dex_number% placeholder, one for form and palette would be great to show their sprite properly in the UI.
Currently, the pixelmon:pixelmon_sprite item fallsback to the poke ball if the form isn't specified for some pokemon such as sinistea or florges.

Suggestion - Tweaks for random growth & nature specs

When a random number of growths or natures are chosen, some are repeated. I suggest they aren't repeated so that 3 different ones can be pulled from a list of 6, for example.

The variable %pokemon% in broadcast does not support localization

The variable %pokemon% in broadcast does not support localization

Raid Den Pokemon cannot be caught (catch button throws an error)

Server API: Arclight
Hunts version: 3.2.0

After completing a Raid Den, the Catch button cannot be clicked. Trying to click the button outputs this error in console: https://pastebin.com/GGyJwLsL

Hunt Pokemon reset every time you open the GUI

Version: EnvyHunt 4.0.2

I believe this is because when a hunt times out it calls the reset method, but this doesn't reset the time of the hunt in the config causing the pokemon to be reset in a loop

RandomGender Spec Can Give Impossible Genders

Pokemon whose only genders are Male and Female are able to have a Genderless Requirement in Hunts

Reward-GUI-Title in Config Doesn't Change the Reward GUI Title

Seems that the main title will override it.

Server crash, "Unable to construct this menu by type"

Hunts version: 3.2.1 (currently latest)
Crash log: https://pastebin.com/paEYkALT

I've only had this crash twice, but they were both within the last 2 days, on the same version. It appears both crashes happened when a player did /hunt. In one case, I was able to see in the logs that a player successfully ran /hunt, then the server crashed when they ran in again 2 minutes later. The hunts were not re-rolled during this time, so the crash is seemingly unrelated to the specific Pokemon sprites in the GUI

Option to turn the blacklist into a whitelist

Missing documentation - Blacklist and whitelist pokémon from hunts

Hi, I saw that in the old versions of EnvyHunt it was possible to create blacklists and whitelists for the pokemon that could be hunted, is it possible to do it in the new versions too (>4.0.0)? If it is possible, how can this be configured? Thanks in advance for the support.

PS: The *.yml extension is not supported by github, so I uploaded the config files with the *.txt extension

config.txt
guis.txt

If the required-gender option is set to true, genderless Pokémon should not be able to be available for that hunt type - shouldn't need to blacklist Pokémon manually : (

Reloading from console responds with "You cannot use this command from this source"

Whilst it is not a priority and reloads the configs, it is not clear at first as you are told that the command cannot be ran from the console.

Pokemon in the GUI display that they are a photo rather than the actual Pokemon

[EnvyHunt] Banned Pokemon List not working

The "Banned Species" list in "Config" file is not working, tried several spacings, everything well written in YAML but none seem to work.