Giter Site home page Giter Site logo

enylin / taiwan-id-validator Goto Github PK

View Code? Open in Web Editor NEW
348.0 348.0 40.0 800 KB

中華民國統一編號、身分證字號驗證規則

License: MIT License

JavaScript 6.24% TypeScript 93.31% Shell 0.44%
arc barcode cdc credit-card donate-code e-invoice gui-number javascript npm taiwan typescript

taiwan-id-validator's People

Contributors

dependabot[bot] avatar enylin avatar fifieldt avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

taiwan-id-validator's Issues

能否不要以throw Error的方式來提供驗證失敗的情況

驗證失敗不是例外錯誤 而是預期的結果 (是的 預期他可能會失敗)
使用Throw 可能會導致使用時真的讓使用者感受到無法預期的錯誤發生 而不是驗證失敗的結果
這導致使用方可能被迫再使用的時候得仰賴 catch 來捕捉失敗的驗證
我個人認為 其實只需要建立一個 result 的 interface
例如 像是這樣

export interface ValidateResult {
    source: string;
    isValid: boolean;
    failReason: string;
}

你可以再透過一個快速產生結果的做法來完成他 例如

export namespace ValidateResult {
   export Success(source: string): ValidateResult {
      return {
         source,
         isValid: true,
         failReason: ''
      };
   }
   export Fail(source: string, failReason: string): ValidateResult {
       return {
           source,
           isValid: false,
           failReason,
       }
   }
}

另外, 通常如果我們在驗證上透過例外的方式來呈現的方法名稱是 ensure
ensure的意思是請保證他符合預期 那麼此時 驗證失敗就是不符合預期的事情
那麼此時再使用 throw Error 來處理驗證失敗的情況
並且再方法回傳時回傳要被驗證的值
讓使用方可以像是回到還沒調用驗證錢的情況下繼續接下來的處理

以上僅建議 如果有不清楚想釐清的部分 也可以討論
我沒有急著想要這些功能 (如果有我就fork or pull request了)
所以只是想提供意見而已

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.