ephys/minecraft-magic-feather

A nerfed reimplementation of the XU angel ring

Magic Feather (minecraft mod)

This mod adds a Magic Feather that gives its bearer creative flight within the range of a vanilla beacon.

Why ?

I like the Angel Ring from Extra Utilities but find it removes the fun out of travelling in minecraft. It renders horses, minecarts, boats, and the elytra completely useless.

It also makes certain challenges too easy (twilight forest, ender dragon, ...).

This system lets you have creative flight in and around your base without removing the fun flying around in an elytra. It also promotes building vanilla beacons which are underused.

minecraft-magic-feather's Issues

missing language javafml:33

Your version 3.1.0 shows up as compatible for MC 1.16.1 (in twitch). However, it will give an error stating it needs language javafml:33 or higher (I'm using forge 32.0.108).

[bug] Spelling mistake "withing"

The tooltip has a misspelling of "within" as "withing", which I can understand because it's one I make often too ;)

Support beacon from netherite plus mod

1.15.1 Crash on server load

Added mod to server, server crashes on load with the attached error.

https://hatebin.com/nqqlwpilbj

magicfeather-1.15.1-2.2.0.jar Magic Feather
Forge 30.0.39

Memory usage increases every time a world is loaded

In the top right of the f3 menu it shows the memory usage. It fluctuates a lot, but I am looking at the smallest value it reaches before going up again, which I assume is when the garbage collector has just run.

To reproduce

1. Create a new world with all defaults.
2. Look at the memory usage.
3. Exit the world from the esc menu without closing minecraft. Load the world again. Repeat a lot of times.
4. Wait until the lowest value stabilizes.
5. Look at the memory usage.

Result
The memory usage increased from 23% when I first opened the world to 42% after having opened the world 50 times. I had given minecraft 4GB ram so I guess that means every time the world is reloaded the memory usage increases by around 80 MB. In the heavily modded world where I first noticed this the difference seems to be much bigger though, enough that the game crashed without me even trying, so it can probably be a big problem in some circumstances.

Versions
Magic Feathers: 4.2.0
CookieCore: 4.0.1
Minecraft: 1.18.2
Forge: 14.23.5.2855

Height limit locked to 70 blocks

Minecraft 1.18.2
Forge 40.1.68
Magic Feather 4.2.0

It appears that no matter how you configure the vertical range limit, you cannot rise more than 70 blocks above the nearest Beacon, and if you are set to "FullHeight", you cannot fly more than 70 blocks below the nearest beacon. Looking at the code, I suspect that that is because the POI code is limited to a 70 block search radius. In other words if it could find the Beacon it would let you ascend to the highest possible block, but as it only searches +/- 70 blocks for the Beacon, this limit takes affect first.

Replace bauble with curios

Not working with Alex Mobs (beacon POI error)

I am using version 4.00 of the mod with Alex's mobs version 1.18.6 and the game does not want to load as it says both magic feather and alex mobs is using the same beacon blockstate as a point of interest and its not allowed.

Missing recipe in 1.15.2

Hi! I commented earlier on the mod page, but now that I've had time to double check that I didn't make an error, I'm gonna put in an issue. I am using:

MC 1.15.2
Forge 31.2.30
JEI 6.0.2.12
Magic Feather 2.2.2
CookieCore 2.1.2-37c5343

In an instance with just those mods, I am able to replicate the fact that no recipe seems to be added. Both right and left clicking in JEI bring up nothing, same with "u" and "r" hotkeys (I know it wouldn't be "u" but it never hurts to double check). I also checked in a crafting grid using the recipe you gave me in the mod page comments:

As you can see, it doesn't seem to work. For me, this isn't really a HUGE issue because I was probably going to edit the recipe using crafttweaker anyway. However, since it doesn't seem to be intended behavior, I thought I'd let you know! Thanks very much for your time!

Add russian translation

User kazmurenko from curseforge translated the mod to russian: https://www.curseforge.com/minecraft/mc-mods/magic-feather#c48

{
  "item.magicfeather.magicfeather": "Волшебное перо",
  "item.magicfeather.magicfeather.tooltip.out_of_beacon_range": "Должен быть в пределах диапазона радиомаяка"
}

[Suggestion] Baubles Support

Could you add Baubles Support so you don't need to have the feather in the inventory?

Config option for slow fall

Could the slow fall feature be an option please? It leads to floaty hops for the two seconds after touching down. And in most cases (in the version prior), the fall from going out of range doesn't deal fall damage anyway.

The mod disables other mods flight abilities when in mod-packs.

It disables all forms of flight from other mods as your code blocks other mods code to work. Examples of this is shown in this reddit post:
https://www.reddit.com/r/feedthebeast/comments/84rcy8/magic_feather_disabling_all_other_forms_of/
this code here disable all other mods abilities flight abilities:
https://github.com/Ephys/minecraft-magic-feather/blob/master/src/main/java/be/ephys/magicfeather/ItemMagicFeather.java

Anti-cheeze: disable flight if mobs are nearby?

This has been requested on the curseforge thread https://www.curseforge.com/minecraft/mc-mods/magic-feather#c25

I think it would be off by default

Creative flight buggy movement

Hey I play the 1.16.2 - 1.16.4 (3.1.0) version on
Minecraft 1.16.5
Forge 36.0.42

Now I rly wanted to use this mod, but the creativ flight (not only with the feather also in creative mode) gets buggy when you double tap the space bar (start or stop flight).
In each Video I only double tap once at the start and then it gets shakey.

magicfeather1.mp4

magicfeather2.mp4

Beacon no longer needs to be lit in 1.18

While there are config options to change the base radius and step radius, there's no way to make it required to be lit but still have even steps up for range. Vanilla beacon range behavior is [0, 20, 30, 40, 50], but with the config it's only possible to have [10, 20, 30, 40, 50] or [0, 10, 20, 30, 40].

Proposed fix: "base_range" should pertain to a lit beacon, rather than a beacon on the ground with nothing under it, in which case the default config would be 20.

1.19.2

This sounds like an amazing mod. I am playing better mc modpack. But this mod could be a blast with all the other mods. So if you have the time it would be amazing on 1.19.2

1.15.2 compatibility

Hey Ephys,

thank you for this mod. I think this is a really cool idea!

Now for my "issue": Could you update it, so one can use it with 1.15.2? I just tested it for myself by updating mods.toml and it worked fine so far. I will open a PR with this change, too.

Best, Kevin