eranboudjnah/cleanarchitectureforandroid

Clean Architecture for Android - a sample project

cleanarchitectureforandroid's Issues

Connection history does not properly restore list when you rotate the screen

Hello Eran. This seems to be a problem the view not restoring the HistoryViewState into HistoryViewState.HistoryRecords. So when the screen rotates it stays on HistoryViewState.Loading

[Question]: Parameterized test

Hello Eran. I am on the process of reading your book and came across to the testing of the model mappers.

On the file SavedIpAddressRecordToPresentationMapperTest.kt how does the actualValue work? I mean when you call the toPresentation that should return different instance of an object right? so why the test succeeded?

val actualValue = classUnderTest.toPresentation(givenSavedRecord)

When I tried I have a failure test. Even though my expected and actual are the same they are different object since classUnderTest.toPresentation(givenSavedRecord) will create a new instance

here is my error

Expected :link.limecode.newsfeed.presentation.model.pagination.PaginationPresentationModel@7bd7d6d6
Actual   :link.limecode.newsfeed.presentation.model.pagination.PaginationPresentationModel@50029372

I cant wrap around my head why does yours works and mine did not

here is my full class

package link.limecode.newsfeed.presentation.mapper

import link.limecode.newsfeed.domain.model.pagination.PaginationDomainModel
import link.limecode.newsfeed.presentation.model.pagination.PaginationPresentationModel
import org.junit.Assert.assertEquals
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.junit.runners.Parameterized
import org.junit.runners.Parameterized.Parameters

@RunWith(Parameterized::class)
class PaginationToPresentationMapperTest(
    private val given: PaginationDomainModel,
    private val expected: PaginationPresentationModel
) {
    companion object {
        @JvmStatic
        @Parameters(name = "Given {0} then {1}")
        fun data(): Collection<Array<*>> = listOf(
            testCase(
                nextCursor = null,
                prevCursor = null
            ),
            testCase(
                nextCursor = "next_id",
                prevCursor = null
            ),
            testCase(
                nextCursor = null,
                prevCursor = "prev_id"
            )
        )

        private fun testCase(
            nextCursor: String?,
            prevCursor: String?
        ) = arrayOf(
            PaginationDomainModel(
                nextCursor = nextCursor,
                prevCursor = prevCursor
            ),
            PaginationPresentationModel(
                nextCursor = nextCursor,
                prevCursor = prevCursor
            )
        )
    }

    private lateinit var classUnderTest: PaginationToPresentationMapper

    @Before
    fun setUp() {
        classUnderTest = PaginationToPresentationMapper()
    }

    @Test
    fun `When toPresentation`() {
        // given

        // when
        val actual = classUnderTest.toPresentation(given)

        // then
        assertEquals(expected, actual)
    }
}

thank you