erdmannfreunde/contao-grid-bundle

contao-grid-bundle's Issues

Contao 5.1 Support

Contao 5.1 requires Symfony 6, while the grid extension requires Symfony 5

composer update -W
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - symfony/config[v5.0.0, ..., v5.0.8] require php ^7.2.5 -> your php version (8.1.10) does not satisfy that requirement.
    - Root composer.json requires contao/manager-bundle 5.1.* -> satisfiable by contao/manager-bundle[5.1.0].
    - Root composer.json requires erdmannfreunde/contao-grid-bundle 2.0.2 -> satisfiable by erdmannfreunde/contao-grid-bundle[2.0.2].
    - erdmannfreunde/contao-grid-bundle 2.0.2 requires symfony/config ^5.0 -> satisfiable by symfony/config[v5.0.0, ..., v5.4.19].
    - You can only install one version of a package, so only one of these can be installed: symfony/config[v2.2.0, ..., v2.8.52, v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.44, v5.0.0, ..., v5.4.19, v6.0.0, ..., v6.2.5].
    - Conclusion: install symfony/config v6.1.11 (conflict analysis result)

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

1.0.4 - Migration schlägt fehl

Contao 4.9.16
MariaDB 10.4.17

`15:39:25 CRITICAL [console] Error thrown while running command "contao:migrate". Message: "An exception occurred while executing 'UPDATE tl_content SET tstamp = ? WHERE (tstamp='' OR tstamp='0') AND (type='colEnd' OR type='rowEnd')' with params [1626881965]:

SQLSTATE[22007]: Invalid datetime format: 1292 Truncated incorrect DOUBLE value: ''" ["exception" => Doctrine\DBAL\Exception\DriverException^ { …},"command" => "contao:migrate","message" => """ An exception occurred while executing 'UPDATE tl_content SET tstamp = ? WHERE (tstamp='' OR tstamp='0') AND (type='colEnd' OR type='rowEnd')' with params [1626881965]:\n \n SQLSTATE[22007]: Invalid datetime format: 1292 Truncated incorrect DOUBLE value: '' """]`

Column breaking out on firefox when using Contao Content Slider

I am using the Grid Bundle in combination with the Contao Content Slider.

It seems there is a problem on Firefox.

https://test.office.bohn.media/

The fourth element is a content slider. Everything seems fine on Chrome and Edge.

But in Firefox (Windows, v100.0) the column breaks out when it contains a Content Slider.

Reihe Start Fehler bei Update auf neuste Version 1.1.0

Nach dem Update eurer Version 1.1.0 funktioniert mein Contentelement "Reihe Start" nicht mehr ordnungsgemäß. Der übernimmt nicht meine Klassen darin und außerdem lädt er irgendwie auch nicht eure CSS. Bei mir steht alles jetzt untereinander.

Composer will Grid Bundle 2.0 nicht laden

Hallo Dennis,

nach dem Update auf PHP 8.1 hatte ich noch EUF Grid im Contao Manager (Contao 4.9.38). Nachdem sich das Bundle nicht parallel installieren ließ, habe ich EUF Grid plus DB-Einträge gelöscht, aber dennoch kam folgende Meldung von Composer:

`composer update erdmannfreunde/contao-grid-bundle contao/conflicts --no-install --dry-run

Resolving dependencies using Composer Cloud v3.5.1
[6.6MiB/0.17s] Loading composer repositories with package information
[58.7MiB/6.53s] Updating dependencies
[76.3MiB/6.80s] Your requirements could not be resolved to an installable set of packages.
[76.3MiB/6.80s]
Problem 1
- Root composer.json requires erdmannfreunde/contao-grid-bundle ^2.0 -> satisfiable by erdmannfreunde/contao-grid-bundle[2.0.0].
- erdmannfreunde/contao-grid-bundle 2.0.0 requires contao/core-bundle ^5.0 -> found contao/core-bundle[5.0.0, ..., 5.0.8] but these were not loaded, likely because it conflicts with another require.

[76.3MiB/6.80s] Running update with --no-dev does not mean require-dev is ignored, it just means the packages will not be installed. If dev requirements are blocking the update you have to resolve those problems.
[34.7MiB/6.82s] Memory usage: 34.65MB (peak: 164.25MB), time: 6.83s.
[34.7MiB/6.82s] Finished Composer Cloud resolving.`

Es sind nur noch TabControl und mmenu installiert, die keine Probleme machen.
Was könnte ich da noch tun?

Marion

Add example Sass Source file

see erdmannfreunde/euf_grid#21

Übersetzung/Label für Grid-Klassen ermöglichen

Immer wieder kommt der Wunsch auf, dass Klassen wie col-md-4 in für nichtentwickler verständliche Sprache übersetzt werden könnte.

Wäre es ohne BC möglich, die Klassen zusätzlich mit „Übersetzungen“ auszustatten?

Contao 4.11 - Abhängigkeiten

Die Abhängigkeiten zu Symfony müssten auf 5 angepasst werden.

https://github.com/ErdmannFreunde/contao-grid-bundle/blob/master/composer.json#L28-L30

Partial overwriting with config.yml not working

Contao: v4.13.4
Bundle: v1.0.6

I tried to add an additional viewport in "config/config.yml".

erdmannfreunde_contao_grid:
  viewports:
    - xs
    - sm
    - md
    - lg
    - xl
    - xxl

After adding the viewport I got the following error.

[2022-05-18T12:23:51.600016+02:00] request.CRITICAL: Uncaught PHP Exception TypeError: "Argument 1 passed to ErdmannFreunde\ContaoGridBundle\GridClasses::__construct() must be of the type string, array given, called in /var/www/vhosts/office.bohn.media/dpi.office.bohn.media/var/cache/prod/Container1oMqeOX/getGridClassesService.php on line 22"

I checked the arguments by changing the GridClasses.php

public function __construct(
    $rowClass,
    $columns,
    $columns_no_column,
    $viewports,
    $viewports_no_viewport,
    $column_prefixes,
    $options_prefixes,
    $pulls,
    $positioning,
    $directions,
    $options_columns
) {
    echo "---------- rowClass ----------\n";
    var_dump($rowClass);
    echo "---------- columns ----------\n";
    var_dump($columns);
    echo "---------- columns_no_column ----------\n";
    var_dump($columns_no_column);
    echo "---------- viewports ----------\n";
    var_dump($viewports);
    echo "---------- viewports_no_viewport ----------\n";
    var_dump($viewports_no_viewport);
    echo "---------- column_prefixes ----------\n";
    var_dump($column_prefixes);
    echo "---------- options_prefixes ----------\n";
    var_dump($options_prefixes);
    echo "---------- pulls ----------\n";
    var_dump($pulls);
    echo "---------- positioning ----------\n";
    var_dump($positioning);
    echo "---------- directions ----------\n";
    var_dump($directions);
    echo "---------- options_columns ----------\n";
    var_dump($options_columns);
    exit();
}

The output:

---------- rowClass ----------
array(6) {
  [0]=>
  string(2) "xs"
  [1]=>
  string(2) "sm"
  [2]=>
  string(2) "md"
  [3]=>
  string(2) "lg"
  [4]=>
  string(2) "xl"
  [5]=>
  string(3) "xxl"
}
---------- columns ----------
string(3) "row"
---------- columns_no_column ----------
array(12) {
  [0]=>
  int(1)
  [1]=>
  int(2)
  [2]=>
  int(3)
  [3]=>
  int(4)
  [4]=>
  int(5)
  [5]=>
  int(6)
  [6]=>
  int(7)
  [7]=>
  int(8)
  [8]=>
  int(9)
  [9]=>
  int(10)
  [10]=>
  int(11)
  [11]=>
  int(12)
}
---------- viewports ----------
bool(true)
---------- viewports_no_viewport ----------
bool(true)
---------- column_prefixes ----------
array(2) {
  [0]=>
  string(3) "col"
  [1]=>
  string(8) "row-span"
}
---------- options_prefixes ----------
array(2) {
  [0]=>
  string(9) "col-start"
  [1]=>
  string(9) "row-start"
}
---------- pulls ----------
array(2) {
  [0]=>
  string(9) "pull-left"
  [1]=>
  string(10) "pull-right"
}
---------- positioning ----------
array(2) {
  [0]=>
  string(5) "align"
  [1]=>
  string(7) "justify"
}
---------- directions ----------
array(4) {
  [0]=>
  string(5) "start"
  [1]=>
  string(6) "center"
  [2]=>
  string(3) "end"
  [3]=>
  string(7) "stretch"
}
---------- options_columns ----------
array(12) {
  [0]=>
  int(1)
  [1]=>
  int(2)
  [2]=>
  int(3)
  [3]=>
  int(4)
  [4]=>
  int(5)
  [5]=>
  int(6)
  [6]=>
  int(7)
  [7]=>
  int(8)
  [8]=>
  int(9)
  [9]=>
  int(10)
  [10]=>
  int(11)
  [11]=>
  int(12)
}

The option "viewports" is used as first option now, all other options moved one further.

EuF-Grid CSS wird nicht geladen

Hallo Freunde,
die EuF-Grid CSS Datei wird nach dem letzten Update (1.0.8 -> 1.1.1). nicht mehr geladen.
Beim zurücksetzen auf die 1.0.8 funktioniert alles wieder.

PHP: 8.1
Contao 4.13

Adding Grid-Options to Row-Element

Is there a reason that i can't add Grid-Options to a Row-Element? Or do I have to adjust something in my config.yml to make this possible?
In my current case, i want to add the "justify-content-between"-class to my row, to push the columns inside to the left/right side of the row.

Anzeige fehlt in Rocksolid Custom-Elements

In Inhaltselemente, die über Custom-Elements erstellt wurden, werden die Grid-Einstellungen nicht mehr angezeigt.

Letzte Version nicht kompatibel mit Contao 4 (siehe screenshot)

Ich kann mit Contao 4.13.26 und PHP 8.1 das mit Contao-Manager nicht installieren. Ich müsste manuell die Version 1.1.3 einstellen. Hat dann geklappt..

Probleme nach Update auf Version 1.1.0

Hallo @denniserdmann,

nach dem Update von 1.0.8 auf 1.1.0 habe ich Probleme mit dem Layout bei zahlreichen Installationen.
So ganz genau kann ich die Ursache noch nicht ausmachen.
Es sieht so aus, also ob die CSS-Definitionen fehlen würde.

Als schnelle Übergangslösung habe ich jetzt ein Downgrade auf die 1.0.8 gemacht bzw. einen Conflict für die Version 1.1.0 eingetragen.

Enhancement column order classes

Columns are sometimes reordered when breakpoint changes. Eg. on mobile test first then picture while from 'md' on the picture should be left and the text right. The start-col and end-col option does not work.

Grid has the style order: <num>.

Could you generate an option serie like:
order-1, order-2...
order-sm-1, order-sm-2...
order-md-1, order-md-2... etc.

Thank you very much.

Symfony 5 Compatibility

When updating an from contao 4.10 to 4.11 i got this error:

contao/manager-plugin: ...done generating plugin class
> @php vendor/bin/contao-setup

Fatal error: Uncaught ArgumentCountError: Too few arguments to function Symfony\Component\Config\Definition\Builder\TreeBuilder::__construct(), 0 passed in /contao-latest-ee/vendor/erdmannfreunde/contao-grid-bundle/src/DependencyInjection/Configuration.php on line 23 and at least 1 expected in /contao-latest-ee/vendor/symfony/config/Definition/Builder/TreeBuilder.php:26
Stack trace:
#0 /contao-latest-ee/vendor/erdmannfreunde/contao-grid-bundle/src/DependencyInjection/Configuration.php(23): Symfony\Component\Config\Definition\Builder\TreeBuilder->__construct()
#1 /contao-latest-ee/vendor/symfony/config/Definition/Processor.php(50): ErdmannFreunde\ContaoGridBundle\DependencyInjection\Configuration->getConfigTreeBuilder()
#2 /contao-latest-ee/vendor/symfony/dependency-injection/E in /contao-latest-ee/vendor/symfony/config/Definition/Builder/TreeBuilder.php on line 26

I found a similar ticket here: terminal42/contao-url-rewrite#24
and the original ticket here: contao/contao#2844

RowStart Widget triggers Warning in Dev Mode

The RowStart widget triggers a warning because there is no $this->Template in widgets. rowClass needs to be set on the widget instance directly.

See https://github.com/ErdmannFreunde/contao-grid-bundle/blob/master/src/Form/FormRowStart.php#L32

Service fehlt -> Fehlermeldung bei der Einbindung von mehrseitigen Formularen

Moin,

ich bekomme in Verbindung mit mehrseitigen Formularen immer die Fehlermeldung:

request.CRITICAL: Uncaught PHP Exception Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: 
"You have requested a non-existent service "ErdmannFreunde\ContaoGridBundle\EventListener\AddGridClassesToFormListener". 
Did you mean one of these: "ErdmannFreunde\ContaoGridBundle\EventListener\AddGridClassesToContentListener", 
"ErdmannFreunde\ContaoGridBundle\EventListener\DataContainer\GridClassesOptionsListener", 
"ErdmannFreunde\ContaoGridBundle\EventListener\DataContainer\GridColsOptionsListener"?"
 at /home/vagrant/code/bps.test/vendor/symfony/dependency-injection/Container.php line 271

Spricht irgendetwas dagegeben, in der services.yml folgende Zeile in der Erweiterung einzufügen? (denn das löst das Problem in meiner Installation)

ErdmannFreunde\ContaoGridBundle\EventListener\AddGridClassesToFormListener:
        public: true