ergunemr/bottompopup

BottomPopup provides a popup-like presentation style to any view controller

bottompopup's Issues

Access Control

BottomPopup/BottomPopup/BottomPopupController/BottomPopupViewController.swift

Line 17 in 886c3ba

override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) {

override public init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) { 

Please change s.swift_version = "3.0" to newer version

Change height of popup view controller

I would like to change the height of the popup view controller after I select a button, how can I go about doing this?

Dismiss popup and leave small area of it in bottom

I want to get the following functionality: showing closed popup with its visible area in bottom and expand it on pull. Is that possible using your pod, @ergunemr ?

Change height of navigation controller

Thanks alot first of all, this has been a very helpful library lately. Just wanted to know if I can change height of Navigation Controller according to the ViewController size e:g Root View Controller size of Navigation Controller is 200 and when I push another View controller, I want the size of Navigation Controller to be changed to 500. Is this possible currently or can it be added in future updates?

Open view

Can we open this view from top to bottom? If yes then where should be change the code?

Thank's in advance.

Controller Width on iPad

Hi,

Thanks for open source this.

I've seen how we can control the height, I'm wondering does it support customized width so that it will look even better on iPad.

Thanks

Crash iOS 13 xcode 11

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__SwiftValue set]: unrecognized selector sent to instance

Dynamic height (Auto Layout)

How can we handle dynamic height?

Now we can only set height , constant in popupHeight.

Thanks.

Delegate Functions

Any plans to add some delegate functions like willDismiss or didChangeToFrame?
So we can layout content under the Popup?

Add support for UIScrollViews, UITableViews and UICollectionViews

Would it be possible to add support for scroll views to this library so we can replicate UI such as the apple maps/stock app drawer. There are a few library's that do this already such as PullUpController or FloatingPanel. However these library are either very large or do not use all the latest apple APIs such as UIPresentationControllers or UIPercentDrivenInteractiveTransition.

TopPopUp?

Is it possible to show this popup from top?

Bottom popup loading issue

I have integrated bottom popup into one of my application.
Which do have tableview on selected and row i am trying to pop up exampleViewController.
its loading first time quickly as per given inputs, on second time its takes time.
On double click on tableviewcell its loading quickly. Did not understand what went wrong.

    func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {

        print("Selected Index",indexPath.row)
        guard let popupVC = storyboard?.instantiateViewController(withIdentifier: "StatusDetailViewController") as? StatusDetailViewController else { return }
        popupVC.height = 600
        popupVC.topCornerRadius = 30
        popupVC.presentDuration = 0.3
        popupVC.dismissDuration = 0.3
        popupVC.shouldDismissInteractivelty = true
        popupVC.popupDelegate = self
        present(popupVC, animated: true, completion: nil)

    }

StatusDetailViewController is same as ExamplePopupViewController.

How to change dynamic height based array data?

I want to reload the height after data comes from server without loosing animation effect. its jerking if call this line

(self.presentationController as? BottomPopupPresentationController)?.containerViewWillLayoutSubviews()

fileprivate func adjustListHeight()-> CGFloat{ let height = UIScreen.main.bounds.size.height * 50 / 100 // if self.dataArray.count == 0{ // // return height // }else{ // if dataArray.count > 10{ // let height = UIScreen.main.bounds.size.height * 50 / 100 // return height // }else{ // return CGFloat(((dataArray.count + 1) * 44) + 70) // } // } return height } override var popupHeight: CGFloat{ return adjustListHeight() }

BottomPopupTransitionHandler memory leak

@ergunemr Any plans to release v0.7.1 which includes the memory leak fix in #40? I see the version was updated, but no release/tag has been made, so we can't specify v0.7.1 in Swift Package Manager. Thanks

Width proble,

Hi I use BottomPopUp to select user cards
When BottomPopUp shows width is not equal to by self.view

I need equal width BottomPopUp with my root view

I want to support pure code（for navController）

Need Swift 4 Support

HI, I Could see podspec has s.swift_version = "3.0". is your pod swift 4 supportive ?
Thanks

How can I work with bottom view is present half area and parent view is another half?

how can I work when bottom view present ,then the parent view will be access ,please help with this topic ,like map bottom search view.

Unable to present bottomPopup above all views

I have a view (Now playing music) above Tabbar I am adding it like this
appDelegate.window?.rootViewController?.addChild(nowPlayingView) appDelegate.window?.addSubview(miniPlayerView.view)
when I click on it. It shows the full view inside the full view there is a button that displays the BottomPopup I am unable to display the BottomPopup above the presented View I tried the different solution but only 1 worked with me

`

let transition = CATransition()

transition.type = CATransitionType.push

transition.subtype = CATransitionSubtype.fromTop

   	popupVC.view.layer.add(transition, forKey: nil)

    appDelegate.window?.rootViewController?.addChild(popupVC)

    appDelegate.window?.addSubview(popupVC.view)

    popupVC.didMove()

`
and that's lead to another issue that's I am unable to dismiss it on swipe
please, can someone help?
Thank you

unable to install it with pod

getting "[!] Unable to find a specification for BottomPopup" error while installing with pod

About UITextField keyboard hide content

Hey,

big thanks for this library

I should use UITextField in BottomPopup, but when call up the keyboard, we can't see what we had input.

can I popup a ViewController with NavigationBar?

can I popup a ViewController(named A) with NavigationBar, and use this bar to push another ViewController(named B)
A and B has same height

TextField in BottomPopup

Hey, I want to add a textfield into the view.

But the keyboard is hiding it.

How can we resolve that?

Andras

Access Control

BottomPopup/BottomPopup/BottomPopupController/BottomPopupViewController.swift

Line 17 in 886c3ba

override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) {

override public init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) { ... }

Method does not override any method from its superclass

I subclass the BottomPopupViewController and override the following 3 methods. I can be built on my local, but failed on the build server with Fastlane. The following errors occurred:

�[31m❌  �[0mPositionSelectViewController.swift:58:19: �[31mmethod does not override any method from its superclass�[0m

    override func getPopupHeight() -> CGFloat {
�[36m                                       ^�[0m



�[31m❌  �[0mPositionSelectViewController.swift:62:19: �[31mmethod does not override any method from its superclass�[0m

    override func getPopupPresentDuration() -> Double {
�[36m    ~~~~~~~~      ^�[0m



�[31m❌  �[0mPositionSelectViewController.swift:66:19: �[31mmethod does not override any method from its superclass�[0m

    override func getPopupDismissDuration() -> Double {

The weird thing is it can be built if I delete the override keyword of the methods(of course the functions take no effects), which lead build fail on my local.

Both my local Mac and the build server running Xcode Version 11.3.1 (11C504) with CocoaPods version 1.8.4.

Invested two days for the issue, and can't get it to work on both sides. Any help or advice will be appreciated.

Use of undeclared 'BottomPopUpDelegate'

I copy pasted the BottomPopUpController folder in my project and tried to use it but I'm having this issue. It says "Use of undeclared type 'BottomPopupDelegate' " .

What to do in this situation？

i present the navigation controller with navigationBar, which is the subclass of BottomPopupNavigationController. custom the height is 400. it manage controller A.
in some case, i need push a controller( just call B) from A, and B controller height is same as the keywindow, just like the nomal push action.
What to do in this situation?

Leave ViewController under Popup accessable

Is there a chance to have the ViewController under the Popup accessable?
The User should interact with both the Popup and the underlying ViewController.
Like the Maps App...

Add support for composition

Hey,

big thanks for this library, its nice to see these kind of menus done properly using UIPresentationControllers, UIPercentDrivenInteractiveTransition etc. It would be awesome if this library changes it logic from inheritance to Composition. So instead of subclassing it would be nice to just add the content view controller as a child view controller of the pop up menu.