erkyrath/cheapglk

Cheapass implementation of the Glk API

cheapglk's Issues

Recursive call to gli_mktime on Win32

In cgdate.c, there is this:

#ifdef WIN32
#define mktime gli_mktime

Then later on:

#ifdef WIN32
time_t gli_mktime (struct tm * timeptr)
{
...
    time_t ret = mktime(timeptr) - offset;
}

But since mktime has been defined as gli_mktime, this will call itself instead of calling the standard library function.

The simplest fix may be:

#define mktime(tm) gli_mktime(tm)
...
time_t ret = (mktime)(timeptr) - offset;

to avoid macro expansion inside of gli_mktime.

extern "C" for glk.h header (and other gi_*.h headers?)

As noted here: iftechfoundation/ifarchive-if-specs#2

Client code can, of course, wrap the include in extern "C", but it would be very convenient if instead glk.h itself had such a declaration, wrapped in #ifdef __cplusplus.

Switch to MIT license already

glk_fileref_create_by_prompt should validate that files exist on read

filemode_Read: The file must already exist; the player will be asked to select from existing files which match the usage.

If you type the name of a nonexistent file, return NULL.

Change gettimeofday() to timespec_get(TIME_UTC)

gettimeofday() has been deprecated for a while.

Command-line arguments for resource loading

glk_stream_open_resource() only works when running from a blorb file. We would like a way to support this call in a non-blorb context.

Proposal (from discussion with Graham):

./terp -dataresource 3:FILENAME ...

This means that when calling glk_stream_open_resource() or glk_stream_open_resource_uni() with argument 3, the given filename will be opened. Multiple -dataresource arguments may be given. When running from a blorb, an argument overrides the blorb contents if the number matches.

(Glk library arguments are single-dash, interpreter arguments are double-dash. Sorry, it seemed clever when I was thirty.)

This feature will go into remglk also.

EDIT: -dataresource 3:FILENAME, no equals sign.

glk_stream_open_file should silently return null on missing read file

This change will apply to all my interpreters. Keeping this open until they're all fixed. (Unless I decide to post duplicate bugs, but we'll see how long it takes me.)