esl-lewis/neutronics_tool

Takes beam cycle excel input, displays time series and converts to variety of output formats

neutronics_tool's Issues

Irrad tool wrapper needs finishing

Complete command line wrapper irrad_tool.py to be completed.

must be a better way for valid date checking

the user input date read part does a couple of checks but there are many cases it does not check for
e.g.

• only adding a year and no month or year.

• months with days other than 31

• dates in the future

• dates before the data

im sure this is a problem that has been solved and rather than reinvent the wheel find the solution. incidentally pandas datetime part does check if its a valid month etc, this might be part of the solution

Cyclical Imports

Utilities and format_from_EXCEL modules try to import each other, leads to error messages.
Need to rework overall module design.

format to fluka has a list index bug

i used dates 2015 1 1 to 2016 1 1 and the fluka output file throws a list index error with line 129 which in my version is
irrprofi = str("IRRPROFI"+(20 - (len(str(countdays[x]))+9))" "
+str(countdays[x])+"."+(10-len(str(flux[x])))" "
+str(flux[x])+(9-len(str(countdays[x+1])))" "
+str(countdays[x+1])+"."+(10-len(str(flux[x+1])))" "
+str(flux[x+1])+(9-len(str(countdays[x+2])))" "
+str(countdays[x+2]) +"."+(10-len(str(flux[x+2])))" "
+str(flux[x+2])+"\n")

the tool needs tests

need to get some tests implemented