detect-child-process TypeError: Cannot read property 'type' of undefined

[eslint-community]

detect-child-process TypeError: Cannot read property 'type' of undefined

[lionello]

Same here, got triggered on a .exec().

[lionello]

https://github.com/nodesecurity/eslint-plugin-security/blob/b72890b2b97245cf40a10a6ddb13918aad57790c/rules/detect-child-process.js#L22

This line causes the #31 for me because it ended up adding undefined to the names array. Changing the line to check for a valid name fixes this:

                 var args = node.arguments[0];
                 if (args && args.type === 'Literal' && args.value === 'child_process') {
-                    if (node.parent.type === 'VariableDeclarator') {
+                    if (node.parent.type === 'VariableDeclarator' && node.parent.id.name) {
                         names.push(node.parent.id.name);
                     } else if (node.parent.type === 'AssignmentExpression' && node.parent.operator === '=') {

[sergio-domingues]

any updates on this ?

[ota-meshi]

I checked past source code and this is the same issue as #69. That's fixed in #97.
So I will close this issue.