Giter Site home page Giter Site logo

3166's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

3166's Issues

`data` folder missing from nom package

const data = require('iso3166-2-db').getDataSet();

module.js:515
    throw err;
    ^

Error: Cannot find module '../data/iso3166-2.json'
    at Function.Module._resolveFilename (module.js:513:15)
    at Function.Module._load (module.js:463:25)
    at Module.require (module.js:556:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/willfarrell/Development/github/react-intl-material/node_modules/iso3166-2-db/lib/defaultDataset.js:3:12)
    at Module._compile (module.js:612:30)
    at Object.Module._extensions..js (module.js:623:10)
    at Module.load (module.js:531:32)
    at tryModuleLoad (module.js:494:12)
    at Function.Module._load (module.js:486:3)

Support typescript

Hi there,

are there any Typescript typings for this library? I am new to Typescript and just want to use this library in my React Typescript project.

How to contribute? I found some incorrect/outdated ISO_3166-2 code for Vietnam regions

Hi,

I just found some incorrect/outdated ISO_3166-2 code for Vietnam regions, I also checked it with OSM Overpass API and I can confirm some regions code is incorrect/outdated (Just some regions, not all Vietnam regions).
Data reference from https://en.wikipedia.org/wiki/ISO_3166-2:VN.
For example, on Wikipedia and OSM Overpass, Can Tho ISO_3166-2 code is CT, but on esosedi/3166 it code is 48.

You can check this code through below Overpass queries:

I can help to correct it, but It seems the repository has a lot of duplicates json data, so do I need to update all of them or do I only need to update the data/iso3166-2.json file?

Thank you so much!

Incorrect subdivision codes for France

https://en.wikipedia.org/wiki/ISO_3166-2:FR

» node -e "db=require('iso3166-2-db')" -i
> db.getDataSet()['FR'].regions.map(({name, iso}) => ({name, iso}))
[
  { name: "Provence-Alpes-Côte d'Azur", iso: 'U' },
  { name: 'Pays de la Loire', iso: 'R' },
  { name: 'Île-de-France', iso: 'J' },
  { name: 'Corsica', iso: 'H' },
  { name: 'Centre Region, France', iso: 'F' },
  { name: 'Brittany', iso: 'E' },
  { name: 'Bourgogne-Franche-Comté', iso: 'BFC' },
  { name: 'Nouvelle-Aquitaine', iso: 'NAQ' },
  { name: 'Normandie', iso: 'NOR' },
  { name: 'Grand Est', iso: 'GES' },
  { name: 'Occitanie', iso: 'OCC' },
  { name: 'Hauts-de-France', iso: 'HDF' },
  { name: 'Auvergne-Rhône-Alpes', iso: 'ARA' }
]

Should be

[
  { name: "Provence-Alpes-Côte d'Azur", iso: 'PAC' },
  { name: 'Pays de la Loire', iso: 'PDL' },
  { name: 'Île-de-France', iso: 'IDF' },
  { name: 'Corsica', iso: 'COR' },
  { name: 'Centre Region, France', iso: 'CVL' },
  { name: 'Brittany', iso: 'BRE' },
  { name: 'Bourgogne-Franche-Comté', iso: 'BFC' },
  { name: 'Nouvelle-Aquitaine', iso: 'NAQ' },
  { name: 'Normandie', iso: 'NOR' },
  { name: 'Grand Est', iso: 'GES' },
  { name: 'Occitanie', iso: 'OCC' },
  { name: 'Hauts-de-France', iso: 'HDF' },
  { name: 'Auvergne-Rhône-Alpes', iso: 'ARA' }
]

The same issue is also in iso-3166-2

Wrong name for Spain in Chinese

On file https://github.com/esosedi/3166/blob/master/i18n/dispute/UN/zh.json

Name for Spain (ES) is indicated as Chinese.
It should be 西班牙.

PL subdivisions renamed in 2018

Hi,

Currently the ISO 3166-2 codes for Poland are wrong (in iso3166-2-db/data/iso3166-2.json).
See https://www.iso.org/obp/ui/#iso:code:3166:PL for more information:

Change of subdivision code from PL-DS to PL-02, PL-KP to PL-04, PL-LB to PL-08, PL-LD to PL-10, PL-LU to PL-06, PL-MA to PL-12, PL-MZ to PL-14, PL-OP to PL-16, PL-PD to PL-20, PL-PK to PL-18, PL-PM to PL-22, PL-SK to PL-26, PL-SL to PL-24, PL-WN to PL-28, PL-WP to PL-30 and PL-ZP to PL-32; 

In case it may be useful for your patching, an array [from, to]:

 [["PL-DS", "PL-02"], ["PL-KP", "PL-04"], ["PL-LB", "PL-08"], ["PL-LD", "PL-10"], ["PL-LU", "PL-06"], ["PL-MA", "PL-12"], ["PL-MZ", "PL-14"], ["PL-OP", "PL-16"], ["PL-PD", "PL-20"], ["PL-PK", "PL-18"], ["PL-PM", "PL-22"], ["PL-SK", "PL-26"], ["PL-SL", "PL-24"], ["PL-WN", "PL-28"], ["PL-WP", "PL-30"], ["PL-ZP", "PL-32"]];

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.