[godot] Compilation errors when building for godot 4.1

[dreed-sd]

[godot] Compilation errors when building for godot 4.1

[badlogic]

You are working off of the 4.2-beta branch. That is currently not stable for spine-cpp based runtimes. Please use the 4.1 branch for now.

[dreed-sd]

I tried ensuring I am on 4.1 of spine-runtimes and then tried both 4.1 and 4.1-stable for the godot repo, but same result:

$ ./build/setup.sh 4.1 false false
# <successfully checks out godot into the build folder>

$ ./build/build-v4.sh
<snip beginning of godot compilation output>

[Initial build] Compiling /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PointAttachment.cpp ...
In file included from /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:30:
/Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/include/spine/PhysicsConstraint.h:155:29: error: unknown type name 'Physics'
        virtual void update(Physics physics);
                            ^
/Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:287:24: error: no member named 'getTime' in 'spine::Skeleton'
        _lastTime = _skeleton.getTime();
                    ~~~~~~~~~ ^
/Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:308:32: error: unknown type name 'Physics'
void PhysicsConstraint::update(Physics physics) {
                               ^
/Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:318:18: error: '_data' is a private member of 'spine::Bone'
        float l = bone->_data.getLength();
                        ^
/Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/include/spine/Bone.h:259:13: note: declared private here
                BoneData &_data;
                          ^
/Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:321:8: error: use of undeclared identifier 'Physics'
                case Physics::Physics_None:

<snip many more of these kinds of errors>

[badlogic]

Hm, looks like you are still using code from the 4.2-beta runtimes branch: PhysicsConstraint.h:155:29 Please delete spine_godot/spine-cpp, then call setup.sh and build-v4.sh again.

…

On Thu, Feb 29, 2024, 02:55 Dave Reed ***@***.***> wrote: I tried ensuring I am on 4.1 of spine-runtimes and then tried both 4.1 and 4.1-stable for the godot repo, but same result: $ ./build/setup.sh 4.1 false false # <successfully checks out godot into the build folder> $ ./build/build-v4.sh [Initial build] Compiling /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PointAttachment.cpp ... In file included from /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:30: /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/include/spine/PhysicsConstraint.h:155:29: error: unknown type name 'Physics' virtual void update(Physics physics); ^ /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:287:24: error: no member named 'getTime' in 'spine::Skeleton' _lastTime = _skeleton.getTime(); ~~~~~~~~~ ^ /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:308:32: error: unknown type name 'Physics' void PhysicsConstraint::update(Physics physics) { ^ /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:318:18: error: '_data' is a private member of 'spine::Bone' float l = bone->_data.getLength(); ^ /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/include/spine/Bone.h:259:13: note: declared private here BoneData &_data; ^ /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/PhysicsConstraint.cpp:321:8: error: use of undeclared identifier 'Physics' case Physics::Physics_None: ``` — Reply to this email directly, view it on GitHub <#2462 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5QBDJ3656MM32C3UGI7TYV7N27AVCNFSM6AAAAABDV4U6TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGI2TQMBXGQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[dreed-sd]

Yup that was it, thank you! I had originally tried on 4.2 as you said.

[dreed-sd]

I don't suppose you have any idea why when I build spine-runtimes as a custom_module from my godot repository, it fails with missing spine/Animation.h? It's like the spine/src/include folder is an include directory when your script builds godot, but not when I just run scons from my own godot (with custom_modules='../spine-runtimes/spine-godot/spine_godot'). The only difference is that with your setup and build, the godot repository being built is a directory inside spine-godot, and mine is a sibling of spine-runtimes. I admit ignorance on how scons works and figures out include directories.

Here's the scons line I'm using, starting in my godot repository directory (sibling directory of spine-runtimes):

+ scons compiledb=yes opengl3=yes custom_modules=../spine-runtimes/spine-godot/spine_godot --jobs 1
scons: Reading SConscript files ...
Automatically detected platform: macos
Building for macOS 11.0+.
MoltenVK found at: /Users/dreed/VulkanSDK/1.3.261.1/MoltenVK/MoltenVK.xcframework/macos-arm64_x86_64/
Building for platform "macos", architecture "arm64", target "editor".
Checking for C header file mntent.h... (cached) no
scons: done reading SConscript files.
scons: Building targets ...
[Initial build] Compiling /Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/Animation.cpp ...
/Users/dreed/git/spine-runtimes/spine-godot/spine_godot/spine-cpp/src/spine/Animation.cpp:30:10: fatal error: 'spine/Animation.h' file not found
#include <spine/Animation.h>
         ^~~~~~~~~~~~~~~~~~~