import_workers should throw an error if workerId is not valid

[esri]

import_workers should throw an error if workerId is not valid

[apulverizer]

Hi @jmdye,

Currently the import_workers script does detect invalid workers (usernames that are not in your org). It logs a warning message about this but does not stop the script.

See lines: https://github.com/Esri/workforce-scripts/blob/master/arcgis_api_for_python/import_workers.py#L130

Are you suggesting we first parse the csv and detect that all users are valid, then import all the workers. Currently, we go line by line which why we didn't want to raise an exception (which would lead to a partial import).

[jmdye]

Yes. My suggestion is to throw a fatal error and exit the script without importing any workers. Reason being that if your workers csv contains invalid workers, your assignments csv probably does as well. However, if your assignments csv contains an invalid worker for an assignment, then a fatal error is thrown there meaning you can get through a ton of assignments only to have to start over again if your assignments csv contained an invalid worker. That's painful when youre talking about hundreds or thousands of assignments.

[apulverizer]

See PR #18 let me know what you think when you have a chance.

[apulverizer]

Merged the PR. Closing.