ethanone1/xpresso

codecademy capstone-project-2-expresso

xpresso's Issues

Summary

Rubric Score

Criteria 1: Table Creation

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): It looks like you have included all of the proper code in your migration.js file for creating the proper tables with appropriate relationships to each other. Nice work!

Criteria 2: Implementation of API Specification and Functionality

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): It looks like all route paths and functionality are implemented to the spec. You handled all errors in each route well and also made the port configurable. Nice job!

Criteria 3: Test Case Results

• Score Level: 1/4 (Does Not Meet Expectations)
• Comment(s): After running the testing suite against your code, there were 6 test cases that were found to fail. I also had a difficult time getting your code to install properly, which seemed to have been a problem with your package-lock.json file. I have posted a screenshot of the test results below:

Criteria 4: JavaScript and Express Fundamentals and Formatting

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): You did well using JS features as well as Express features, such as middleware, route parameters, etc in your code. You also did well with the formatting of your code, which made it easy to read and understand. Nice job!

Overall Score: 13/16

Overall, you did a great job with this project. You implemented the API to spec and formatted it well, making it easy to read. You showed good knowledge of JS and Express by leveraging their features in your code. You should go back and resolve the errors that were causing those six test cases to fail. Other than that, nice work!