ethereumjs/ethereumjs-testing

This utility library has been moved to the EthereumJS VM monorepo.

ethereumjs-testing's Issues

rewrite

Currently large tests are included in bluk. It would be much better if they where streamed. pull-streams could be good to use here. The api would remain approximately the same except getTests would return a pull-stream

Remove asyncawait library (browser compatibility)

The asyncawait library was introduced here, dated from October 2017 and with the goal to support Node 6.

This is causing browser compatibility problems in the VM and potentially other libraries, see ethereumjs/ethereumjs-monorepo#465.

Since we have now dropped Node 6 ethereumjs/organization#50 this PR can be reverted.

This should be followed by a new release (also updating the tests).

An in-range update of tape is breaking the build 🚨

The devDependency tape was updated from 4.9.2 to 4.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tape is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 60 commits.

• 34b1832 v4.10.0
• 6209882 Merge all orphaned tags: 'v1.1.2', 'v2.0.2', 'v2.1.1', 'v2.2.2', 'v2.3.3', 'v2.4.3', 'v2.5.1', 'v2.6.1', 'v2.7.3', 'v2.8.1', 'v2.9.1', 'v2.10.3', 'v2.11.1', 'v2.13.4', 'v2.14.0', 'v2.14.1', 'v3.6.1'
• 82e7b26 [Deps] update glob
• 9e3d25e [Dev Deps] update eslint, js-yaml
• fd807f5 v1.1.2
• eddbff5 v2.14.1
• 6ce09d9 Minor test tweaks due to whitespace differences in v2 vs v4.
• 71af8ba gitignore node_modules
• 4c0d9e6 Merge pull request #268 from ljharb/throws_non_function_should_fail
• d0a675f v3.6.1
• d22b5fc Minor test tweaks due to output differences in v1 vs v4.
• 8b3c1b7 Add missing concat-stream devDep
• 3495543 gitignore node_modules
• db81846 Merge pull request #268 from ljharb/throws_non_function_should_fail
• 7ed6651 Minor test tweaks due to whitespace differences in v3 vs v4.

There are 60 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Fix documentation for `getTests`

The current documentation for getTests is actually documentation for a method that existed on an old version but no longer exists: https://github.com/ethereumjs/ethereumjs-testing/blob/master/index.js#L9-L12

This documentation should be updated. This is a simple and straightforward task, I'm just making an issue so that it doesn't get forgotten.

Berlin HF Tests Submodule Update Planning

To get this ready to the coming Berlin tests I would do the following:

• Do a version v1.3.1 release here with the current develop branch from ethereum/tests to have some work basis for first integration tests on the VM side
• Collect experiences / focus discussion on potential test format changes here, will also reference this issue in the v1.3.1 release notes
• I would along try to work towards a v8.0.0-beta.1 Berlin HF tagged release on the ethereum/tests side, see v7.0.0-beta.1 release for comparison
• Once we have a fully Berlin compatible release over there we can do a v1.4.0 version here, release and further integrate on the VM side

Move code logic from here to the VM

The code logic here is unnecessarily detached from the rest of the VM tester code base and round-trips on changing something here, testing the efforts and then have this working with the VM test runner are extremely and unnecessarily long. Just hanging on this again while examining some failures on older blockchain tests.

I propose that we just move the code logic from here to the VM test runner code base and keep this repository only for updating the submodule respectively keeping the large ethereum/tests submodule code base out of the monorepo.

Then we can easily improve on the code base respectively adopt to our needs, also x-checks while working with the tests if tests are loaded correctly (especially important due to relatively frequent and partly implicit changes on the ethereum/tests folder structure. With keeping the procedure on doing tagged releases here and link to them from the VM package this should be also unproblematic from a stability PoV.

//cc @evertonfraga

This module can't be run on a browser

While working on ethereumjs/ethereumjs-tx#145 I got convinced that this module can't be run in a browser anymore.

Previously, this module used bulk-require and bulkify to read the tests fixtures. Both were created by substack (browserify author) to work nicely with browserify.

Now we are using node-dir, which doesn't seem to work with browserify.