ethhead/ens.trade

ENS name trading

ens.trade's Issues

Chrome on Mac 10.12.4 running Parity and Metamask, names fail to load

.eth names fail to load at all in Chrome sending a screen cap and ctrl+V of the log. Hope it helps!

MetaMask - injected web3
inpage.js:19192 Parity - Injecting Web3
main.60dfd9a….js:14858 Connecting to Ethereum network...
main.60dfd9a….js:100478 action INIT_ETHEREUM_PENDING @ 20:10:04.785
main.60dfd9a….js:100490 prev state Object {ethereum: Object, records: Object, record: Object, offers: Object, popup: Object}
main.60dfd9a….js:100494 action Object {type: "INIT_ETHEREUM_PENDING"}
main.60dfd9a….js:100502 next state Object {ethereum: Object, records: Object, record: Object, offers: Object, popup: Object}
main.60dfd9a….js:14858 Checking connection...
DevTools failed to parse SourceMap: https://ens.trade/dist/material.min.js.map
main.60dfd9a….js:100478 action UPDATE_RECORDS_PENDING @ 20:10:04.815
main.60dfd9a….js:100490 prev state Object {ethereum: Object, records: Object, record: Object, offers: Object, popup: Object}
main.60dfd9a….js:100494 action Object {type: "UPDATE_RECORDS_PENDING"}
main.60dfd9a….js:100502 next state Object {ethereum: Object, records: Object, record: Object, offers: Object, popup: Object}
main.60dfd9a….js:18802 fromFile null
main.60dfd9a….js:14895 checkNetwork 0xd4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3
main.60dfd9a….js:14858 Initializing ENS registrar...
main.60dfd9a….js:15026 Network: main
main.60dfd9a….js:15029 ready
main.60dfd9a….js:14858 Ready!
main.60dfd9a….js:100478 action INIT_ETHEREUM_FULFILLED @ 20:10:04.891
main.60dfd9a….js:100490 prev state Object {ethereum: Object, records: Object, record: Object, offers: Object, popup: Object}
main.60dfd9a….js:100494 action Object {type: "INIT_ETHEREUM_FULFILLED", payload: Object}
main.60dfd9a….js:100502 next state Object {ethereum: Object, records: Object, record: Object, offers: Object, popup: Object}
main.60dfd9a….js:18813 Uncaught TypeError: Cannot read property '0' of null
at main.60dfd9a….js:18813
at Object.callback (inpage.js:17082)
at inpage.js:4222
at inpage.js:18556
at inpage.js:12048
(anonymous) @ main.60dfd9a….js:18813
(anonymous) @ inpage.js:17082
(anonymous) @ inpage.js:4222
(anonymous) @ inpage.js:18556
(anonymous) @ inpage.js:12048

Save registrarAddress as type Registrar

In the first line of newListing function, registrarAddress is cast to type Registrar. Saving as type Registrar in the constructor would eliminate (minor) gas cost, as this would no longer have to be cast on every single function call.

I bid on test.eth but my bid also shows up on vitalik.eth

When I bid on test.eth the bid was recognized and shows up under the offers-tab.
But my bid shows up under vitalik.eth under the offers-tab, too.

Possible Bug: reclaim and transferRecord Functions call setOwner on Deed

Both the reclaim and transferRecord functions call the setOwner function on the deed contract. However, the setOwner function in a deed contract can only be called by the registrar that owns it.

If setOwner is called by anyone other than the registrar, it will throw. Thus, this would cause any function that calls it directly to fail. Currently, this includes reclaim, transferRecord, (and newOffer and acceptOffer (as they call transferRecord).

I believe this means that these functions (at least with the current ENS implementation deployed on the mainnet) will always fail.

Possible bug when ENS moved to permanent registrar

Once the current ENS registrar is upgraded the ENSTrade contract will need to determine which ENS registrar the deed is registered at. A deed owner can set the registrar: https://github.com/ethereum/ens/blob/master/contracts/HashRegistrarSimplified.sol#L584

It's likely that there will be listings in the ENSTrade contract that are using the old registrar and new listings that will be using the new registrar.

Perhaps you need to store the registrar address against each deed when it is listed?

Names fail to load - Macbook Pro OS X 10.11.6 / Chrome Version 59.0.3071.115 (Official Build) (64-bit)

Hi... Thanks for creating ens.trade! I can get the page to load under Windows 10, but not on a MacBook Pro as noted in the subject header.

The page loads, but the spinning "Name Fetching" indicator never goes away. Here's the error as caught by the Chrome Dev Tools:

Uncaught (in promise) TypeError: Cannot read property 'length' of undefined
    at reducer (main.ac78ad3….js:40687)
    at combination (main.ac78ad3….js:101347)
    at dispatch (main.ac78ad3….js:36470)
    at main.ac78ad3….js:100872
    at main.ac78ad3….js:28460
    at main.ac78ad3….js:100961
    at dispatch (main.ac78ad3….js:101151)
    at handleFulfill (main.ac78ad3….js:101048)
    at <anonymous>
DevTools failed to parse SourceMap: https://ens.trade/dist/material.min.js.map

If this qualifies for a bug bounty, contact me at [email protected].

Good luck with the project, and thanks!

Spinning wheel of Death on Mac OS 10.12.4 running Safari

Website seems to be frozen on this page when using Safari, can't seem to even open command console.

Capitalizing Events

This is just a style note, but consider capitalizing first letter of all events. This makes it harder to confuse them with function calls. Generally considered good style.

Fetching ENS names frozen on Win10/Chrome/Metamask