ethichub/platform-contracts

The contracts for Ethic Hub ethical crowdlending platform

platform-contracts's Issues

Initialize reputation

to 5 when registering community / localNode

Automate final exchange rate

Instead of manual input, get the final exchange rate from an oracle (coinmarketcap)

Add old contracts test

Lets test that after upgrading a contract, the old one can't interact with the platform.

Separate fund transfer from cap reached

sendFundsToBorrower() should be out of contributeWithAddress() and made external.

Add a check for state === AcceptingContributions in sendFundsToBorrower()

This way the transfer to the exchange will happen when local node and representative are ready and in a room together.

Term refactor

Change borrower by representative wherever present.
Also change defaultDays for delayDays

Add promotional banner and rewrite readme

When ready, add the banner to readme and a better description

Allow for multiple early payments

Right now we have 1 payment back with several transactions to repay.

Our borrowers ask to be able to pay fractions of the total amount before the date, with the interest of the time of payment (like in traditional loans).

This implies that there would be several "reclaimContributionWithInterest".

Fix default project date calculations

We are calculating the lending period from fundingEndTime
But what if the money is sent in day fundingStartTime + 2? (when the cap is reached)

reclaimLocalNodeFee & reclaimEthicHubTeamFee could return more than they should

reclaimEthicHubTeamFee & reclaimEthicHubTeamFee deppend on borrowerReturnAmount(), which is dependant on "now".

The fee should be fixed when project is repayed

Add integration test

1.- Launch lending contract
2.- Update reputation contract
3.- Try to pay back lending contract using old reputation

Add view method to check if address invested in lending contract

Easier for the frontEnd to have this call

Modifier onlyLendingContract

BurnReputation or IncrementReputation. TODO the only Lending Contract modifier and unit tests. We have a branch fix_onlylendingcontract with this code without finish.

Split "borrower" into representative and community

representative should be the exchange account to receive the funds, community should be a wallet that the community controls.

In EthicHubLending, EthicHubReputation and EthicHubUser
We should have "community" and "representative" in the modifiers, registering and such.
Community should be the subject of reputation calculations (like it is know)

Allow partial returns when returning money

Allow for partial returns, not considering the loan paid, allowing to get the money

Review integration test: calculate reputation

On test/EthicHubIntegration.js
En el contrato EthicHubLending. En el flujo de inversión (The investment flow), calculo la reputación al inicio y al final, para la comunidad está bien, y para el nodo local no cambia.

Automate initial exchange rate

Instead of manual input, use oracles from coinmarketcap to get the peso/ether exchange rate.

Important: Keep the feature of returning surplus ether operational

Expand readme

Explain the system, how to test it and how to contribute.

Documentation

Project creation security

Restrict project creation to only local nodes.

Refactor for upgradeable architecture with eternal storage

Since we are going to store investors, localNodes, and other contract data in one contract, we may better refactor to a hub and spoke architecture

This may allow us to upgrade Lending and Reputation in the future.

Reputation algorithm

After Lending payment/default, reputation for the local node and community must be increased or burned.

In this version, reputation for communities is communal. In future version reputations will be set by individual.

Reputation of the local nodes will vary proportionally with the reputation of the communities.

To have a measure of the impact of a project, we are classifying them in 5 tiers (t1 to t5).
Each tier corresponds to the monetary amount lent per person in the project. Each country will have a different monetary amount that makes sense for each tier, and a different fiat currency to grade them, so we will not store that in the blockchain for now.

For our first run in México we have:

• Tier1: 1000€
• Tier2: 2000€
• Tier3: 5000€
• Tier4: 10000€
• Tier5: 20000€

Decrement

Community:

Decrement of 1% daily after the set lendingDays, with 100% rep being burned if the money is not returned before maxDefaultDays.

Local node:

Reputation decrement will be a multiplier of the community result.

Increment

Community

R = Reputation
Rp = Previous reputation
Nt = Number of previously succesful projects in that tier
R = Rp + 1/Nt

Local node

Tm = Tier multiplier (1 for t1, 2 for t2..)
C = Number of people on the community
R = Rp + 0.05*(Tm*C)

Update Ownable

https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/ownership/Ownable.sol

Fix interest calculations

Change interest to variable and annual, also add 4% local node and 3% EthicHub when returning borrowed amount.

Send partial transfer to exchange.

After the lending period, the initial cap in eth might be too many pesos when going to exchange. We don't want to charge the farmers with more interests than needed.

1. Allow borrower transfers part of the eth back to the contract when ExchangingToFiat
2. That amount should be proportionally divided between contributors in a separate ledger. Either via a vault contract (like OpenZeppelin's RefundableCrowdsale or a different mapping.
3. When setting initial eth2fiat rate, do the calculations with cap - returned
4. Allow investors to retrieve the returned funds
5. Emit an event when returning partial transfer.

Add "Exchanging" state to Lending

The exchanged rate must be set after the actual exchange takes place.

We need to add:

• An state Exchanging after a succesful funding.
• The inital exchange rate must be set after the actual exchange has taken place.

create EthicHubUser contract

Contract with the API to register investors and local nodes.

Add checks in lending contract for registered investors, valid local nodes creating the contract

Integration tests

Add integration tests for all lending cases, with actual storage, cmc and user contracts , checking that the correct values are set in storage and the balances are right.

Do in a separate testing file that EthicHubLending.js

reclaimContributions allow multible withdrawals.

Set investorsKey[address].amount to 0 before the transfer in the reclaimXX methods

Add getters needed in the frontend

Please add:
getMaxDelayDays()