etwnn/scanwatch

Local tracker for address on Ethereum, BSC and Polygon chains

scanwatch's Issues

Testnet api endpoint lead to json error

After

Client.py:
"""BASE_BSC_URL = "https://api.bscscan.com/api" # mainnet"""
BASE_BSC_URL = "https://api-testnet.bscscan.com/api" # testnet

I'm got an Error:
Traceback (most recent call last):
File "scanw.py", line 11, in
manager.update_all_transactions()
.........
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Mainnet endpoint works fine. Possible solution?

Is there a work around for "First operation on an asset is a removal"?

https://github.com/EtWnn/ScanWatch/blob/43a7e15282e6687c610acee3ae9b5fd85ed92d8e/ScanWatch/ScanManager.py#LL104C27-L104C37

Can you work around this without raising an exception?

discussion tab + feature

Hi. Repository discussion tab seems missing you can add it in settings.

Feature request:
Get address current erc20/erc721 (bep20/bep721) holdings.

My idea of implementation:

1. get inputs and outputs separately
2. compare them
3. remove spent transactions
4. result - all unspent inputs

My implementation of bep721 holdings:

from ScanWatch import ScanManager
from ScanWatch.utils.enums import NETWORK, TRANSACTION

api_token = ""
address = "0x8477f08df0d70f3b19e6241dcb1757363741ed7e"

manager = ScanManager(address, NETWORK.BSC, api_token, "test")

# manager.get_transactions(TRANSACTION.NORMAL)  # normal transactions

manager.update_all_transactions()

result = manager.get_transactions(TRANSACTION.ERC721)

trans_in = []
trans_out = []

print('Transactions: ')
for res in result:
    if res['from'] == address:
        trans_out.append(res)
        side = 'out'
    else:
        trans_in.append(res)
        side = 'in'

    print(f"from: {res['from']} / {side} / to: {res['to']} / contract: {res['contractAddress']} / token: {res['tokenID']} - {res['tokenName']} - {res['tokenSymbol']}")

final = trans_in

for x in trans_in:
    for out in trans_out:
        if (out['contractAddress'] == x['contractAddress'] and
                out['tokenID'] == x['tokenID'] and
                out['tokenName'] == x['tokenName'] and
                out['tokenSymbol'] == x['tokenSymbol']):
            final.remove(x)

print('Holdings: ')
for res in final:
    print(f"from: {res['from']} / to: {res['to']} / contract: {res['contractAddress']} / token: {res['tokenID']} - {res['tokenName']} - {res['tokenSymbol']}")

I'm not clearly sure if this is the right way of implementation (don't know how this will work if transactions failed etc.)

If you can natively implement this functional into library that's would be nice. Maybe you can do this with better/safer/optimized way