Comments (4)
Suggested patch attached, which also fixes issues with unsupported baud rates not compiling on linux.
infinite_timeout_patch.zip
EDIT: Better patch with baudrate constants set to correct values:
infinite_timeout_patch_v2.zip
I'd be happy to push these changes, but I'm not quite sure how to contribute with github.
from serial.nim.
Hey,
Thanks very much for the detailed report and suggested patch. I'll have a look through them and merge them into the tree manually and credit you in the commit message. I should get a new release completed today after I've done a couple of jobs this morning, and will post a message to this issue once I've done so.
Thanks!
from serial.nim.
Looks like a nice easy patch actually, I can get it merged in right now 😄 I did notice a minor spelling error in a comment which I will fix too.
from serial.nim.
Patch merged and version 1.1.1 released, thanks.
from serial.nim.
Related Issues (20)
- Compile errors on macOS Mojave HOT 4
- Asynchronous IO blocks dispatcher thread. HOT 3
- Serial stream issues with current Nim compiler HOT 3
- All programs fail to compile with serial lib in nim 1.0 HOT 12
- Serial library wont compile on Windows HOT 9
- Linux implementation won't list the Bluetooth related serial ports HOT 2
- Windows 7 implementation won't list the serial USB related serial ports. HOT 12
- Read timeout does not function correctly on windows implementation. HOT 2
- Setting write timeout to zero results in TIMEOUT_INFINITE on windows. HOT 2
- ffi_windows.nim(29, 27) Error: cannot convert 4294967295 to DWORD HOT 3
- Implement some CI
- Error: type mismatch: got <clong> but expected 'Suseconds = int32' HOT 5
- Can't detect all serial ports on Windows 10 HOT 5
- Build fails on MacOS 10.13.6 with clang error: use of undeclared identifier 'IUCLC' HOT 1
- port.write fails with non-zero writeTimeout on MacOS 10.13.6 HOT 6
- undeclared identifier: 'PCustomOverlapped' HOT 7
- Force synchronization of the serial port? HOT 18
- Fails to compile on Windows with `--gc:orc` HOT 1
- Getting an error with 'useWinUnicode' when trying to compile my serial import HOT 1
- Checking data before reading (non-blocking) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serial.nim.