evan10s/jsgroup

jsGroup makes groups.

jsgroup's Issues

For people whose choices could not be fulfilled at first, allow expanded criteria to make a group with them

Currently, every group has someone in it who received his or her first choice. This is difficult to explain with words, so here is an example:

• Person A was unable to have any choices fulfilled.
• Person A's wants: Person C, Person B, Person D.
• Person B's wants: Person E, Person A, Person F
• Person E does not have Person B in his wants.
• The group was not created because Persons A and B are both each other's second choice. (Currently, Person A would need to have B as a first choice, or Person B with A has a first choice in order for a group to be created.)
• Since A's choice's were not fulfilled, when Person B's second choice is reached, the group will be created under this system because Person B is one of Person A's choices. This creates a group with two second-choice people in it, but it is okay since under the old method, A would have been put in a group using one of the two processes at the end (take into account cannotHaves, then just put in a group together).

Grouping algorithm does not stop making groups even after a match is found

When the grouping algorithm finds a match for someone, it does not stop look for matches for the person. This could result in a person being in two different groups.

Elements that are supposed to change on hover do not change properly

In the v0.1.3-beta branch of jsGroup, elements that are supposed to change on hover are not changing on hover as they are supposed to. Since this is a minor issue, it will be deferred to jsGroup v0.2-beta, which will also include the Bootstrap v3.0.3, the latest version of Bootstrap as of 29-Jan-2014.

Only display the Results fieldset when there are results to display

The Results fieldset should only be displayed when there are results to display (i.e., after the grouping has been completed.

It is better for the grouping algorithm to not create it at the end as that would require checking to see if their already is a Results fieldset to avoid creating another one.

Take cannotHaves into account when processing people left after making groups

After making groups, when the algorithm puts the remaining people into groups, their cannotHaves should be taken into account, unless no one else is left.

In certain instances, groups do not display because of an issue while processing people whose choices cannot be fulfilled

Sometimes no groups will show because of an error that occurs during secondary data processing (people whose choices could not be fulfilled).

A screenshot will be added once this issue can be reproduced (seems to only appear sometimes, depending on the specifics of the data submitted).

A fix for this issue will be released when it can be reproduced. If you encounter a problem in which it seems no groups are created, please check the console for errors, and then create an issue (include the contents of the console by pressing Ctrl-A/Cmd-A and then copying the contents).

Treat names as one field to allow for names of any length

The "Name" field should be one field to allow for names of any length. There could also be an input box where a user could enter the number of "Name" fields there are in his/her data, to allow for more freedom in users' data.

AnyoneOkay not working as it should

When a person wants someone whose first choice is "Anyone is okay," jsGroup doesn't make a match between the two people.

Only use Bootstrap components that are required for jsGroup to function and look right

jsGroup is currently using Bootstrap files that contain all of Bootstrap's components even though only some components are actually used by jsGroup.

No group created when there are only two people

When jsGroup is run with only two people, there seems to be an issue causing the group to not be displayed in the results.

People getting skipped even when they shouldn't

In certain instances, people are getting skipped over. It seems like this issue is caused by the way people are removed from the people array when k is greater than i (will add more info later). I seem to have fixed this by decrementing i in this situation.

CSS does not load in v0.1.2-beta

The CSS does not load in the v0.1.2-beta version of jsGroup. This occurs when the jsGroup index.html file is opened in a browser.

Improve the "Limited functionality" message

At the top of jsGroup, there is a message with the title "Limited functionality." The message states that "This version of jsGroup stems directly from the beta," but this version of jsGroup is the beta version of jsGroup. Therefore, I think the message could be improved by saying that this is a beta version of jsGroup.

Even when no data is provided, jsGroup still says, "One group created."

When the data field is blank, jsGroup still says, "One group created," even though it should display an error message saying that no data was found.

The data jsGroup logs to the console when it makes groups shows that jsGroup interprets the empty data input box as one person whose name is " undefined" and who is okay with anyone for all three of his choices:

The grouping algorithm could put someone with a lower choice even if a higher choice is available

When looking for a match for a person's choices, the grouping algorithm could put a person in a group with one of his/her lower choices even if a higher choice is available.