evanwong/hipchat-java

Java client for the HipChat v2 API

hipchat-java's Issues

Unrecognized fields should be ignored.

In Request.java, this line should be added in order to prevent the client from failing if Atlassian adds new fields:

this.objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);

Currently I am getting this exception:

com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "version" (class io.evanwong.oss.hipchat.v2.rooms.RoomItem), not marked as ignorable (3 known properties: "links", "id", "name"])

Infinite recursion in HipChatClient.prepareGetEmoticonRequestBuilder(String)

Just a typo, but the method is calling itself instead of its homonym:

hipchat-java/src/main/java/io/evanwong/oss/hipchat/v2/HipChatClient.java

Lines 94 to 96 in b263fec

	public GetEmoticonRequestBuilder prepareGetEmoticonRequestBuilder(String idOrShortcut) {
	return prepareGetEmoticonRequestBuilder(idOrShortcut);
	}

Add methods for the oauth sessions APIs

1. https://www.hipchat.com/docs/apiv2/method/generate_token
2. https://www.hipchat.com/docs/apiv2/method/get_session
3. https://www.hipchat.com/docs/apiv2/method/delete_session

Add method for the capabilities API

https://www.hipchat.com/docs/apiv2/method/get_capabilities

Compilation errors in the provided sample code

Tried your sample code in the readme file.

String defaultAccessToken = "22222-mytoken";
HipChatClient client = new HipChatClient(defaultAccessToken);
SendRoomNotificationRequestBuilder builder = client.prepareSendRoomNotificationRequestBuilder("room-test-1","this is my first message");
java.util.concurrent.Future future;
future = builder.setColor(MessageColor.YELLOW).setNotify(true).build().execute();

and got the following compilation errors in the last line of code;
- The type io.evanwong.oss.hipchat.v2.commons.Request cannot be resolved. It is indirectly referenced from
required .class files
- The method execute() is undefined for the type SendRoomNotificationRequest

quick reply is much appreciated.
thanks in advance.

Setting the URL of the HipChat server

Is there a method for setting the URL of the HipChat server? (I want to send a message to a room)

Add method for add room member

https://www.hipchat.com/docs/apiv2/method/add_member

Add methods for the emotions APIs

1. https://www.hipchat.com/docs/apiv2/method/get_emoticon
2. https://www.hipchat.com/docs/apiv2/method/get_all_emoticons

Java 7 support?!

Many of us still uses Java 7, especially in old projects. Would be possible to make a Java 7 compatible jar?

Add an option to control verbosity

I wish I can avoid DEBUG and INFO level log messages.

Add method for remove room member

https://www.hipchat.com/docs/apiv2/method/remove_member

The example given in the README does not work

hi!

I am using the example in the readme, but it does not work:

        try {
            String defaultAccessToken = "xxxxx";
            HipChatClient client = new HipChatClient(defaultAccessToken);

            SendRoomNotificationRequestBuilder builder = client.prepareSendRoomNotificationRequestBuilder("test", "hello world!");


            Future<NoContent> future = builder.setColor(MessageColor.YELLOW).setNotify(true).build().execute();
//optional... if you want/need to inspect the result:
            NoContent noContent = future.get();
        } catch(Exception e) {
            LOG.error("exception", e);
        }

this is returning:

2015-03-13 14:11:29,821 ERROR [-1:?] [io.evanwong.oss.hipchat.v2.commons.PostRequest] Invalid response status: 401, content: {
  "error": {
    "code": 401,
    "message": "Invalid OAuth session",
    "type": "Unauthorized"
  }
}

And I do not see any OAUTH related methods on the HipChat client.

how do I get this to work? What am I doing wrong?

Support on-premise HipChat installations.

There seems to be no way to provide HipChat server URL for on premise HipChat installations.

Java7 release of 0.4.2?

Hi,
first of all thank you for maintaining a backwards compatible version of the API.
We could use the User API which the 0.4.0 of the Java 7 release does not provide yet.
Could you please release the new version to Maven central?

Thanks and cheers,
Michael

Add more methods for Rooms APIs

Add api/usage documentation

Memory leaks (threads)

I recently integrated this library (v0.3.0) in an existing project, where I was using v1 hipchat API. Here is more or less how I use it : I have a static HipChat object in method in MyClass

private static final HipChatClient hcc = new HipChatClient("mytoken") ;
private static void sendMessageImpl(String message, MessageColor color,boolean critical) {
    //some stuff then prepare the query
    SendRoomNotificationRequestBuilder builder = hcc.prepareSendRoomNotificationRequestBuilder("myroomId", "message to send");
    Future<NoContent> future = builder.setColor(colorToUse).setNotify(notify).build().execute();
            NoContent noContent = future.get();

I have a timer that calls MyCalls.sendMessageImpl(...) every two minutes, multiple times.

I recently started to receive reports of memory leaks happening. A further investigation with JProfiler revealed that I had a steadily growing number of new threads (blocked) .

After some hours the number of threads was in the order of thousands, and in 48 hours, boom.

Interestingly enough, when turning hipchat off, the number of threads is steady , as it should be : 6.

Am I doing something wrong? is this a known problem? am I using an old version? It consumed one day of work finding this.