eve-mas/eve-parity

Equilibrium Verification Environment (EVE) is a formal verification tool for the automated analysis of temporal equilibrium properties of concurrent and multi-agent systems.

eve-parity's Issues

Compilation fixes and Dockerfile

Hi,
I'm using EVE for an evaluation and came across some small issues when using it on a "modern" system. I fixed them locally + created a Dockerfile which is sufficient to build & run EVE (IMO more convenient than a whole VM).

I can provide the changes via MR or you can simply include them if you like :)

In src/

--- a/generatepun.py
+++ b/generatepun.py
@@ -58,4 +58,4 @@
     try:
-        PUN[pl_name]=map(int,ttpg_results[0].strip()[1:-1].replace(' ','').split(','))
+        PUN[pl_name]=list(map(int,ttpg_results[0].strip()[1:-1].replace(' ','').split(',')))
     except ValueError:
         PUN[pl_name]=[]

(map nowadays is lazy, this forces reading & parsing the result)

In ltl2ba:

--- a/buchi.c
+++ b/buchi.c
@@ -44,8 +44,9 @@
 
 extern FILE *tl_out;	
 BState *bstack, *bstates, *bremoved;
-BScc *scc_stack;
-int accept, bstate_count = 0, btrans_count = 0, rank;
+static BScc *scc_stack;
+int accept, bstate_count = 0, btrans_count = 0;
+static int rank;
 
 /********************************************************************\
 |*        Simplification of the generalized Buchi automaton         *|
--- a/generalized.c
+++ b/generalized.c
@@ -46,9 +46,10 @@
 extern char **sym_table;
 
 GState *gstack, *gremoved, *gstates, **init;
-GScc *scc_stack;
+static GScc *scc_stack;
 int init_size = 0, gstate_id = 1, gstate_count = 0, gtrans_count = 0;
-int *fin, *final, rank, scc_id, scc_size, *bad_scc;
+int *fin, *final, scc_id, scc_size, *bad_scc;
+static int rank;
 
 void print_generalized();

These are changes taken from https://github.com/utwente-fmt/ltl2ba/commit/f2426dfdeb327924f2035fdb6c88542c19c5ee13.patch
Newer cpp compilers seem to be more picky.

Dockerfile:

FROM debian:bullseye

RUN apt-get update && apt-get install -y python3 unzip opam python3-cairo python3-igraph python-is-python3 \
  && rm -rf /var/lib/apt/lists/*

RUN useradd user -g users --create-home
USER user
RUN opam init --yes --disable-sandboxing

COPY eve-parity-master.zip /home/user/
RUN cd /home/user \
  && unzip -q eve-parity-master.zip && rm eve-parity-master.zip \
  && mv /home/user/eve-parity-master /home/user/eve && cd /home/user/eve/eve-py/ \
  && find /home/user/eve/eve-py/ -name "*.sh" -print0 | xargs -0 chmod +x \
  && sed -i 's!opam install!opam install --yes!' config.sh \
  && ./config.sh

With the above change applied and sources provided as eve-parity-master.zip this builds a docker image to run eve.