evergreencoindev/evergreencoin

EverGreenCoin Official Development Tree

evergreencoin's Issues

issue

src/qt/charitydialog.cpp:13:25: fatal error: QJsonDocument: No such file or directory
#include
^
compilation terminated.
make: *** [build/charitydialog.o] Error 1
​
we can't get the new to compile.

Can't copy charity's address

There is no way to make a direct contribution to a charity address (aka authorized effort address) or copy the populated charity address to do so.

Text cropping and scaling issue

The link to the explorer is cropped. Using 4K monitor here.

Screenshot:

Coloring not matching logo perfectly

The green coloring used in the Qt was made prior to launch and the completed design of the logo that happened shortly after launch. While the logo was changed and new wallets were built at the time of logo design completion, the greens used were not changed to more precisely match.

Translation file imperfections

Some of the translation files are incomplete and/or inaccurate. Review and modification of the Qt translation files will be performed and, whenever possible, by native speakers. For example, 450201d
This will also include adding translations to previously untranslated text.

Legal wording changes

To avoid and remove any legal wording conflicts that may arise in the future.

Right click copy of TX ID includes recipient ID / number ("-000")

If a user right-clicks and selects 'Copy transaction ID' on the 'Transactions' tab of the Qt wallet, it will copy the TX ID including the recipient ID / number ("-000", "-001", ect.). When pasted these trailing numbers and the hyphen need to be removed before any block explorer recognizes the transaction. This can mislead users to not being able to find transactions.

Memo field

Enter and display tx memos.

Building with boost v1.66 errors

4K screen resolution fixes

Tweaking the UI code to better display on high-resolution screens such as 4K monitors.

Staking for charity - support multiple charities

Multiple charities, with weighting?

Windows 10 taking mouse focus to the send button of the send widget

See: c3020a0

Unlocking during sending tx puts the unlock button in an incorrect state

If a wallet is locked and a send is attempted, you must enter the password to unlock. This unlocks only for that transaction and then is re-locked automatically. The unlock triggers the "lock / unlock" button on the overview to switch to lock. The transaction-following automatic re-lock does not signal the "lock / unlock" button on the overview to switch to "unlock". This leaves the "lock / unlock" button in a misleading state of "lock your EverGreenCoin" while the wallet is in fact again locked already. Clicking it will prompt for a password as expected, since it is truly locked. But the text on the button needs to reflect the true status after a locked wallet send or not be effected by a locked wallet send / brief unlock / sign tx / quick auto re-lock.

Better represent charities

To better represent charities and authorized efforts supported by staking for charity and crowdfunding efforts, adding a logo of the supported organization or image associated with the authorized effort will be added to the staking for charity dialog. These are loaded dynamically from the charitiy.json file maintained by the EverGreenCoin Foundation and loaded upon authorized effort selection from the staking for charity drop down menu. In addition, the EGC logo on the overview dialog will also change upon selection of the authorized effort or enabling of the authorized effort. This work is in the https://github.com/EverGreenCoinDev/EverGreenCoin/tree/feature-add-charity-image branch.

Staking for Charity icon can be misleading in situations

When Staking for Charity has been enabled and saved during a prior execution, staking for charity's flag variable is true on future executions. This is fine, is normal, and how it will know to continue staking for charity with the predefined arguments. However; on future executions when the wallet is unlocked for staking only and NOT spending, the staking for charity icon will falsely light up with the staking icon. The staking for charity icon should NOT light up UNLESS it is unlocked for staking AND spending. It is currently tied to close to the staking indicator icon, assuming that if it lights up, it itself should too. This is not true because it also will need unlocked for sending.

fails to build with PIE flag

make -f makefile.unix -e PIE=1

fails on debian 8 x86_64. unable to build Position Independent Executable.

g++ -O2 -pthread -Wall -Wextra -Wno-ignored-qualifiers -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -I/home/sid/EverGreenCoin/src -I/home/sid/EverGreenCoin/src/obj -I/home/sid/EverGreenCoin/src/json -DUSE_UPNP=0 -DUSE_IPV6=1 -I/home/sid/EverGreenCoin/src/leveldb/include -I/home/sid/EverGreenCoin/src/leveldb/helpers -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -fPIE -D_FORTIFY_SOURCE=2 -o evergreencoind obj/shabal.o obj/whirlpool.o obj/fugue.o obj/hamsi.o obj/groestl.o obj/blake.o obj/bmw.o obj/skein.o obj/keccak.o obj/shavite.o obj/jh.o obj/luffa.o obj/cubehash.o obj/echo.o obj/simd.o obj/alert.o obj/version.o obj/checkpoints.o obj/netbase.o obj/addrman.o obj/crypter.o obj/key.o obj/db.o obj/init.o obj/irc.o obj/keystore.o obj/miner.o obj/main.o obj/net.o obj/protocol.o obj/bitcoinrpc.o obj/rpcdump.o obj/rpcnet.o obj/rpcmining.o obj/rpcwallet.o obj/rpcblockchain.o obj/rpcrawtransaction.o obj/script.o obj/sync.o obj/util.o obj/wallet.o obj/walletdb.o obj/noui.o obj/kernel.o obj/pbkdf2.o obj/scrypt.o obj/scrypt-arm.o obj/scrypt-x86.o obj/scrypt-x86_64.o obj/txdb-leveldb.o -Wl,-z,relro -Wl,-z,now -pie -Wl,-Bdynamic -l boost_system -l boost_filesystem -l boost_program_options -l boost_thread -l db_cxx -l ssl -l crypto -l z -Wl,-Bdynamic -l dl -l boost_chrono -l boost_date_time -l pthread -l miniupnpc /home/sid/EverGreenCoin/src/leveldb/libleveldb.a /home/sid/EverGreenCoin/src/leveldb/libmemenv.a
/usr/bin/ld: obj/shabal.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
obj/shabal.o: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
makefile.unix:210: recipe for target 'evergreencoind' failed
make: *** [evergreencoind] Error 1

Make on Ubuntu missing QAction

Hi,

When making on Ubuntu 18.04 after following the environment config instructions in the install guide, I first get an error on QJsonDocument not being present (fixed by installing libqjson-dev).

Then I get the following:

In file included from src/qt/overviewpage.cpp:2:0:
build/ui_overviewpage.h:13:10: fatal error: QtGui/QAction: Aucun fichier ou dossier de ce type
 #include <QtGui/QAction>
          ^~~~~~~~~~~~~~~
compilation terminated.
Makefile:3513: recipe for target 'build/overviewpage.o' failed
make: *** [build/overviewpage.o] Error 1

I tried installing libqt5gui5 libqt5widgets5 libkf5guiaddons5 but these do not help.

Any idea what I'm missing?