evershopcommerce/evershop

🛍️ NodeJS E-commerce Platform

evershop's Issues

[BUG] Fast refresh performance is not good enough. Need a good improvement

Describe the bug
The fast refresh feature is now available.
It works, but
On the first time visiting a page, Webpack build will be executed to generate a bundle. This process take so long.
Even though this only happen in development mode, but we need to improve to provide better development experience and performance

To Reproduce
Steps to reproduce the behavior:

1. Start the project in development mode 'npm run dev'
2. Visit a page

Tax management

Develop a module for tax management

[BUG] Warning: Failed prop type: Invalid prop `children` of type `array` supplied to `Alert`, expected a single ReactElement

Describe the bug
Invalid prop provided to the Alert component.

To Reproduce
Steps to reproduce the behavior:

1. Start project in development mode
2. Visit home page
3. See the warning message in the developer console

Expected behavior
The warning message should disappear
Screenshots

"Paid by customer" shows wrong value in order detail

ERROR: can't create a new product

I am working on evershop. can't create a new product

please help

[BUG] Discount showing wrong value in order page

To Reproduce
Steps to reproduce the behavior:

1. Add product to cart
2. Apply a coupon
3. Place an order
4. Go to admin an view order, the discount amount show value as "0"

Expected behavior
The discount line should show the correct discount amount

[BUG] Encountered two children with the same key, `productMainImages`. Keys should be unique

Describe the bug
A warning message when uploading more than 1 image when editing a product

To Reproduce
Steps to reproduce the behavior:

1. Start project in development mode
2. Go to admin and edit a product/create a new product
3. Scroll down to media section and upload 2 images
4. See error in the developer console (browser)

Expected behavior
The warning message should disappear

Screenshots

Missing <meta name="viewport"> tag in default frontstore theme

Missing the Code of Conduct

Hello,
I have seen your project and your project is currently missing the Code of Conduct. If you want to add one, then I can submit a PR including that. In that case, I would need your contact address (email address) so that I can add it to the Code of Conduct as well. Please let me know what do you think about this.

Emailing (SendGrid)

This module takes care of email transaction

• Order confirmation
• Customer registration
• Order update

Consider using SendGrid for email service

[BUG] Use `PropTypes.node` for children prop instead of `PropTypes.element`

Describe the bug
In order to avoid errors like Invalid prop children of type array supplied to Component, expected a single ReactElement we should replace PropTypes.element where is used with PropTypes.node. According to the documentation Element is a subtype of node which includes numbers, strings, elements or an array (or fragment) containing these types.

To Reproduce
Steps to reproduce the behavior:

1. Start project in development mode
2. Visit home page
3. See the warning message in the developer console

Expected behavior
No errors observed in console.

Screenshots

Background (please complete the following information):
N/A

Additional context
N/A

[FEATURE REQUEST] Stop reloading page when customer filtering

On category page, when customer filter for options, we are reloading the page.
This is not good for user experience.

When an option is selected, call API to update the product list and stop reloading

[BUG] Product image remove all

Describe the bug
When editing a product with multiple image, Click a trash icon to remove 1 image. All image got removed

Expected behavior
Only corresponding image should be removed. The rest should stay

[BUG] Failed prop type: Invalid prop `coreComponents[0].component.default` supplied to `Area`, expected a ReactNode.

Describe the bug
In Area component
A Warning message: Failed prop type: Invalid prop coreComponents[0].component.default supplied to Area, expected a ReactNode

To Reproduce
Steps to reproduce the behavior:

1. Start project in development mode 'npm run dev'
2. Go to homepage
3. Open the developer console
4. See error

Expected behavior
The warning message should be gone

Screenshots

[BUG] Layered navigation does not show selected options correctly

Describe the bug
Layered navigation does not show selected options correctly

To Reproduce
Steps to reproduce the behavior:

1. Visit a category page
2. Filter by attribute with more than 1 selected option

Expected behavior
All selected options must be marked as selected

Actual results
Only one option was marked as selected

CMS Pages not working

Test Link: https://demo.evershop.io/page/about-use

[BUG] Can not update attribute group name

Describe the bug
Go to attribute grid and try to update a group name. The page refresh without any change, group name stays the same

Missing title when editing an attribute

Google analytics

Implement GA for EverShop

Route addToCart is not existed

When I run npm run build, I get this error:

npm: 8.3.0
node: 17.3.1

Configuration property "system.database.host" is not defined

i am installing evershop and facing this error
❌ Error: Configuration property "system.database.host" is not defined

please hepl

Build failure

Running npm run build fails with following stack trace :
ERROR in ./node_modules/@evershop/evershop/src/lib/components/react/server/render.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Cannot find module '@babel/core'
Require stack:

• /Users/../Projects/my-app/node_modules/babel-loader/lib/index.js
• /Users/../Projects/my-app/node_modules/loader-runner/lib/loadLoader.js
• /Users/../Projects/my-app/node_modules/loader-runner/lib/LoaderRunner.js
• /Users/../Projects/my-app/node_modules/webpack/lib/NormalModuleFactory.js
• /Users/../Projects/my-app/node_modules/webpack/lib/Compiler.js
• /Users/../Projects/my-app/node_modules/webpack/lib/webpack.js
• /Users/../Projects/my-app/node_modules/webpack/lib/index.js
• /Users/../Projects/my-app/node_modules/@evershop/evershop/bin/build/complie.js
• /Users/../Projects/my-app/node_modules/@evershop/evershop/bin/build/index.js
• /Users/../Projects/my-app/node_modules/@evershop/evershop/bin/evershop
  babel-loader@8 requires Babel 7.x (the package '@babel/core'). If you'd like to use Babel 6.x ('babel-core'), you should install 'babel-loader@7'.
  at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
  at Function.Module._load (internal/modules/cjs/loader.js:746:27)
  at Module.require (internal/modules/cjs/loader.js:974:19)
  at require (internal/modules/cjs/helpers.js:101:18)
  at Object. (/Users/../Projects/my-app/node_modules/babel-loader/lib/index.js:7:11)
  at Module._compile (internal/modules/cjs/loader.js:1085:14)
  at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
  at Module.load (internal/modules/cjs/loader.js:950:32)
  at Function.Module._load (internal/modules/cjs/loader.js:790:12)
  at Module.require (internal/modules/cjs/loader.js:974:19)

Server (webpack 5.75.0) compiled with 40 errors in 636 ms
Unhandled Rejection at: Promise Promise { null } reason: null

Selected variant is not displayed in cart item list

When customer add a product with variant to cart, selected variant property should be displayed (color, size)

[FEATURE REQUEST] Stop reloading when customer select variant

On product single page, when customer select for variant, we are reloading the page.

This should be avoided. Use API to update the product information instead of reloading the page

[BUG] An error occcurred when running the build command

When i try run npm run build, I got the error:

WARNING: NODE_ENV value of 'production' did not match any deployment config file names.
WARNING: See https://github.com/lorenwest/node-config/wiki/Strict-Mode
Error: ENOENT: no such file or directory, mkdir 'D:\wordpress\evershop-main\.evershop\build'
    at mkdirSync (node:fs:1349:3)
    at Object.<anonymous> (D:\wordpress\evershop-main\packages\core\bin\build\index.js:43:3)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (D:\wordpress\evershop-main\packages\core\bin\evershop:21:5)
    at Module._compile (node:internal/modules/cjs/loader:1105:14) {
  errno: -4058,
  syscall: 'mkdir',
  code: 'ENOENT',
  path: 'D:\\wordpress\\evershop-main\\.evershop\\build'
}

[BUG] Back to previous page, cart is not updated

Describe the bug
When click the browser back button, the mini cart icon does not show the up-to-date cart information

To Reproduce
Steps to reproduce the behavior:

1. Start a new session with no cart
2. Add a product to shopping cart
3. Visit shopping cart page
4. Click the back button

Expected behavior
Mini cart icon should show the new cart information

Actual result
The mini cart shows outdated information

[BUG] Product thumbnail should be clickable

On the product list, the product thumbnails are not clickable now.
Expectation: They should be clickable and go to product detail page

[QUESTION] Should we separate GraphQL schema for backend and frontend?

As you may know, EverShop is using GraphQL for data loading/fetching. It works just fine.

But during the implementation, I have a question to raise: Should we separate GraphQL schema for backend and frontend?

Because sometime, we have some field that only available for the admin user.
For example, The order list type should only be available for admin user to query.

To do that, I see 2 options:

1. Implement the authorization on query field
2. Separate the Schema, some field only available in admin (admin/graphql)

What is the better option to you?

Thanks

[BUG] Each child in a list should have a unique "key" prop.

Describe the bug
In Area component
A Warning message: Each child in a list should have a unique "key" prop.

To Reproduce
Steps to reproduce the behavior:

1. Start project in development mode 'npm run dev'
2. Go to homepage
3. Open the developer console
4. See error

Expected behavior
The warning message should be gone

Screenshots

Error: ENOENT: no such file or directory, stat '...\.evershop\build\admin\attributeEdit'

I am facing an error when runing the build command
✖ Error: ENOENT: no such file or directory, stat '\evershop\.evershop\build\admin\attributeEdit'

Please help. Thanks!

Paypal standard payment method

Implement Paypal standard payment method

ERROR: Lost image

I am working Evershop
I go to admin to create a new product -> I upload a picture and save.
I lost my image when creating a product.
Please help

[BUG] Can not remove item from cart

To Reproduce
Steps to reproduce the behavior:

1. Add some product to cart
2. Go to shopping cart and remove item

Actual behavior
Nothing happen, the item still in the cart

Expected behavior
The item should be remove, cart page should be updated with new item list

Supporting nested category (parent, child)

Supporting nested category (parent, child)

[FEATURE REQUEST] Code base should adhere to linting rules

Is your feature request related to a problem? Please describe.
The eslint config has not been followed

Describe the solution you'd like

• Run npx eslint packages/evershop/src --fix to fix the minor errors
• Go through the rest of the source files and fix the remaining errors manually
• Add an eslint check to the github actions workflow to enforce adherence to the linting rules

Describe alternatives you've considered

• Add .eslintignore file with "**/*.js" and do it later 😢

Additional context
None

[BUG] ailed prop type: Invalid prop `variant` of value `secondary` supplied to `Badge`, expected one of ["default","success","info","attention","critical","warning","new"]

Describe the bug
A warning message when visiting the order listing page from admin panel

To Reproduce
Steps to reproduce the behavior:

1. Start the project in development mode
2. Go to admin panel and visit the order listing page (Must have some order)
3. See error in the developer console

Expected behavior
The error message should disappear

Screenshots

[BUG] Failed prop type: Invalid prop `featuredProducts[0].productId` of type `string` supplied to `FeaturedProducts`, expected `number`.

Describe the bug
Warning: Failed prop type: Invalid prop featuredProducts[0].productId of type string supplied to FeaturedProducts, expected number.

To Reproduce
Steps to reproduce the behavior:

1. Start project in development mode 'npm run dev'
2. Go to homepage
3. Check the developer console
4. See error

Expected behavior
The warning message should be gone

Screenshots

[BUG] Warning: Failed prop type: The prop `homeUrl` is marked as required in `Logo`, but its value is `undefined`.

Describe the bug
Warning: Failed prop type: The prop homeUrl is marked as required in Logo, but its value is undefined.

To Reproduce
Steps to reproduce the behavior:

1. Start project in development mode 'npm run dev'
2. Go to homepage
3. Check the developer console
4. See error

Expected behavior
The warning message should be gone

Screenshots

[BUG] Failed prop type: Invalid prop `products[0].productId` of type `string` supplied to `ProductList`, expected `number`.

Describe the bug
Warning: Failed prop type: Invalid prop products[0].productId of type string supplied to ProductList, expected number.

To Reproduce
Steps to reproduce the behavior:

1. Start project in development mode 'npm run dev'
2. Go to homepage
3. Check the developer console
4. See error

Expected behavior
The warning message should be gone

Screenshots

Translation

For now. EverShop support English out of the box.
We need to implement a solution for developer to provide their own translation and support other languages

[IMPROVEMENT] Webpack hot module replacement

Hi everyone,

As you may know, EverShop implements HMR feature. When a component is changed, the page will be updated automatically (without loosing the current state).

However, since we implement GraphQL feature, a GraphQL query can be defined directly in the component file
You can check our document for more information
https://evershop.io/docs/development/knowledge-base/data-fetching

The thing is, when a component is changed, we need to detect if the query is changed or not. If the query is changed, we need to reload the entire page. If the query is not changed, we can just let Webpack perform the HRM.

I tried some solution with no luck. Please share if you have any idea to solve this problem

Thank you

GraphQL query grouping

For performance purpose, we need to find a solution to group the Graphql queries.
Same query should be grouped and executed 1 time only

Cart item error does not display on shopping cart page

When an Item has an error. For example "Not enough stock". This error should be display in red on shopping cart.

Actual result: The error is not seen

[BUG] Module parse failed: Unexpected token

i am installing evershop, i am getting error when "npm build": Module parse failed: Unexpected token
error.txt

Improve Variant management

The variant management is available. But need to be refactored.

COD payment

Implement a module for COD(Cash on delivery) payment

Create customer button issue from admin panel

For now, we do not support creating customer account from admin panel. Let's remove this button and route

Error: Body must be a string. Received: undefined.

Error: Body must be a string. Received: undefined.

npm invalid command

Error: Invalid command
at Object. (/home/ituge/codebase/gitlab/sisla_electricals/frontend/node_modules/@evershop/core/bin/evershop:31:11)
at Module._compile (node:internal/modules/cjs/loader:1149:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1203:10)
at Module.load (node:internal/modules/cjs/loader:1027:32)
at Module._load (node:internal/modules/cjs/loader:868:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:23:47

Data too long for column url_key

• Create or Edit product

• nhập text quá dài tại field url_key

• Api: /admin/product/save