ewolfe/prlint

GitHub App for linting pull request meta data

prlint's Issues

Support link is broken

"Details" links to https://github.com/ewolfe/prlint#support which doesn't go anywhere helpful.

An in-range update of eslint-config-airbnb-base is breaking the build 🚨

The devDependency eslint-config-airbnb-base was updated from 13.1.0 to 13.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-config-airbnb-base is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build is in progress (Details).
• ❌ now: Deployment has failed (Details).

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Any update on the recent downtime?

Hi, there! Thanks for creating PRLint. It's been very helpful for our team's workflow.

The service has been down a lot recently – and we're having to manually override the affected PR's. Is this a temporary situation? Or should we look into a different solution for linting our PR's?

If there's anything we can to do help (i.e. it's some sort of technical issue) – let me know!

Cheers

Improve tests

• We can get a little closer to 100%
• nock's URL's need to have additional meta data (body payload) attached to truly verify the test - in the current state there's not really any confidence in the test suite due to the nature of the input/output of this program really dependent on the side effect calls to GitHub's API. Thus the need to build more confidence in the calls to the GH API by setting up stricter nock methods.

Feature request: Better label support

this is really cool - I'm curious: how does it work with labels?
I've often wanted an easy way to block PR merging using labels like dont-merge and allow using ready

I think it would a good idea to massage the data coming from GitHub, so the end user can setup a rule like so:

{
  "labels.names": [
    {
      "pattern": "ready",
      "message": "Please add a 'ready' label"
    },
    {
      "pattern": "!dont-merge",
      "message": "Please remove the 'dont-merge' label"
    }
  ]
}

Thanks to @eudaimos for the feedback!

Add pull request review event

It would be nice to add a rule to require 2 approved review before you can merge a PR. In order to do that we need to setup the pull request review event https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent

An in-range update of eslint-plugin-import is breaking the build 🚨

The devDependency eslint-plugin-import was updated from 2.17.2 to 2.17.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build is in progress (Details).
• ❌ now: Deployment has failed

---

Commits

The new version differs by 25 commits.

• cf5573b Bump to v2.17.3
• caae65c [Tests] eslint 2 does not have linter.version
• 557a3e2 [Deps] update resolve
• 17beb33 Merge pull request #1356 from christophercurrie/typescript-declare
• c8ac7ff [Docs] Document env option for eslint-import-resolver-webpack
• c09c0ce Issue #1258 (docs)
• 753c9db [refactor] fix eslint 6 compat by fixing imports
• b52bf3e PR feedback
• 7aa13d1 PR feedback
• f66e064 Remove log messages
• d1e4455 Verbose variable names
• 67b1e95 Support older typescript parsers
• 288cedf Make groups non-capturing.
• aa290bb Improve support for Typescript declare structures
• 1edbbd0 [Fix] no-common-js: Also throw an error when assigning

There are 25 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Don't send fail status if config not found

The status message:

.github/prlint.json not found

Will get attached the PR when there's no config. This should just be a no-op and not update/fail the status checks on the PR.

An in-range update of request is breaking the build 🚨

The dependency request was updated from 2.88.0 to 2.88.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

request is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ now: Deployment has failed (Details).
• ✅ continuous-integration/travis-ci/push: The Travis CI build passed (Details).

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Exception Report

HTTPError: Response code 400 (Bad Request)

Exception Report

https://app.asana.com/0/793270570460394/1164006751638909/f

Cannot Access `prlint.json` in forks

When a PR is made from the fork to the original repo, the error ".github/prlint.json not found" is displayed despite that file being present in the fork.

My guess is that PRLint does not have permission to access the file in the forked repo? Is there anything we can do to fix this? Many github work flows rely on creating PRs from forks.

onData should be optional

Exception Report

HTTPError: Response code 401 (Unauthorized)

Exception Report

HTTPError: Response code 401 (Unauthorized)

Something went wrong with PRLint

I've been playing around with PRLint but it seems that when I am closing a PR and reopening it again, it fails. Is there a way to see the actual error happening? Currently it asks me to open an issue and just says that something went wrong. See niosus/test-complete-plugin#7 for details.

Allow users to set the "Details" URL on validation failure

It would be interesting to be able to set the URL of the "Details" link whenever validation fails. Linking to prlint.json (which is what PRLint does now) can be useful, but it there are other useful things that can be linked to that can be equally or even more useful (e.g. an internal PR guidelines article, for example).

PRLint isn't reporting status, preventing PR from passing all branch checks

Our company is using PRLint in a private repo. Starting yesterday I think, PRLint is failing to return a status check for the PR title. This is preventing me from merging the PR.

Troubleshooting:

1. Uninstalled/Reinstalled PRLint GitHub app
2. Removed/Added the PRLint status check
3. Changed the PR title

Nothing seems to work. The only alternative at this point is to remove PRLint from the status checks but I don't want to do that.

Unexpected Error

Sometimes prlint has an error even if there is reviewer on the pull request. It gets better when I add someone new

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

prlint failed to give exact error

unable to produce correct error message

Self hosted version

Is it possible to deploy this to a self-hosted service? The source code kind of assumes public GitHub for URLs and stuff so it doesn't seem possible at the moment but it'd be cool if it did support that.

Ignore requested_reviewers if PR is approved

Is there a way to ignore requested_reviewers when the PR is approved ?

Example of the issue:

• PR is opened with a reviewer: prlint ok
• someone review the pr and approve: prlint ok
• "update branch" button to merge master in the branch : prlint fail, event if the pr is still approved

Cannot match characters at end of title

Full disclaimer, I learnt 90% of the regex I know today!

I'm trying to match the last three characters of the PR title. Specifically, an ellipsis to find out if GitHub truncated the PR title.

The rule I have is:

  "title": [
    {
      "pattern": ".*[...]$",
      "message": "Please shorten your title so GitHub doesn't truncate it."
    }
  ],

I would expect it to match "My title..."
It matches "My...title" (that's where my poor regex skills might be at fault).
It also matches "My title ...X" where X is any single character including space but NOT including a fourth period.

I've tried various formulations of the regex pattern (most of them simpler), all with the same result. I've tried using "abc" instead of "..." and get the same thing. It seems to never match three characters if those are the last three.

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Replaced the old Node.js version in your .nvmrc with the new one

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

• engines was only updated if it defined a single version, not a range.
• .nvmrc was updated to Node.js 10
• .travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of localtunnel is breaking the build 🚨

The devDependency localtunnel was updated from 1.9.1 to 1.9.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

localtunnel is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build is in progress (Details).
• ❌ now: Deployment has failed

---

Commits

The new version differs by 7 commits.

• d7330a7 v1.9.2
• 5754959 update History.md
• e9d9203 update debug to 4.1.1
• be3dc1a update axios to 0.19.0
• 4d6db16 update yarn.lock with integrity entries
• 41270db Update node versions and default build environment in travis.yml (#307)
• 42ea8ec Bump to UNRELEASED

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Add support for rules via commitlint

Here are some examples

https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/index.js

An in-range update of lint-staged is breaking the build 🚨

The devDependency lint-staged was updated from 8.1.6 to 8.1.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lint-staged is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build is in progress (Details).
• ❌ now: Deployment has failed

---

Release Notes for v8.1.7

8.1.7 (2019-05-15)

Bug Fixes

• Resolve security vulnerability in dependencies (#615) (315890a), closes #600

Commits

The new version differs by 2 commits.

• 315890a fix: Resolve security vulnerability in dependencies (#615)
• cbf0e0e docs: Correct section about filtering files (#612)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of request-promise-native is breaking the build 🚨

The devDependency request-promise-native was updated from 1.0.7 to 1.0.8.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

request-promise-native is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build is in progress (Details).
• ❌ now: Deployment has failed (Details).

---

Commits

The new version differs by 5 commits.

• 6498be1 Version 1.0.8
• 3e8df67 Merge branch 'master' of https://github.com/request/request-promise-native
• 1592a31 chore: updated request-promise-core that updates lodash
• 171f3b5 Merge pull request #46 from tbjgolden/docs/clarify-es6-finally
• 239ce46 docs: es6+, finally

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

New hosting and serverless implementation - PRLint Reloaded

Sadly PRLint is down for a while now, I'm not sure if it's coming back (waiting for @ewolfe to address this).

As an alternative, you can use PRLint Reloaded. I copied the code of PRLint and wrapped it in a serverless deployment.

An in-range update of concurrently is breaking the build 🚨

The devDependency concurrently was updated from 4.1.0 to 4.1.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

concurrently is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ now: Deployment has failed (Details).
• ✅ continuous-integration/travis-ci/push: The Travis CI build passed (Details).

---

Release Notes for v4.1.1

• bin: pass --prefix-length argument through (#189)

Commits

The new version differs by 2 commits.

• 9181965 4.1.1
• 9529c5e Use prefixLength (#189)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Expose comparison operators

Regular expressions are okay, but sometimes they don't cut it. For example:

"additions": [
  {
    "pattern": "0|^[1-9]$|^[1-9]\\d$",
    "message": "Your PR is too big (over 99 additions)"
  }
]

Would be better written as:

"additions": [
  {
    "less-than": 99,
    "message": "Your PR is too big (over 99 additions)"
  }
]

Exception Report

TypeError: description.slice is not a function

Remove requirement for manually escaping regex's

Exception Report

HTTPError: Response code 401 (Unauthorized)

Status: paused?

Hi,
I have installed PRLint in my repository, and everything was working great until about a month or so ago. With no changes on our end, PRLint stopped reporting statuses.
Going into the app's configuration in the organization screen, I see that the status returned by uptimerobot is paused?

Clicking the status leads to a status page that says it is down since the middle of August, if I understand it correctly

Is there a known issue?
Thanks in advance

Setup webhook secret

https://developer.github.com/webhooks/securing/

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.