ex_aws_sns's People
Forkers
ddresselhaus sabondano lessless baishan axelson mbklein venndr wkirschbaum kianmeng ascandella mayoms brunozrk data-twister xpositivityx nherzing nickforall warrenseine avenueplace colmbenex_aws_sns's Issues
Is this repo still maintained?
Breaking change on 2.3.1
Hey,
version 3.2.1 added a compile time requirement for :ex_aws, :json_codec
configuration that breaks all installations that doesn't have it in place: https://github.com/ex-aws/ex_aws_sns/blob/main/lib/ex_aws/sns.ex#L135.
This configuration is optional on ex_aws
and falls back to Jason
, so we can't assume it's there.
Moreover using Application.fetch_env!/2
on a module body is discouraged and yields a warning on recent elixir.
So I think we could just change this to be handled within put_value/3
using something like
json_codec = Application.get_env(:ex_aws, :json_codec, Jason)
or query ex_aws
directly for the current value.
mix deps.get fails with ex_aws_sns
Environment
- Elixir & Erlang versions (elixir --version): 1.6
- ExAws version
mix deps |grep ex_aws
: locked at 2.0.1 (ex_aws) cb2c03c0 - HTTP client version. IE for hackney do
mix deps | grep hackney
: hackney 1.10.1 (Hex package) (rebar3)
Current behavior
I added the following to mix.exs:
defp deps do
[
{:ex_aws, "~> 2.0"},
{:ex_aws_sns, "~> 2.0"}
]
end
Running mix deps.get
results in:
Failed to fetch record for 'hexpm/ex_aws_sns' from registry (using cache)
This could be because the package does not exist, it was spelled incorrectly or you don't have permissions to it
** (Mix) No package with name ex_aws_sns (from: mix.exs) in registry
Does this repo need to be published to hex.pm?
mix.exs deps only for dev/test
Is there a reason that https://github.com/ex-aws/ex_aws_sns/blob/master/mix.exs#L47 has :dev
and :test
only? What I'm running into is that I need to include sweet_xml
as a dependency myself in order for ex_aws_sns
to parse the xml response from AWS properly.
I'm happy to open up a PR if you agree.
confirm_subscription: Invalid parameter: TopicArn
Environment
- Elixir 1.5.2
- ex_aws 2.0.2, ex_aws_sns 2.0.0
- hackney 1.8.6
Current behavior
Trying to use ExAws.SNS.confirm_subscription to confirm an incoming subscription request.
%{"TopicArn" => topic_arn, "Token" => token} = body
response = ExAws.SNS.confirm_subscription(topic_arn, token, false)
|> ExAws.request
However, I get the following response:
{:error,
{:http_error, 400,
%{code: "InvalidParameter", detail: "",
message: "Invalid parameter: TopicArn",
request_id: "cc46f3e1-9893-54d6-8bb3-a14fb1b218ca", type: "Sender"}}}
Currently, I'm just using HTTPoison
to follow the SubscribeURL
.
Expected behavior
Response should be :ok
and the subscription should be created.
Publish Batch release
Hey maintainer, we would like to use the publish_batch/2
function, but there is not a release including it, it's only on Github. Is it stable to be used? If so, do you plan to publish a new version to hex?
New Release
It seems like there are enough changes between the released 2.0.1 and master to justify a new release, and Hex won't let me release my package with this as a dependency until I specify a released version. I know you're probably pretty busy with Absinthe things, @benwilson512, so I'm happy to volunteer if you'd like a second maintainer/publisher on this package.
S3 Opted Out List
Is it possible to do something like
https://hexdocs.pm/ex_aws_s3/ExAws.S3.html#module-examples
to stream the list of Phone Numbers which are opted out?
ExAws.SNS.verify_message has incorrect return type in typespec
Environment
- Elixir 1.9.1
ex_aws 2.1.1
ex_aws_sns 2.0.1
hackney 1.15.2
Current behavior
In sns.ex:337 the ExAws.SNS.verify_message/1
function has the following typespec:
@spec verify_message(message_params :: %{String.t => String.t}) :: [:ok | {:error, String.t}]
Expected behavior
I think the proper return type in typespec should not have the square brackets:
@spec verify_message(message_params :: %{String.t => String.t}) :: :ok | {:error, String.t}
Which is consistent with the actual return values from verify/3
the "String.Array" is not supported
Current behavior
Currently, the sns supported attributes are these. Unfortunately, this does not include "String.Array".
Expected behavior
For the mentioned data type to be supported.
Failing test: verify_message/1
- Do not use the issues tracker for help or support (try Elixir Forum, Slack, IRC, etc.)
- Questions about how to contribute are fine.
Environment
Elixir 1.9.0 (compiled with Erlang/OTP 20)
Erlang/OTP 21 [erts-10.3] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] [hipe]
- ExAws 2.1.1
- Hackney 1.15.2
Current behavior
I'm trying to submit a PR to provide a new :get_subscription_attributes
parser that properly handles FilterPolicy
and other attributes not currently implemented. In running the test suite, test verify_message/1
fails due to a cert PEM file that cannot be retrieved (likely because it has expired and been replaced by a new PEM).
1) test verify_message/1 validate a pristine message from SNS (ExAws.SNSTest)
test/lib/sns_test.exs:279
Assertion with == failed
code: assert :ok == SNS.verify_message(message)
left: :ok
right: {:error,
"Could not fetch certificate from https://sns.eu-west-1.amazonaws.com/SimpleNotificationService-b95095beb82e8f6a046b3aafc7f4149a.pem, expected http code 200, got: 404"}
stacktrace:
test/lib/sns_test.exs:280: (test)
Expected behavior
Test suite passes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.