example42/puppet-firewall

Example42 Firewall abstraction meta-module

puppet-firewall's Issues

Could not resolve the dependencies.

It looks that the dependencies can't be resolved even if you use this module alone

Puppetfile

forge "http://forge.puppetlabs.com"

mod "firewall",
  :git => "git://github.com/example42/puppet-firwall.git"

librarian-puppet install
Could not resolve the dependencies.

Dependencies are not published on Puppet Forge

This module depends on your iptables module, but the iptables module is not published on Puppet Forge, hence:

$ puppet module install example42-firewall --modulepath=./modules
Preparing to install into /home/danny/workspace/puppet/modules ...
Downloading from http://forge.puppetlabs.com ...
Error: Could not install module 'example42-firewall' (latest: v2.0.0)
  No version of 'example42-iptables' will satisfy dependencies
    'example42-firewall' (v2.0.0) requires 'example42-iptables' (>= 2.0.0)
    Use `puppet module install --ignore-dependencies` to install only this module
$

Could not resolve the dependencies.

Sorry my bad! Was a typo in the issue not in the Puppetfile, a wrong URL don't shows problems with dependencies.

$ cat Puppetfile
forge "http://forge.puppetlabs.com"

mod "firewall",
  :git => "git://github.com/example42/puppet-firewall.git"
work at imac-work in ~/Desktop/test2
$ librarian-puppet install
Could not resolve the dependencies.

You've closed the ticket too fast without confirm, Now I think you won't get notifications so I'm gonna open a new issue.

PS: I've tested with librarian-puppet-maestrodev 0.9.7.2 and librarian-puppet v0.9.8 , both the same

Misunderstanding, how it works

Hello, Alessandro!
I have little problem with your module.
Example:

  firewall { "rabbitmq-5672":
      protocol    => 'tcp',
      port        => 5672,
      destination => '192.168.21.16',
      tool        => 'iptables',
  }

Creates rule for iptables without specification of destination:

-A INPUT   -p tcp --dport 5672 -j ACCEPT -m comment --comment "rabbitmq-5672"

Librarian failed to resolve dependencies

I'm just trying to move away from git submodules for my vagrant modules and use librarian.

Here's my Puppetfile:

mod 'puppetlabs-stdlib',
:git => "git://github.com/puppetlabs/puppetlabs-stdlib.git"

mod 'puppi',
:git => 'git://github.com/example42/puppi'

mod 'puppetlabs-apache',
:git => 'git://github.com/puppetlabs/puppetlabs-apache'

mod 'puppetlabs-apt',
:git => "git://github.com/puppetlabs/puppetlabs-apt.git"

mod 'puppet-php',
:git => 'git://github.com/example42/puppet-php'

mod 'puppet-postfix',
:git => 'git://github.com/example42/puppet-postfix'

mod 'puppet-java',
:git => 'git://github.com/example42/puppet-java'

mod 'puppet-tomcat',
:git => 'git://github.com/example42/puppet-tomcat'

And here's the issue I get when running librarian-install:

Resolving example42-iptables (>= 2.0.0) <(no source specified)>
Checking manifests
Failed to resolve example42-iptables (>= 2.0.0) <(no source specified)>

I also get the following:

Checking puppetlabs-concat/1.0.0-rc1 https://forge.puppetlabs.com
Conflict between puppetlabs-concat/1.0.0-rc1 https://forge.puppetlabs.com and puppetlabs-concat (>= 1.1.1) https://forge.puppetlabs.com
Backtracking from puppetlabs-concat/1.0.0-rc1 https://forge.puppetlabs.com
Failed to resolve puppetlabs-concat (>= 1.0.0) https://forge.puppetlabs.com

I'm quite new to librarian but I can't seem to resolve this. Not sure if it is an issue with puppet-firewall, but it seems to get to puppet-firewall when resolving dependencies.

Pinned to a specific version of iptables?

Expected Behavior

Runs without errors in Centos 6.9 (and later)

Actual Behavior

Repeatedly tries to downgrade iptables-1.4.7-16.el6.x86_64 to iptables-1.4.7.el6.x86_64 which generates an error in puppet 3.8 and so faile to restart iptables service because of a dependency failure

Steps to Reproduce the Problem

1. Running puppet to install a very simple ip tables rule set under centos 6.9 and example42-firewall (2.1.3)

Specifications

Please add this info:

1. Output of facter -p on the failing node (at least the OS related facts)

rpm-qa.txt
facter-p.txt

1. Version of Puppet and of the module

Puppet modules (from master):
/etc/puppet/modules
├── androidstudio (???)
├─┬ domcleal-augeasproviders (v1.2.0)
│ └── puppetlabs-stdlib (v4.2.2)
├── x2go (???)
├─┬ herculesteam-augeasproviders_shellvar (v2.2.1)
│ └── herculesteam-augeasproviders_core (v2.1.3)
├── maestrodev-wget (v1.7.0)
├── criticalupdate (???)
├─┬ csncl-cs42_firewall (v0.1.0)
│ └─┬ cs-example42_firewall (v2.1.3)
│ ├── example42-puppi (v2.1.10)
│ └─┬ example42-iptables (v2.1.15)
│ └── puppetlabs-concat (v2.1.0)
├── cs_auth3 (v1.9.0)
├─┬ csncl-cs_firewall (v0.1.0)
│ └── puppetlabs-firewall (v1.7.1)
├── cs_licenses (???)
├── csncl-cs_local_users (v0.1.0)
├── cs_motd (v0.1.0)
├── cs_sysctl (v0.5.0)
├── csncl-cssupportedit (v0.1.0)
├── stahnma-epel (v1.0.0)
├── weeklyupdate (???)
├── csncl-templatemodule (v0.1.0)
├── rohlfs-gconf (v0.0.6)
├── csncl-groups (v0.1.0)
├── hourlycron (???)
├── interfaces (???)
├── saz-resolv_conf (v3.0.5)
├── sessionm-puppet_r (v0.0.2)
├── helen-lightdm (v0.1.0)
├── puppetlabs-lvm (v0.9.0)
├── ncl-matlab (v0.1.0)
├── reboot (???)
├─┬ example42-network (v3.1.5)
│ └── example42-stdmod (v0.0.4)
├─┬ example42-nrpe (v2.0.12)
│ ├── UNMET DEPENDENCY example42-firewall (>= 2.0.0)
│ └── example42-monitor (v2.0.1)
├── puppetlabs-ntp (v1.0.0-rc1)
├── openstack (???)
├── thias-postfix (v0.3.3)
├── rcoleman-puppet_module (v0.0.3)
├── razorsedge-network (v3.4.0)
└── kdm (???)

1. The relevant Puppet code and eventually Hiera data

I wonder if the following patch might address this issue - but only until the version of Centos is changed. I think something better is needed... Can someone (at least) explain why this version of the firewall needs to be pinned to a specific version of the iptables package?

--- modules/firewall/spec/unit/facter/iptables_spec.rb (revision 5641)
+++ modules/firewall/spec/unit/facter/iptables_spec.rb (working copy)
@@ -11,7 +11,7 @@
it {
allow(Facter::Util::Resolution).to receive(:exec).with('iptables --version').
and_return('iptables v1.4.7')

•  Facter.fact(:iptables_version).value.should == '1.4.7'
  

•  Facter.fact(:iptables_version).value.should =~ /^1\.4\.7\W/
  

  }
  end

@@ -18,6 +18,6 @@
describe 'ip6tables_version' do
before { allow(Facter::Util::Resolution).to receive(:exec).
with('ip6tables --version').and_return('ip6tables v1.4.7') }

• it { Facter.fact(:ip6tables_version).value.should == '1.4.7' }

• it { Facter.fact(:ip6tables_version).value.should =~ /^1.4.7\W/ }
  end
  end

Thanks.. Chris Ritson.