Cancelling Sign Usage - Getting ItemStack in BlockPlacement

[exceptionflug]

Cancelling Sign Usage - Getting ItemStack in BlockPlacement

[A248]

This issue should probably get the question label.

[Exceptionflug]

Hey thank you for using Protocolize!

To your question number one:

You can simply add support for custom packets at your own. There are simple things you need:

1. A map containing every protocol id and the packet's according packet id from that version. Example click here.
2. A class extending the de.exceptionflug.protocolize.api.protocol.AbstractPacket class. For example click here.
3. Documentation about the packet layout for all supported protocol versions. For sign change this would be the link for the 1.14.4 protocol: https://wiki.vg/Protocol#Update_Sign
   You can find documentation for older protocol versions right here: https://wiki.vg/Protocol_version_numbers
4. In the class you have to override the read(ByteBuf buf, Direction direction, int protocolVersion) and write(ByteBuf buf, Direction direction, int protocolVersion) methods. Take a look at other protocolize pre-implemented packets like BlockPlacement.
5. Register the packet using ProtocolAPI.getPacketRegistration().registerPacket(Protocol protocol, Direction direction, Class<? extends AbstractPacket> clazz, Map<Integer, Integer> protocolIdMapping);. For example click here.
   That's all. Now you can use your own implemented packet like the others.

To your second question:

This is not possible since this requires experimental features to be enabled which I don't recommend. Protocolize is not able to track the spigot inventory contents when those experimental features are disabled. The only recommended way is the way stated above. Otherwise you could have accessed the PlayerInventory using InventoryManager.getInventory(UUID uuid); and get the item from the held item slot.

Another thing I have to mention: Please don't use AbstractPacket.setCancelSend(boolean cancelSend); anymore. Please cancel the event itself instead :)

For further questions I am ready to help :)

[Exceptionflug]

Implementing SignUpdate at next update v1.5.0

[Exceptionflug]

In fbdd5a2 you will find an implementation of SignUpdate coming to the next major protocolize release supporting 1.15 next week.

[A248]

Thank you! I honestly didn't expect this feature to be added so quickly.

You certainly know much more than I do about packets. I doubt I could implement a sign-change packet myself. However, I'm glad you are able and willing :)

[Exceptionflug]

No problem. You can use an early version of v1.5.0 by cloning and building the 1.15 branch. Artifact is deployed to maven repo.

[A248]

Don't worry, I was competent enough to figure that out myself using maven dependency resolution.

[A248]

SignUpdate packet now added to master branch courtesy of Exceptionflug. https://github.com/Exceptionflug/protocolize/blob/master/protocolize-world/src/main/java/de/exceptionflug/protocolize/world/packet/SignUpdate.java