excid3/acts_as_tenant

Easy multi-tenancy for Rails in a shared database setup.

👋 I'm a Ruby and Rails developer building things for the community.

💻 Here's a few of the projects I'm working on:

• GoRails - Screencasts for Ruby on Rails developers
• Jumpstart - A complete Ruby on Rails SaaS template
• Hatchbox - Hosting for Ruby and Rails apps
• RailsBytes - Reusable templates for adding features to Ruby on Rails apps
• Rails Hackathon - A weekend hackathon for Ruby on Rails developers to get together and build their ideas.
• Pay - A complete payments engine for Ruby on Rails apps
• Noticed - Notifications system for Ruby on Rails apps
• ActsAsTenant - Multitenancy for Ruby on Rails apps
• A bunch of other Ruby gems

✨ You can follow me on Twitter @excid3

If you like my work and want me to be able to keep improving it, please sponsor me on GitHub.

acts_as_tenant's Issues

Relationship cache causes unexpected behaviour

Hi @excid3, thanks for forking it and taking a stab on maintaining acts_as_tenant.

I introduced tenancy to an app early this year and have encountered unexpected behaviour due to this override:

https://github.com/excid3/acts_as_tenant/blob/master/lib/acts_as_tenant/model_extensions.rb#L177-L183

The gains are negligible, less than 0.5ms, and ActiveRecord caches that if we're calling the tenant object over and over with the same object.

If the tenant object changed/updated underneath between when it was first loaded to when the association is called, it causes to return a stale object. That's pretty much what I've hit a few times until forking and dropping these lines: https://github.com/fivegoodfriends/acts_as_tenant/commit/33ac6cfee2e339f3883cdd945e0df00297ff959d

By letting belongs_to work as intended, it hits the db, taking less than 0.5ms, and AR caches it for free after that.

At the time I wrote the initial issue at ErwinM's repo, I didn't find the reason behind the caching through looking commit history.

Is there a real need for it you may be aware of?
Would you consider accepting a PR that drops it?
I'd be happy to do the work.

I appreciate your help and time.