existentialmutt/ajax_modal_rails

ajax-driven modals for rails apps using bootstrap 4

ajax_modal_rails's Issues

some sugar for the layout munging

You should provide a note about the layout magic and maybe some sugar to customize it, so if you have a controller that uses layout for non-ajax stuff it falls back to this rather than nil. I just put this at the top of one controller:

module Foo
  class Bar < Baz
    include OneThing
    include AjaxModalRails::Controller

    layout ->(_) { ajax_modal_request? ? ajax_modal_layout : 'what_is_otherwise_expected' }

It took a little poking about in the source code for me to see that this is what I needed to do. Maybe you could provide non_ajax_layout or something, so this would have been

module Foo
  class Bar < Baz
    include OneThing
    include AjaxModalRails::Controller

    non_ajax_layout  'what_is_otherwise_expected'

Remove bootstrap dependency

We could do the modal stuff w/ our own HTML/CSS

make modal more intuitively closable

I'm thinking people will expect to be able to close the modal by clicking on the grey mask layer or by pressing escape.

Render close modal

This will allow the modal window to close w/our redirecting the underlying page