expert-m/aiohttp-rpc

A simple JSON-RPC for aiohttp

import world


michael_sulyak = world.people.get_or_create(
  name='Michael Sulyak',
  site='https://sulyak.info/',
  linkedin='https://www.linkedin.com/in/michael-sulyak/',
)

while True:
  try:
    michael_sulyak.create_something_cool()
  except world.exceptions.BaseException:
    pass

aiohttp-rpc's Issues

Provide a way to send notification from the server

To deliver notifications from the server to the client, it's conventional for the server to act as a client by sending an id-less request to the client - the JSON-RPC spec defines a client as the origin of request and the server as the origin of response objects and either node can fill either one or both of those roles. Would you consider providing a way for the server to send Request objects to the client?

WsJsonRpcClient callers not receiving ConnectionResetError

Within a WsJsonRpcClient async context, if an underlying socket connection fails while one or more tasks' API calls are in progress (ie, taking a few seconds, with either a long timeout or no timeout) then all these waiting tasks just hang in limbo, and don't see any exceptions.

It seems there's no mechanism for detecting the connection has died, and then calling .notify_all_about_error(exc) to throw the relevant exception up the chain for all of the current pending callers.

Is there any way to ensure access to all relevant exceptions for tasks calling remote API methods on a WsJsonRpcClient websocket connection?

The aiohttp-rpc is not tagged with "Framework :: Aiohttp" classifier on Pypi

Hello,

A MR on the pypa repository to add the classifier "Framework :: Aiohttp" is opened.

The PyPI moderators ask to have 10 (or more) other project maintainers submit comments on the requesting issue about their desire to use the "Framework :: Aiohttp" classifier on their already-published project.

Please could you add a comment with a link to your package on pypi:

pypa/trove-classifiers#54

Thanks

Mutating state of started aiohttp.web.Application is deprecated

I migrated one of my codebases to aiohttp-rpc today and had pytest emit the following warning:

/[...]/aiohttp_rpc/server/websocket.py:22: DeprecationWarning: Changing state of started or joined application is deprecated
  http_request.app[self.ws_state_key] = weakref.WeakSet()

I aso do not expect that a library should interact with the app dictionary at all - a user could conceivably store something in app["rcp_websockets"] which aiohttp-rpc would then overwrite.

WebSocket server can only handle one request at a time

The blocks until a response is sent meaning that the server can only handle one request a time:

aiohttp-rpc/aiohttp_rpc/server/websocket.py

Line 41 in 135e2c6

await self._handle_ws_msg(http_request, ws_msg)

Problem/Solution: JSONRPC over HTTPS with self-signed certs

aiohttp-rpc framework is great, but doesn't seem to provide easy way to support self-signed certs and sessions (or user-provided SSLContext objects, or user provided CA bundle files).

To do this, I've needed to subclass off JsonRpcClient, to:

• accept a constructor arg to provide custom SSL info
• override .connect() to use a subclass of aiohttp.ClientSession
• override .call() to capture session key after successful login

Also, subclass aiohttp.ClientSession to:

• override .post() to inject ssl keyword (for user-provided custom SSL info), plus session key header

With these mods, I can now use self-signed certs on the server and validate them in the client with an SSLContext based on the server's CA public key

This is working, but it took me a fair effort to get it solid. I'd recommend allowing for a constructor arg for aiohttp_rpc.JsonRpcServer to allow users to provide their own SSL objects, to cover for cases of private connections with self-signed certs.

I'm happy to rework the company-proprietary code I did for this and send in proof of concept if needed.

Cheers
David

Custom json decoder

Hi, sometimes you may want to use custom json decoder, but now it is not possible.
What do you think about new BaseJsonRpcClient field json_deserialize?
It should be passed into https://github.com/expert-m/aiohttp-rpc/blob/master/aiohttp_rpc/client/http.py#L51 and used https://github.com/expert-m/aiohttp-rpc/blob/master/aiohttp_rpc/client/websocket.py#L221

PEP 561 compatibility

Hello.
Thank you for your library. It saves us much time for RPC-API implementation. Unfortunately, It is not compatible with PEP 561, so we cannot use its type hints for type checking with mypy.

I can make a PR to fix this if you don't mind.

Custom aiohttp POST params

Hi, what do you think about possibility to pass params in aiohttp post request?
E.g, I want to pass my custom unique per request header or timeout.
I suppose, we can start from direct_call and send_json.
They can be modified this way:

async def direct_call(self, rpc_request: JsonRpcRequest, **kwargs) -> JsonRpcResponse:

and

async def send_json(self,
                        data: typing.Any, *,
                        without_response: bool = False, **kwargs) -> typing.Tuple[typing.Any, typing.Optional[dict]]:
        merged_kwargs = merge_kwargs(self.request_kwargs, kwargs) (IMO, kwargs should be prioritized)
        http_response = await self.session.post(self.url, json=data, **merged_kwargs)

The idea is, if you need some request customization, you will use direct_call, otherwise call.