Leaky bucket strategy

[Zirafnik]

Leaky bucket strategy

[nfriedly]

That's a good idea! I don't think I want to do it for the default store due to the additional overhead and complexity it adds, but I'd be happy for you to build a new store that implemented your strategy.

We have a guide for creating your own store at https://github.com/express-rate-limit/express-rate-limit/wiki/Creating-Your-Own-Store and then once you have it ready, I'd link to it from the Readme here.

[Zirafnik]

Hey,

I am currently utilizing the Redis store. I was not aware this is handled at the store level?

I thought the express-rate-limiter decided on the strategy (e.g. "Wait for this amount of time, then clear the counter.") and the Stores just exposed the API to do it.

Although it makes sense, for the reset-timers to be handled on the Store level.

So to confirm: It is up to the Stores to determine how they will handle resets?

[nfriedly]

Yes, it is up to the stores. Most do a per-user window with the count being reset when the user's window expires, but the default one does a global window with all users getting reset at the same time so that it only needs a single timer running.

It's something I might look into changing eventually, but it'd be a big and likely breaking change, so I'm not sure it will ever happen.