Comments (7)
How does one ask Express to process a POST with a header for 'content-encoding: deflate' where the data is raw (without the data headers and footers)?
Sorry, I missed this direct question at the top 😅. There isn't really a good way to do this with body-parser currently. You can always use the raw() parser and delete req.headers['content-encoding'] . But perhaps a better method would be someone who needs this feature can contribute an API to define custom decoders based on the content-encoding (and override existing ones with their custom impls).
from body-parser.
It's interesting that expressjs goes outside the standard to support deflate raw in node-fetch, but remains strict in body-parser.
I'm not sure what leads you to believe that the expressjs project manages node-fetch. We only manage the projets in our expresssjs github organization. I'm not even sure who manages node-fetch, but it is certainly unrelated to expressjs.
It's also interesting to realize that after all this time, the standard is a bit off and could have been improved.
We don't manage the standards, just implement them. If you think the standards should be changed, you should reach out to the standard organization that manages that particular one and have them update it.
from body-parser.
So body-parser will use the Node.js zlib.createInflate()
to inflate the data from deflate. Does Node.js support inflating that particular data? If not, then it would not be aupported here, either. If you're not sure, if you can provide the raw bytes you are trying to inflate I can help investigate. Are you also getting any error and if so what is the error?
from body-parser.
Oh, I see what you are asking. This is not supported because that is not allowed for content-encoding deflate token. The zlib header is required for that token. You can find more information in the token registry: https://www.iana.org/assignments/http-parameters/http-parameters.xhtml
from body-parser.
I am happy to reopen if you can point to where in the specifcication / iana registry that content-encoding is allowed to be set to "deflate" without the zlib header.
from body-parser.
I'm after cutting some fat out of a large internet of things deployment. Gzip wastes 18 bytes per transaction with redundant information like crc and data size.
deflate with zlib header wastes 2 and 4 for the footer.
deflate raw drops all 18 bytes.
I'm not sure how to peek that first byte in body-parser the way node-fetch does to switch off for both... but just changing that one line does work.
case 'deflate':
stream = zlib.createInflateRaw()
from body-parser.
It's interesting that expressjs goes outside the standard to support deflate raw in node-fetch, but remains strict in body-parser.
It's also interesting to realize that after all this time, the standard is a bit off and could have been improved.
What it says now...
'deflate'
Using the zlib structure (defined in RFC 1950) with the deflate compression algorithm (defined in RFC 1951).
What it should say...
'deflate'
Using the deflate compression algorithm (defined in RFC 1951).
'zlib'
Using the zlib structure (defined in RFC 1950) with the deflate compression algorithm (defined in RFC 1951).
from body-parser.
Related Issues (20)
- bodyParser is deprecated, error HOT 1
- bodyparser.json() shown as deprecated? (question) HOT 7
- pass options to qs thru urlencoded? HOT 4
- Cannot catch SyntaxError when user provides invalid JSON in body and content-type: application/json HOT 3
- req.body could not be accessed when send as form data, but works fine with JSON HOT 3
- Pass custom parameters to `qs` HOT 3
- Update iconv-lite to latest 0.6.3 HOT 7
- support for ndjson
- Regular Expression Denial of Service (ReDoS) in [email protected] HOT 3
- Update `debug` dependency (memory leak leading to vulnerability) HOT 1
- api calls made with invalid json HOT 5
- Add support for removing body parser limit HOT 8
- BadRequestError: request size did not match content length HOT 7
- How to handle content-type mismatch? HOT 1
- CVE-2017-20165 - debug HOT 2
- Issue HOT 1
- Debug package version in body parser showing security vulnerability HOT 10
- fails silently if the json has extra whitespace HOT 2
- json middleware does not work on content types with a `+` HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from body-parser.