Giter Site home page Giter Site logo

Comments (5)

dougwilson avatar dougwilson commented on April 27, 2024

Hello! I'm sorry I don't fully understand what you are asking. If you are referring to the stack trace on the page, you can change that, as it is an express thing, nothing with this module. See https://expressjs.com/en/guide/error-handling.html#the-default-error-handler

If that is not what you are looking for, please let me know and I can reopen your issue 👍

from body-parser.

yildreams avatar yildreams commented on April 27, 2024

Hello Dougles,

Thanks for your answer, I try to apply that refer but it ddnt work, I think its about body parser .

let me explain again.

this is my index.js file

var morgan = require('morgan');
var express = require('express');
var bodyParser = require('body-parser');
var app = express();
const rateLimit = require('express-rate-limit');

var port = 3000;

  const apiLimiter = rateLimit({
    windowMs:60000, // 1 minutes
    max: 1, // Limit each IP to 100 requests per `window` (here, per 1 minutes)
    standardHeaders: true, // Return rate limit info in the `RateLimit-*` headers
    message:"Too many request in last 1 mimute! Rate limit is 100 requests per minute!",
    legacyHeaders: false, // Disable the `X-RateLimit-*` headers
  })
  
  app.use(bodyParser.json({limit: '50mb'}));
  app.use(bodyParser.urlencoded({limit: '50mb', extended: true}));
  

  app.use(morgan('common'));

  app.use('/', apiLimiter);
  app.get('/', (req, res) => {
    res.json({message: 'Hello world'})
  })

  app.post('/', (req, res) => {
    res.json({message: req.body})
  })
  //

  app.listen(port);
  console.log('Magic happens on port ' + port);

normally it works fine, but when I try with invalid json, like just *, throws an uncaught error. I would be very happy if you try and help.

thank you so much.

from body-parser.

yildreams avatar yildreams commented on April 27, 2024

by the way, when I comment out the body parser lines, it works fine.

from body-parser.

dougwilson avatar dougwilson commented on April 27, 2024

Hi, where did you try what was in the link? I don't see you having an error handler anywere in the code you provided.

from body-parser.

yildreams avatar yildreams commented on April 27, 2024

Hi,

I tried a lot but in the last case I forgot to add the following code block:

app.use((err, req, res, next) => {
    res.status(500).send('Something broke!')
  })

after adding this code , I can now handle the error.

however, adding it above or below the limiter does not prevent it from being placed on the limits.

this situation may not be related to parser, it is already 2nd importance for me, but I have shared such a widow,
thank you for your attention.
regards,
Serdar

from body-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.