Giter Site home page Giter Site logo

Comments (9)

Fishrock123 avatar Fishrock123 commented on April 26, 2024

@cavweb20 Are you doing SSL inside or outside of the node process? (if at all?)

Also, which version of cookie-session?

from cookie-session.

darthcav avatar darthcav commented on April 26, 2024

@Fishrock123: It does not work either way, with or without SSL (I guess you mean HTTPS).

from cookie-session.

Fishrock123 avatar Fishrock123 commented on April 26, 2024

Works for me with [email protected] and [email protected] -- can you try updating express and cookie-parser?

from cookie-session.

darthcav avatar darthcav commented on April 26, 2024

I tried that already. Actual config is:

package.json:

...
        "body-parser": "1.0.2",
        "cookie-session": "1.0.2",
        "express": "4.1.2",
        "morgan": "1.0.1",
        "serve-favicon": "2.0.0",
...

application code:

...
var express = require("express");
var bodyParser = require("body-parser");
var cookieSession = require("cookie-session");
var favicon = require("serve-favicon");
var morgan = require("morgan");
...
app.use(morgan({ "stream" : access, "format" : "default" }));
app.use(express.static(app.get("public")));
app.use(favicon(path.join(app.get("public"), "images", "favicon.ico")));
app.use(bodyParser());
app.use(cookieSession({
        "name" : "sid",
        "keys" : [ "bla" ]
}));
...

environment:

export NODE_ENV=production

from cookie-session.

raine avatar raine commented on April 26, 2024

I initially thought I have the same issue but seems that once you add a property to req.session the cookie is finally set.

app.use(function(req, res, next) {
  req.session.foo = 'bar';
  next();
});

Perhaps this is the intended behavior, although I was expecting a session to be created with some kind of unique identifier for the user in any case.

Also the README says,

If a session is new a Set-Cookie will be produced regardless of populating the session.

from cookie-session.

raine avatar raine commented on April 26, 2024

I'm also noticing that when using Chrome to GET /, res.writeHead() doesn't get called thus not setting the cookies, meanwhile if I just curl http://localhost/index.html, writeHead() is called and cookies are sent.

edit: Why does Accept: text/html header prevent writeHead from happening?

from cookie-session.

darthcav avatar darthcav commented on April 26, 2024

@raine: You are right, the cookie is only set when you write some parameter to the session. I don't think that it should be the expected behaviour, but I may be wrong.

from cookie-session.

tiaozi0912 avatar tiaozi0912 commented on April 26, 2024

@raine Do you define

app.use(livereload({port: livereloadport}));

before the cookie-session middleware? That caused me the issue same as yours

from cookie-session.

dougwilson avatar dougwilson commented on April 26, 2024

This is 100% a bug in connect-livereload module. it should never be doing this: https://github.com/intesso/connect-livereload/blob/v0.4.0/index.js#L94-L98 which will mess up a lot of things in node.js. you can track the fix for this over at intesso/connect-livereload#41

from cookie-session.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.