Giter Site home page Giter Site logo

urlrouter's Issues

Routing .all()

How would you feel about a .all() that matches any verb?

archive this repo?

ref: expressjs/discussions#134

@fengmk2 - you have been identified as the last / most active committer in this repo which is inactive for a while. This ping is to check with you to determine:

  • whether do you have any specific maintenance plans with this repo
  • are you fine for this repo to be archived
  • do you believe if there is another stake holder / affected party who should know

thanks!

old router vs new router

In the olden days I could use a route such as

/files/:id/:filename? and that would match paths like

  • /files/1234
  • /files/1234/big
  • /files/1234/big.png
  • /files/1234/big-bird
  • /files/1234/big-bird.png

I just converted an old-old-old app over and this new urlrouter handles that for paths like

  • /files/1234
  • /files/1234/big
  • /files/1234-678/big

But not

  • /files/1234-678/big.png
  • /files/1234-678/big-bird
  • /files/1234-678/big-bird.png

Is that a bug? It seems like it since :id is matching as expected, so why is :filename matching differently, y'know?

If not, is there an equivalent?

As a quick and simple fix I expanded to matching

  • /files/:id/:filename
  • /files/:id

and that seems to work as expected

Anyway, just wanted to know if "that's how we roll" these days or if it's a bug.

docs for formatting

It's looks like it's similar to regex, but with some custom name-group type stuff. It's definitely not the router from connect 1.x (which I maintained for a little while after its abandonment, btw https://github.com/coolaj86/connect_router).

The link provided in "express format routing" is broken, so there aren't any docs there.

Using with connect.static()

When I combine connect.static() and urlrouter static paths return 404 not found error.

node v0.10.13
urlrouter v0.0.5
connect v.2.12.0

please ignore this issue

undefined is not a function

when set route function is undefined, will throw an error.

TypeError: undefined is not a function
    at Object.lookup [as handle] (/Users/mk2/git/todo/node_modules/urlrouter/lib/urlrouter.js:71:18)
    at next (/Users/mk2/git/todo/node_modules/connect/lib/proto.js:190:15)
    at Object.handle (/Users/mk2/git/todo/node_modules/connect-render/lib/render.js:173:5)
    at next (/Users/mk2/git/todo/node_modules/connect/lib/proto.js:190:15)
    at Object.handle (/Users/mk2/git/todo/node_modules/connect/lib/middleware/csrf.js:48:88)
    at next (/Users/mk2/git/todo/node_modules/connect/lib/proto.js:190:15)
    at /Users/mk2/git/todo/node_modules/connect/lib/middleware/session.js:299:9
    at /Users/mk2/git/todo/node_modules/connect/lib/middleware/session.js:322:9
    at Array.0 (/Users/mk2/git/todo/node_modules/connect/lib/middleware/session/memory.js:52:9)
    at EventEmitter._tickCallback (node.js:192:40)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.